cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): directives without selector should not be supported (#28021)

Browse Source 
PR Close #28021
This commit is contained in:
Marc Laval
2019-01-09 17:55:23 +01:00
committed by Andrew Kushnir
parent 7374dfd1fa
commit 76ed13bffe
4 changed files with 55 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/core/test/linker/integration_spec.ts
View File

@ -1423,21 +1423,19 @@ function declareTests(config?: {useJit: boolean}) {
expect(getDOM().querySelectorAll(fixture.nativeElement, 'script').length).toEqual(0);
});
fixmeIvy('FW-662: Components without selector are not supported')
.it('should throw when using directives without selector', () => {
@Directive({})
class SomeDirective {
}
it('should throw when using directives without selector', () => {
@Directive({})
class SomeDirective {
}
@Component({selector: 'comp', template: ''})
class SomeComponent {
}
@Component({selector: 'comp', template: ''})
class SomeComponent {
}
TestBed.configureTestingModule({declarations: [MyComp, SomeDirective, SomeComponent]});
expect(() => TestBed.createComponent(MyComp))
.toThrowError(
`Directive ${stringify(SomeDirective)} has no selector, please add it!`);
});
TestBed.configureTestingModule({declarations: [MyComp, SomeDirective, SomeComponent]});
expect(() => TestBed.createComponent(MyComp))
.toThrowError(`Directive ${stringify(SomeDirective)} has no selector, please add it!`);
});
it('should use a default element name for components without selectors', () => {
let noSelectorComponentFactory: ComponentFactory<SomeComponent> = undefined !;