cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(router): fix router test failing on IE (#36742)

Browse Source 
This was originally fixed in #35976, but one of the window.scrollY
assertions was missed. Also updated tests to use toBeGreater/LessThan
to improve failure messages.

PR Close #36742
This commit is contained in:
Andrew Scott 2020-04-21 09:59:39 -07:00 committed by Matias Niemelä
parent 54883cb477
commit 7743c43529
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/router/test/bootstrap.spec.ts
View File

@ -297,7 +297,6 @@ describe('bootstrap', () => {
const res = await platformBrowserDynamic([]).bootstrapModule(TestModule);
const router = res.injector.get(Router);
const location: Location = res.injector.get(Location);
await router.navigateByUrl('/aa');
window.scrollTo(0, 5000);
@ -317,12 +316,12 @@ describe('bootstrap', () => {
expect(getScrollY()).toEqual(0);
await router.navigateByUrl('/aa#marker2');
expect(getScrollY() >= 5900).toBe(true);
expect(window.scrollY < 6000).toBe(true); // offset
expect(getScrollY()).toBeGreaterThanOrEqual(5900);
expect(getScrollY()).toBeLessThan(6000); // offset
await router.navigateByUrl('/aa#marker3');
expect(getScrollY() >= 8900).toBe(true);
expect(getScrollY() < 9000).toBe(true);
expect(getScrollY()).toBeGreaterThanOrEqual(8900);
expect(getScrollY()).toBeLessThan(9000);
done();
});