From 774f6fb177ed7d5d05602d3229c47a5ab1c4e27e Mon Sep 17 00:00:00 2001 From: Kara Date: Wed, 31 Oct 2018 14:38:06 -0700 Subject: [PATCH] fixup! docs: add `Function Inlining` rules to `PERF_NOTES.md` Co-Authored-By: mhevery --- packages/core/src/render3/PERF_NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/render3/PERF_NOTES.md b/packages/core/src/render3/PERF_NOTES.md index ff8e7d0790..5fcb21f285 100644 --- a/packages/core/src/render3/PERF_NOTES.md +++ b/packages/core/src/render3/PERF_NOTES.md @@ -72,7 +72,7 @@ Avoid recursive functions when possible because they cannot be inlined. VMs gain a lot of speed by inlining functions which are small (such as getters). This is because the cost of the value retrieval (getter) is often way less than the cost of making a function call. -VMs use the heuristic of size to determine wether a function should be inline. +VMs use the heuristic of size to determine whether a function should be inline. Thinking is that large function probably will not benefit inlining because the overhead of function call is not significant to the overall function execution. Our goal should be that all of the instructions which are in template function should be inlinable.