cargdev/angular
1
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases Wiki Activity

test(animations): properly reference body node for SSR environments (#23300)

Browse Source 
PR Close #23300
This commit is contained in:
Matias Niemelä
2018-04-10 15:10:29 -07:00
committed by Miško Hevery
parent 7e7ef8ee25
commit 776bc38999
8 changed files with 32 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/animations/browser/test/render/timeline_animation_engine_spec.ts
View File

@ -9,15 +9,16 @@ import {AnimationMetadata, animate, style} from '@angular/animations';
import {AnimationStyleNormalizer, NoopAnimationStyleNormalizer} from '../../src/dsl/style_normalization/animation_style_normalizer';
import {AnimationDriver} from '../../src/render/animation_driver';
import {getBodyNode} from '../../src/render/shared';
import {TimelineAnimationEngine} from '../../src/render/timeline_animation_engine';
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_animation_driver';
(function() {
const defaultDriver = new MockAnimationDriver();
function makeEngine(driver?: AnimationDriver, normalizer?: AnimationStyleNormalizer) {
function makeEngine(body: any, driver?: AnimationDriver, normalizer?: AnimationStyleNormalizer) {
return new TimelineAnimationEngine(
driver || defaultDriver, normalizer || new NoopAnimationStyleNormalizer());
body, driver || defaultDriver, normalizer || new NoopAnimationStyleNormalizer());
}
// these tests are only mean't to be run within the DOM
@ -35,7 +36,7 @@ import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_a
afterEach(() => document.body.removeChild(element));
it('should animate a timeline', () => {
const engine = makeEngine();
const engine = makeEngine(getBodyNode());
const steps = [style({height: 100}), animate(1000, style({height: 0}))];
expect(MockAnimationDriver.log.length).toEqual(0);
invokeAnimation(engine, element, steps);
@ -43,7 +44,7 @@ import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_a
});
it('should not destroy timeline-based animations after they have finished', () => {
const engine = makeEngine();
const engine = makeEngine(getBodyNode());
const log: string[] = [];
function capture(value: string) {
@ -66,7 +67,8 @@ import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_a
it('should normalize the style values that are animateTransitioned within an a timeline animation',
() => {
const engine = makeEngine(defaultDriver, new SuffixNormalizer('-normalized'));
const engine =
makeEngine(getBodyNode(), defaultDriver, new SuffixNormalizer('-normalized'));
const steps = [
style({width: '333px'}),
@ -82,7 +84,7 @@ import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_a
it('should normalize `*` values', () => {
const driver = new SuperMockDriver();
const engine = makeEngine(driver);
const engine = makeEngine(getBodyNode(), driver);
const steps = [
style({width: '*'}),

5
packages/animations/browser/test/render/transition_animation_engine_spec.ts
View File

@ -11,6 +11,7 @@ import {TriggerAst} from '../../src/dsl/animation_ast';
import {buildAnimationAst} from '../../src/dsl/animation_ast_builder';
import {buildTrigger} from '../../src/dsl/animation_trigger';
import {AnimationStyleNormalizer, NoopAnimationStyleNormalizer} from '../../src/dsl/style_normalization/animation_style_normalizer';
import {getBodyNode} from '../../src/render/shared';
import {TransitionAnimationEngine} from '../../src/render/transition_animation_engine';
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_animation_driver';
@ -34,8 +35,8 @@ const DEFAULT_NAMESPACE_ID = 'id';
afterEach(() => { document.body.removeChild(element); });
function makeEngine(normalizer?: AnimationStyleNormalizer) {
const engine =
new TransitionAnimationEngine(driver, normalizer || new NoopAnimationStyleNormalizer());
const engine = new TransitionAnimationEngine(
getBodyNode(), driver, normalizer || new NoopAnimationStyleNormalizer());
engine.createNamespace(DEFAULT_NAMESPACE_ID, element);
return engine;
}