cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): add polyfill for goog.getMsg to unblock tests (FW-663) (#27218)

Browse Source 
PR Close #27218
This commit is contained in:
Andrew Kushnir
2018-11-21 11:46:41 -08:00
committed by Jason Aden
parent 8424f587b0
commit 7773d7f552
3 changed files with 40 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/core/test/linker/ng_container_integration_spec.ts
View File

@ -11,7 +11,7 @@ import {AfterContentInit, AfterViewInit, Component, ContentChildren, Directive,
import {TestBed} from '@angular/core/testing';
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';
import {expect} from '@angular/platform-browser/testing/src/matchers';
import {fixmeIvy} from '@angular/private/testing';
import {fixmeIvy, polyfillGoogGetMsg} from '@angular/private/testing';
{
if (ivyEnabled) {
@ -26,6 +26,11 @@ function declareTests(config?: {useJit: boolean}) {
describe('<ng-container>', function() {
beforeEach(() => {
// Injecting goog.getMsg-like function into global scope to unblock tests run outside of
// Closure Compiler. It's a *temporary* measure until runtime translation service support is
// introduced.
polyfillGoogGetMsg();
TestBed.configureCompiler({...config});
TestBed.configureTestingModule({
declarations: [
@ -38,17 +43,16 @@ function declareTests(config?: {useJit: boolean}) {
});
});
fixmeIvy('FW-663: ReferenceError: goog is not defined') &&
it('should support the "i18n" attribute', () => {
const template = '<ng-container i18n>foo</ng-container>';
TestBed.overrideComponent(MyComp, {set: {template}});
const fixture = TestBed.createComponent(MyComp);
it('should support the "i18n" attribute', () => {
const template = '<ng-container i18n>foo</ng-container>';
TestBed.overrideComponent(MyComp, {set: {template}});
const fixture = TestBed.createComponent(MyComp);
fixture.detectChanges();
fixture.detectChanges();
const el = fixture.nativeElement;
expect(el).toHaveText('foo');
});
const el = fixture.nativeElement;
expect(el).toHaveText('foo');
});
fixmeIvy('FW-678: ivy generates different DOM structure for <ng-container>') &&
it('should be rendered as comment with children as siblings', () => {