refactor(): use const and let instead of var
This commit is contained in:

committed by
Victor Berchet

parent
73593d4bf3
commit
77ee27c59e
@ -12,9 +12,9 @@ declare var expect: any;
|
||||
// TODO (juliemr): remove this method once this becomes a protractor plugin
|
||||
export function verifyNoBrowserErrors() {
|
||||
browser.manage().logs().get('browser').then(function(browserLog: any[]) {
|
||||
var errors: any[] = [];
|
||||
const errors: any[] = [];
|
||||
browserLog.filter(logEntry => {
|
||||
var msg = logEntry.message;
|
||||
const msg = logEntry.message;
|
||||
console.log('>> ' + msg);
|
||||
if (logEntry.level.value >= webdriver.logging.Level.INFO.value) {
|
||||
errors.push(msg);
|
||||
|
@ -59,8 +59,8 @@ export class AsyncObservablePipeComponent {
|
||||
// protractor will not see us. Also we want to have this outside the docregion so as not to confuse
|
||||
// the reader.
|
||||
function setInterval(fn: Function, delay: number) {
|
||||
var zone = Zone.current;
|
||||
var rootZone = zone;
|
||||
const zone = Zone.current;
|
||||
let rootZone = zone;
|
||||
while (rootZone.parent) {
|
||||
rootZone = rootZone.parent;
|
||||
}
|
||||
|
@ -10,7 +10,7 @@ import {$, ExpectedConditions, browser, by, element} from 'protractor';
|
||||
import {verifyNoBrowserErrors} from '../../../../_common/e2e_util';
|
||||
|
||||
function waitForElement(selector: string) {
|
||||
var EC = ExpectedConditions;
|
||||
const EC = ExpectedConditions;
|
||||
// Waits for the element with id 'abc' to be present on the dom.
|
||||
browser.wait(EC.presenceOf($(selector)), 20000);
|
||||
}
|
||||
@ -19,7 +19,7 @@ describe('pipe', () => {
|
||||
afterEach(verifyNoBrowserErrors);
|
||||
|
||||
describe('async', () => {
|
||||
var URL = '/common/pipes/ts/';
|
||||
const URL = '/common/pipes/ts/';
|
||||
|
||||
it('should resolve and display promise', () => {
|
||||
browser.get(URL);
|
||||
|
@ -11,7 +11,7 @@ import {NgModule} from '@angular/core';
|
||||
import {BrowserModule} from '@angular/platform-browser';
|
||||
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
|
||||
|
||||
var MyApp: any;
|
||||
let MyApp: any;
|
||||
|
||||
// #docregion url_resolver
|
||||
class MyUrlResolver extends UrlResolver {
|
||||
|
@ -10,7 +10,7 @@ import {$, ExpectedConditions, browser, by, element} from 'protractor';
|
||||
import {verifyNoBrowserErrors} from '../../../../../_common/e2e_util';
|
||||
|
||||
function waitForElement(selector: string) {
|
||||
var EC = ExpectedConditions;
|
||||
const EC = ExpectedConditions;
|
||||
// Waits for the element with id 'abc' to be present on the dom.
|
||||
browser.wait(EC.presenceOf($(selector)), 20000);
|
||||
}
|
||||
@ -19,7 +19,7 @@ describe('animation example', () => {
|
||||
afterEach(verifyNoBrowserErrors);
|
||||
|
||||
describe('index view', () => {
|
||||
var URL = '/core/animation/ts/dsl/';
|
||||
const URL = '/core/animation/ts/dsl/';
|
||||
|
||||
it('should list out the current collection of items', () => {
|
||||
browser.get(URL);
|
||||
|
@ -8,8 +8,8 @@
|
||||
|
||||
import {DebugElement} from '@angular/core';
|
||||
|
||||
var debugElement: DebugElement;
|
||||
var predicate: any;
|
||||
let debugElement: DebugElement;
|
||||
let predicate: any;
|
||||
|
||||
// #docregion scope_all
|
||||
debugElement.query(predicate);
|
||||
|
@ -12,7 +12,7 @@ export function main() {
|
||||
describe('forwardRef examples', () => {
|
||||
it('ForwardRefFn example works', () => {
|
||||
// #docregion forward_ref_fn
|
||||
let ref = forwardRef(() => Lock);
|
||||
const ref = forwardRef(() => Lock);
|
||||
// #enddocregion
|
||||
expect(ref).not.toBeNull();
|
||||
|
||||
@ -32,8 +32,8 @@ export function main() {
|
||||
// Only at this point Lock is defined.
|
||||
class Lock {}
|
||||
|
||||
let injector = ReflectiveInjector.resolveAndCreate([Door, Lock]);
|
||||
let door = injector.get(Door);
|
||||
const injector = ReflectiveInjector.resolveAndCreate([Door, Lock]);
|
||||
const door = injector.get(Door);
|
||||
expect(door instanceof Door).toBeTruthy();
|
||||
expect(door.lock instanceof Lock).toBeTruthy();
|
||||
// #enddocregion
|
||||
@ -41,7 +41,7 @@ export function main() {
|
||||
|
||||
it('can be unwrapped', () => {
|
||||
// #docregion resolve_forward_ref
|
||||
let ref = forwardRef(() => 'refValue');
|
||||
const ref = forwardRef(() => 'refValue');
|
||||
expect(resolveForwardRef(ref)).toEqual('refValue');
|
||||
expect(resolveForwardRef('regularValue')).toEqual('regularValue');
|
||||
// #enddocregion
|
||||
|
@ -14,6 +14,6 @@ import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
|
||||
class MyApp {
|
||||
}
|
||||
|
||||
var myPlatformFactory = createPlatformFactory(platformBrowserDynamic, 'myPlatform');
|
||||
const myPlatformFactory = createPlatformFactory(platformBrowserDynamic, 'myPlatform');
|
||||
myPlatformFactory().bootstrapModule(MyApp);
|
||||
// #enddocregion
|
||||
|
@ -10,8 +10,8 @@
|
||||
import {Observable} from 'rxjs/Observable';
|
||||
import {Subscriber} from 'rxjs/Subscriber';
|
||||
|
||||
var obs = new Observable<number>((obs: Subscriber<number>) => {
|
||||
var i = 0;
|
||||
const obs = new Observable<number>((obs: Subscriber<number>) => {
|
||||
let i = 0;
|
||||
setInterval(() => { obs.next(++i); }, 1000);
|
||||
});
|
||||
obs.subscribe(i => console.log(`${i} seconds elapsed`));
|
||||
|
@ -12,8 +12,8 @@ import 'rxjs/add/operator/map';
|
||||
import {Observable} from 'rxjs/Observable';
|
||||
import {Subscriber} from 'rxjs/Subscriber';
|
||||
|
||||
var obs = new Observable<number>((obs: Subscriber<any>) => {
|
||||
var i = 0;
|
||||
const obs = new Observable<number>((obs: Subscriber<any>) => {
|
||||
let i = 0;
|
||||
setInterval(() => obs.next(++i), 1000);
|
||||
});
|
||||
obs.map((i: number) => `${i} seconds elapsed`).subscribe(msg => console.log(msg));
|
||||
|
@ -11,8 +11,8 @@ import {Observable} from 'rxjs/Observable';
|
||||
import {Subscriber} from 'rxjs/Subscriber';
|
||||
import {map} from 'rxjs/operator/map';
|
||||
|
||||
var obs = new Observable<number>((sub: Subscriber<number>) => {
|
||||
var i = 0;
|
||||
const obs = new Observable<number>((sub: Subscriber<number>) => {
|
||||
let i = 0;
|
||||
setInterval(() => sub.next(++i), 1000);
|
||||
});
|
||||
map.call(obs, (i: number) => `${i} seconds elapsed`).subscribe((msg: string) => console.log(msg));
|
||||
|
@ -9,7 +9,7 @@
|
||||
import {DebugElement} from '@angular/core';
|
||||
import {By} from '@angular/platform-browser';
|
||||
|
||||
var debugElement: DebugElement;
|
||||
let debugElement: DebugElement;
|
||||
class MyDirective {}
|
||||
|
||||
// #docregion by_all
|
||||
|
@ -12,7 +12,7 @@ import {discardPeriodicTasks, fakeAsync, tick} from '@angular/core/testing';
|
||||
// #docregion basic
|
||||
describe('this test', () => {
|
||||
it('looks async but is synchronous', <any>fakeAsync((): void => {
|
||||
var flag = false;
|
||||
let flag = false;
|
||||
setTimeout(() => { flag = true; }, 100);
|
||||
expect(flag).toBe(false);
|
||||
tick(50);
|
||||
|
@ -8,7 +8,7 @@
|
||||
|
||||
import {afterEach, beforeEach, beforeEachProviders, describe, inject, it, xdescribe, xit} from '@angular/core/testing/testing_internal';
|
||||
|
||||
var db: any;
|
||||
let db: any;
|
||||
class MyService {}
|
||||
class MyMockService implements MyService {}
|
||||
|
||||
|
Reference in New Issue
Block a user