refactor(): use const and let instead of var
This commit is contained in:

committed by
Victor Berchet

parent
73593d4bf3
commit
77ee27c59e
@ -19,7 +19,7 @@
|
||||
|
||||
function benchmarksBootstrap() {
|
||||
// check query param
|
||||
var useBundles = location.search.indexOf('bundles=false') == -1;
|
||||
const useBundles = location.search.indexOf('bundles=false') == -1;
|
||||
if (useBundles) {
|
||||
System.config({
|
||||
map: {
|
||||
|
@ -11,22 +11,22 @@ import {getIntParameter, bindAction} from '@angular/testing/src/benchmark_util';
|
||||
declare var angular: any;
|
||||
|
||||
export function main() {
|
||||
var ngEl = document.createElement('div');
|
||||
const ngEl = document.createElement('div');
|
||||
angular.bootstrap(ngEl, ['app']);
|
||||
}
|
||||
|
||||
function loadTemplate(templateId, repeatCount) {
|
||||
var template = document.querySelectorAll(`#${templateId}`)[0];
|
||||
var content = (<HTMLElement>template).innerHTML;
|
||||
var result = '';
|
||||
for (var i = 0; i < repeatCount; i++) {
|
||||
const template = document.querySelectorAll(`#${templateId}`)[0];
|
||||
const content = (<HTMLElement>template).innerHTML;
|
||||
let result = '';
|
||||
for (let i = 0; i < repeatCount; i++) {
|
||||
result += content;
|
||||
}
|
||||
// replace [] binding syntax
|
||||
result = result.replace(/[\[\]]/g, '');
|
||||
|
||||
// Use a DIV as container as Angular 1.3 does not know <template> elements...
|
||||
var div = document.createElement('div');
|
||||
const div = document.createElement('div');
|
||||
div.innerHTML = result;
|
||||
return div;
|
||||
}
|
||||
@ -38,7 +38,7 @@ angular.module('app', [])
|
||||
function($parse) {
|
||||
return {
|
||||
compile: function($element, $attrs) {
|
||||
var expr = $parse($attrs.attr0);
|
||||
const expr = $parse($attrs.attr0);
|
||||
return ($scope) => $scope.$watch(expr, angular.noop);
|
||||
}
|
||||
};
|
||||
@ -50,7 +50,7 @@ angular.module('app', [])
|
||||
function($parse) {
|
||||
return {
|
||||
compile: function($element, $attrs) {
|
||||
var expr = $parse($attrs.attr1);
|
||||
const expr = $parse($attrs.attr1);
|
||||
return ($scope) => $scope.$watch(expr, angular.noop);
|
||||
}
|
||||
};
|
||||
@ -62,7 +62,7 @@ angular.module('app', [])
|
||||
function($parse) {
|
||||
return {
|
||||
compile: function($element, $attrs) {
|
||||
var expr = $parse($attrs.attr2);
|
||||
const expr = $parse($attrs.attr2);
|
||||
return ($scope) => $scope.$watch(expr, angular.noop);
|
||||
}
|
||||
};
|
||||
@ -74,7 +74,7 @@ angular.module('app', [])
|
||||
function($parse) {
|
||||
return {
|
||||
compile: function($element, $attrs) {
|
||||
var expr = $parse($attrs.attr3);
|
||||
const expr = $parse($attrs.attr3);
|
||||
return ($scope) => $scope.$watch(expr, angular.noop);
|
||||
}
|
||||
};
|
||||
@ -86,7 +86,7 @@ angular.module('app', [])
|
||||
function($parse) {
|
||||
return {
|
||||
compile: function($element, $attrs) {
|
||||
var expr = $parse($attrs.attr4);
|
||||
const expr = $parse($attrs.attr4);
|
||||
return ($scope) => $scope.$watch(expr, angular.noop);
|
||||
}
|
||||
};
|
||||
@ -95,22 +95,22 @@ angular.module('app', [])
|
||||
.run([
|
||||
'$compile',
|
||||
function($compile) {
|
||||
var count = getIntParameter('elements');
|
||||
var templateNoBindings = loadTemplate('templateNoBindings', count);
|
||||
var templateWithBindings = loadTemplate('templateWithBindings', count);
|
||||
const count = getIntParameter('elements');
|
||||
const templateNoBindings = loadTemplate('templateNoBindings', count);
|
||||
const templateWithBindings = loadTemplate('templateWithBindings', count);
|
||||
|
||||
bindAction('#compileWithBindings', compileWithBindings);
|
||||
bindAction('#compileNoBindings', compileNoBindings);
|
||||
|
||||
function compileNoBindings() {
|
||||
// Need to clone every time as the compiler might modify the template!
|
||||
var cloned = templateNoBindings.cloneNode(true);
|
||||
const cloned = templateNoBindings.cloneNode(true);
|
||||
$compile(cloned);
|
||||
}
|
||||
|
||||
function compileWithBindings() {
|
||||
// Need to clone every time as the compiler might modify the template!
|
||||
var cloned = templateWithBindings.cloneNode(true);
|
||||
const cloned = templateWithBindings.cloneNode(true);
|
||||
$compile(cloned);
|
||||
}
|
||||
}
|
||||
|
@ -9,9 +9,9 @@
|
||||
import {getIntParameter, getStringParameter, bindAction} from '@angular/testing/src/benchmark_util';
|
||||
declare var angular: any;
|
||||
|
||||
var totalRows = getIntParameter('rows');
|
||||
var totalColumns = getIntParameter('columns');
|
||||
var benchmarkType = getStringParameter('benchmarkType');
|
||||
const totalRows = getIntParameter('rows');
|
||||
const totalColumns = getIntParameter('columns');
|
||||
const benchmarkType = getStringParameter('benchmarkType');
|
||||
|
||||
export function main() {
|
||||
angular.bootstrap(document.querySelector('largetable'), ['app']);
|
||||
@ -45,14 +45,14 @@ angular.module('app', [])
|
||||
$scope.$apply(function() { $scope.benchmarkType = benchmarkType; });
|
||||
}
|
||||
|
||||
var data = $scope.data = [];
|
||||
const data = $scope.data = [];
|
||||
|
||||
function iGetter() { return this.i; }
|
||||
function jGetter() { return this.j; }
|
||||
|
||||
for (var i = 0; i < totalRows; i++) {
|
||||
for (let i = 0; i < totalRows; i++) {
|
||||
data[i] = [];
|
||||
for (var j = 0; j < totalColumns; j++) {
|
||||
for (let j = 0; j < totalColumns; j++) {
|
||||
data[i][j] = {i: i, j: j, iFn: iGetter, jFn: jGetter};
|
||||
}
|
||||
}
|
||||
@ -62,8 +62,8 @@ angular.module('app', [])
|
||||
return {
|
||||
restrict: 'E',
|
||||
link: function($scope, $element) {
|
||||
var i, j, row, cell, comment;
|
||||
var template = document.createElement('span');
|
||||
let i, j, row, cell, comment;
|
||||
const template = document.createElement('span');
|
||||
template.setAttribute('ng-repeat', 'foo in foos');
|
||||
template.classList.add('ng-scope');
|
||||
template.appendChild(document.createElement('span'));
|
||||
@ -94,8 +94,8 @@ angular.module('app', [])
|
||||
return {
|
||||
restrict: 'E',
|
||||
link: function($scope, $element) {
|
||||
var i, j, row, cell, comment;
|
||||
var template = document.createElement('span');
|
||||
let i, j, row, cell, comment;
|
||||
const template = document.createElement('span');
|
||||
template.setAttribute('ng-repeat', 'foo in foos');
|
||||
template.classList.add('ng-scope');
|
||||
|
||||
|
@ -17,7 +17,7 @@ export function main() {
|
||||
}
|
||||
|
||||
function addTreeDirective(module, level: number) {
|
||||
var template;
|
||||
let template;
|
||||
if (level <= 0) {
|
||||
template = `<span> {{data.value}}</span>`;
|
||||
} else {
|
||||
@ -26,8 +26,8 @@ function addTreeDirective(module, level: number) {
|
||||
module.directive(`tree${level}`, function() { return {scope: {data: '='}, template: template}; });
|
||||
}
|
||||
|
||||
var module = angular.module('app', []);
|
||||
for (var depth = 0; depth < MAX_DEPTH; depth++) {
|
||||
const module = angular.module('app', []);
|
||||
for (let depth = 0; depth < MAX_DEPTH; depth++) {
|
||||
addTreeDirective(module, depth);
|
||||
}
|
||||
module.config([
|
||||
@ -37,14 +37,14 @@ module.config([
|
||||
.run([
|
||||
'$rootScope',
|
||||
function($rootScope) {
|
||||
var count = 0;
|
||||
let count = 0;
|
||||
$rootScope.initData = null;
|
||||
|
||||
bindAction('#destroyDom', destroyDom);
|
||||
bindAction('#createDom', createDom);
|
||||
|
||||
function createData(): TreeNode {
|
||||
var values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
const values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', '-'];
|
||||
return buildTree(MAX_DEPTH, values, 0);
|
||||
}
|
||||
|
@ -10,45 +10,45 @@
|
||||
import {getIntParameter, bindAction} from '@angular/testing/src/benchmark_util';
|
||||
import * as React from './react.min';
|
||||
|
||||
var TreeComponent = React.createClass({
|
||||
const TreeComponent = React.createClass({
|
||||
displayName: 'TreeComponent',
|
||||
|
||||
render: function() {
|
||||
var treeNode = this.props.treeNode;
|
||||
const treeNode = this.props.treeNode;
|
||||
|
||||
var left = null;
|
||||
let left = null;
|
||||
if (treeNode.left) {
|
||||
left = React.createElement(
|
||||
"span", {}, [React.createElement(TreeComponent, {treeNode: treeNode.left}, "")]);
|
||||
}
|
||||
|
||||
var right = null;
|
||||
let right = null;
|
||||
if (treeNode.right) {
|
||||
right = React.createElement(
|
||||
"span", {}, [React.createElement(TreeComponent, {treeNode: treeNode.right}, "")]);
|
||||
}
|
||||
|
||||
var span = React.createElement("span", {}, [" " + treeNode.value, left, right]);
|
||||
const span = React.createElement("span", {}, [" " + treeNode.value, left, right]);
|
||||
|
||||
return (React.createElement("tree", {}, [span]));
|
||||
}
|
||||
});
|
||||
|
||||
export function main() {
|
||||
var count = 0;
|
||||
var maxDepth = getIntParameter('depth');
|
||||
let count = 0;
|
||||
const maxDepth = getIntParameter('depth');
|
||||
|
||||
bindAction('#destroyDom', destroyDom);
|
||||
bindAction('#createDom', createDom);
|
||||
|
||||
var empty = new TreeNode(0, null, null);
|
||||
var rootComponent = React.render(React.createElement(TreeComponent, {treeNode: empty}, ""),
|
||||
const empty = new TreeNode(0, null, null);
|
||||
const rootComponent = React.render(React.createElement(TreeComponent, {treeNode: empty}, ""),
|
||||
document.getElementById('rootTree'));
|
||||
|
||||
function destroyDom() { rootComponent.setProps({treeNode: empty}); }
|
||||
|
||||
function createDom() {
|
||||
var values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
const values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', '-'];
|
||||
rootComponent.setProps({treeNode: buildTree(maxDepth, values, 0)});
|
||||
}
|
||||
|
@ -32,18 +32,18 @@ angular.module('app', [])
|
||||
'$compile',
|
||||
'$parse',
|
||||
function($compile, $parse) {
|
||||
var transcludeFn;
|
||||
const transcludeFn;
|
||||
return {
|
||||
compile: function(element, attrs) {
|
||||
var expr = $parse('!!' + attrs.treeIf);
|
||||
var template = '<tree data="' + attrs.treeIf + '"></tree>';
|
||||
var transclude;
|
||||
const expr = $parse('!!' + attrs.treeIf);
|
||||
const template = '<tree data="' + attrs.treeIf + '"></tree>';
|
||||
let transclude;
|
||||
return function($scope, $element, $attrs) {
|
||||
if (!transclude) {
|
||||
transclude = $compile(template);
|
||||
}
|
||||
var childScope;
|
||||
var childElement;
|
||||
let childScope;
|
||||
let childElement;
|
||||
$scope.$watch(expr, function(newValue) {
|
||||
if (childScope) {
|
||||
childScope.$destroy();
|
||||
@ -70,8 +70,8 @@ angular.module('app', [])
|
||||
.run([
|
||||
'$rootScope',
|
||||
function($rootScope) {
|
||||
var count = 0;
|
||||
var maxDepth = getIntParameter('depth');
|
||||
let count = 0;
|
||||
const maxDepth = getIntParameter('depth');
|
||||
|
||||
bindAction('#destroyDom', destroyDom);
|
||||
bindAction('#createDom', createDom);
|
||||
@ -81,7 +81,7 @@ angular.module('app', [])
|
||||
}
|
||||
|
||||
function createDom() {
|
||||
var values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
const values = count++ % 2 == 0 ? ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '*'] :
|
||||
['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', '-'];
|
||||
|
||||
$rootScope.$apply(function() { $rootScope.initData = buildTree(maxDepth, values, 0); });
|
||||
|
Reference in New Issue
Block a user