fix(core): improve global variable detection (#28679)

Closes #16545 PR Close #28679
2019-02-13 18:07:54 +08:00
parent 553f80ff46
commit 77eee42963
5 changed files with 50 additions and 25 deletions
--- a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
+++ b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@ -143,15 +143,9 @@
  {
    "name": "ViewEncapsulation"
  },
-  {
-    "name": "__self"
-  },
  {
    "name": "__values"
  },
-  {
-    "name": "__window"
-  },
  {
    "name": "_currentNamespace"
  },
@ -329,6 +323,9 @@
  {
    "name": "getElementDepthCount"
  },
+  {
+    "name": "getGlobal"
+  },
  {
    "name": "getHighestElementOrICUContainer"
  },
--- a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
+++ b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
@ -116,15 +116,9 @@
  {
    "name": "ViewEncapsulation"
  },
-  {
-    "name": "__self"
-  },
  {
    "name": "__values"
  },
-  {
-    "name": "__window"
-  },
  {
    "name": "_global"
  },
@ -239,6 +233,9 @@
  {
    "name": "getDirectiveDef"
  },
+  {
+    "name": "getGlobal"
+  },
  {
    "name": "getHighestElementOrICUContainer"
  },
--- a/packages/core/test/bundling/todo/bundle.golden_symbols.json
+++ b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@ -278,18 +278,12 @@
  {
    "name": "__read"
  },
-  {
-    "name": "__self"
-  },
  {
    "name": "__spread"
  },
  {
    "name": "__values"
  },
-  {
-    "name": "__window"
-  },
  {
    "name": "_c0"
  },
@ -680,6 +674,9 @@
  {
    "name": "getErrorLogger"
  },
+  {
+    "name": "getGlobal"
+  },
  {
    "name": "getHighestElementOrICUContainer"
  },