From 789ff49bcf958a5e2d44fceb1f8f9bde6d86db3e Mon Sep 17 00:00:00 2001
From: Brandon Roberts <robertsbt@gmail.com>
Date: Mon, 24 Sep 2018 15:24:17 -0500
Subject: [PATCH] docs: update with forms overview review feedback (#25663)

PR Close #25663
---
 aio/content/guide/forms-overview.md | 157 ++++++++++++++++++----------
 1 file changed, 101 insertions(+), 56 deletions(-)

diff --git a/aio/content/guide/forms-overview.md b/aio/content/guide/forms-overview.md
index 7b99d3b6d0..e1e2dd87fa 100644
--- a/aio/content/guide/forms-overview.md
+++ b/aio/content/guide/forms-overview.md
@@ -1,17 +1,27 @@
 # Introduction to forms in Angular
 
-Handling user input with forms is the cornerstone of many common applications. Applications use forms to log in, to update a profile, to enter sensitive information, and to perform many other data-entry tasks. 
+Handling user input with forms is the cornerstone of many common applications. Applications use forms to enable users log in, to update a profile, to enter sensitive information, and to perform many other data-entry tasks. 
 
-Angular provides two different approaches to handling user input through forms: reactive and template-driven. Both capture user input events from the view, validate the user input, create a form model and data model to update, and provide a way to track changes. Each approach uses a distinct way of processing forms and offers different advantages. There are many different factors such as how data flows from the view to the data model and data model to the view, predictability of access to the form model, validation and testing, mutability, and scalability that influence your decision on which approach works best for your situation. The sections below provide a description of the common building blocks with each approach and a comparison of those key factors.
+Angular provides two different approaches to handling user input through forms: reactive and template-driven. Both capture user input events from the view, validate the user input, create a form model and data model to update, and provide a way to track changes. 
+
+Reactive and template-driven forms differ, however, in how they do the work of processing and managing forms and form data. Each offers different advantages.
 
 **In general:**
 
 * **Reactive forms** are more robust: they are more scalable, reusable, and testable. If forms are a key part of your application, or you're already using reactive patterns for building your application, use reactive forms.
 * **Template-driven forms** are useful for adding a simple form to an app, such as an email list signup form. They are easy to add to an app, but they do not scale as well as reactive forms. If you have very basic form requirements and logic that can be managed solely in the template, use template-driven forms.
 
+This guide provides information to help you decide which approach works best for your situation. It introduces the common building blocks used by both approaches. It also summarizes the key differences between the two approaches, and demonstrates those differences in the context of setup, data flow, and testing.
+
+<div class="alert is-important">
+
+*Note:* For complete information about each kind of form, see the [Reactive Forms](guide/reactive-forms) and [Template-driven Forms](guide/forms) guides.
+
+</div>
+
 ## Key differences
 
-The table below summarizes the key differences in reactive and template driven forms.
+The table below summarizes the key differences between reactive and template-driven forms.
 
 <style>
   table {width: 100%};
@@ -20,33 +30,49 @@ The table below summarizes the key differences in reactive and template driven f
 
 ||Reactive|Template-driven|
 |--- |--- |--- |
-|Setup/Form Model|More explicit/Created in the component class.|Less explicit/Created by the directives.|
+|Setup (form model)|More explicit created in the component class.|Less explicit, created by the directives.|
 |Data model|Structured|Unstructured|
 |Predictability|Synchronous|Asynchronous|
 |Form validation|Functions|Directives|
 |Mutability|Immutable|Mutable|
 |Scalability|Low-level API access|Abstraction on top of APIs|
 
-## A common foundation
+## Common foundation
 
 Both reactive and template-driven forms share underlying building blocks. 
 
 - A `FormControl` instance that tracks the value and validation status of an individual form control.
-- A `FormGroup` instance that tracks the same values and statuses for a collection of form controls.
-- A `FormArray` instance that tracks the same values and statues for an array of form controls.
+- A `FormGroup` instance that tracks the same values and status for a collection of form controls.
+- A `FormArray` instance that tracks the same values and status for an array of form controls.
 - A `ControlValueAccessor` that creates a bridge between Angular `FormControl` instances and native DOM elements.
 
-How these control instances are created and managed with reactive and template-driven forms is introduced in the [form model](#the-form-model) section below and detailed further in the [data flow section](#data-flow-in-forms) of this guide.
+How these control instances are created and managed with reactive and template-driven forms is introduced in the [form model setup](#setup-the-form-model) section below and detailed further in the [data flow section](#data-flow-in-forms) of this guide.
 
-## The form model
+## Setup: The form model
 
-In reactive forms, the source of truth is the form model (the `FormControl` instance)
+Reactive and template-driven forms both use a form model to track value changes between Angular forms and form input elements.  The examples below show how the form model is defined and created.
+
+### Setup in reactive forms
+
+Here is a component with an input field for a single control implemented using reactive forms.
+
+<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.ts">
+</code-example>
+
+The source of truth provides the value and status of the form element at a given point in time. In reactive forms, the form model is source of truth. The form model in the above example is the `FormControl` instance.
 
 <figure>
   <img src="generated/images/guide/forms-overview/key-diff-reactive-forms.png" alt="Reactive forms key differences">
 </figure>
 
-With reactive forms, the form model is explicitly defined in the component class. The reactive form directive (in this case, `FormControlDirective`) then links the existing form control instance to a specific form element in the view using a value accessor. Updates from the view-to-model and model-to-view are synchronous and not dependent on the UI rendered.
+With reactive forms, the form model is explicitly defined in the component class. The reactive form directive (in this case, `FormControlDirective`) then links the existing form control instance to a specific form element in the view using a value accessor (instance of `ControlValueAccessor`). 
+
+### Setup in template-driven forms
+
+Here is the same component with an input field for a single control implemented using template-driven forms.
+
+<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.ts">
+</code-example>
 
 In template-driven forms, the source of truth is the template.
 
@@ -54,58 +80,54 @@ In template-driven forms, the source of truth is the template.
   <img src="generated/images/guide/forms-overview/key-diff-td-forms.png" alt="Template-driven forms key differences">
 </figure>
 
-The abstraction of the form model promotes simplicity over structure. It is less explicit, but you no longer have direct control over the form model. Updates from the view-to-model and model-to-view must pass through directives (in this case, the `NgModel` directive), and be asynchronous to work around the change detection cycle. Value changes are delayed until the next tick, which allows change detection to complete and a new change detection process to be triggered with the updated value.
+The abstraction of the form model promotes simplicity over structure. The template-driven form directive `NgModel` is responsible for creating and managing the form control instance for a given form element. It is less explicit, but you no longer have direct control over the form model. 
 
 ## Data flow in forms
 
-When building forms in Angular, it's important to understand how the the framework handles data flowing from the user or from programmatic changes. Reactive and template-driven forms follow two different strategies when handling form input. The components below use an input field to manage the *favorite color* value and to show how changes are handled.
+When building forms in Angular, it's important to understand how the the framework handles data flowing from the user or from programmatic changes. Reactive and template-driven forms follow two different strategies when handling form input. The data flow examples below begin with the favorite color input field example from above, and they show how changes to favorite color are handled in reactive forms compared to template-driven forms.
 
 ### Data flow in reactive forms
 
-Here is a component with an input field for a single control implemented using reactive forms.
-
-<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.ts">
-</code-example>
-
-The diagrams below show how the data flows for an input with reactive forms.
+As described above, in reactive forms each form element in the view is directly linked to a form model (FormControl instance). Updates from the view to model and model to view are synchronous and not dependent on the UI rendered. The diagrams below uses the same favorite color example to demonstrate how data flows when an input field's value is changed from the view and then from the model.
 
 <figure>
-  <img src="generated/images/guide/forms-overview/dataflow-reactive-forms-vtm.png" alt="Reactive forms view to model data flow" width="100%">
+  <img src="generated/images/guide/forms-overview/dataflow-reactive-forms-vtm.png" alt="Reactive forms data flow - view to model" width="100%">
 </figure>
 
-From the view-to-model:
+The steps below outline the view to model data flow.
 
-1. The end user types a value into the input element.
+1. The end user types a value into the input element, in this case the favorite color "Blue".
 1. The form input element emits an input event with the latest value.
-1. The control value accessor on the form input element immediately relays the new value to the `FormControl` instance, which then emits the value through the `valueChanges` observable.
+1. The control value accessor listening for events on the form input element immediately relays the new value to the `FormControl` instance.
+1. The `FormControl` instance emits the new value through the `valueChanges` observable.
+1. Any subscribers to the `valueChanges` observable receive the new value.
 
 <figure>
-  <img src="generated/images/guide/forms-overview/dataflow-reactive-forms-mtv.png" alt="Reactive forms model to view data flow" width="100%">
+  <img src="generated/images/guide/forms-overview/dataflow-reactive-forms-mtv.png" alt="Reactive forms data flow - model to view" width="100%">
 </figure>
 
-From the model-to-view:
+The steps below outline the model to view data flow.
 
-1. The `favoriteColorControl.setValue()` method is called, which updates the `FormControl` value and emits the latest value through the `valueChanges` observable.
-1. The control value accessor on the form input element updates the element with the latest value.
+1. The `favoriteColorControl.setValue()` method is called, which updates the `FormControl` value.
+1. The `FormControl` instance emits the new value through the `valueChanges` observable.
+1. Any subscribers to the `valueChanges` observable receive the new value.
+1. The control value accessor on the form input element updates the element with the new value.
 
 ### Data flow in template-driven forms
 
-Here is the same component with an input field for a single control implemented using template-driven forms.
-
-<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.ts">
-</code-example>
-
-The diagrams below show how the data flows for an input with template-driven forms.
+In template-driven forms each form element in the linked to a directive that manages the form model internally. The diagrams below uses the same favorite color example to demonstrate how data flows when an input field's value is changed from the view and then from the model.
 
 <figure>
   <img src="generated/images/guide/forms-overview/dataflow-td-forms-vtm.png" alt="Template-driven forms view to model data flow" width="100%">
 </figure>
 
-From the view-to-model:
+The steps below outline the view to model data flow.
 
 1. The end user types "Blue" into the input element.
 1. The input element emits an "input" event with the value "Blue".
-1. The control value accessor attached to the input triggers the `setValue()` method on the `FormControl` instance, which emits that value through the `valueChanges` observable.
+1. The control value accessor attached to the input triggers the `setValue()` method on the `FormControl` instance.
+1. The `FormControl` instance emits the new value through the `valueChanges` observable.
+1. Any subscribers to the `valueChanges` observable receive the new value.
 1. The control value accessor also calls the `NgModel.viewToModel()` method which emits an `ngModelChange` event.
 1. Because the component template uses two-way data binding for the `favoriteColor`, the `favoriteColor` property in the component 
 is updated to the value emitted  by the `ngModelChange` event ("Blue").
@@ -114,16 +136,21 @@ is updated to the value emitted  by the `ngModelChange` event ("Blue").
   <img src="generated/images/guide/forms-overview/dataflow-td-forms-mtv.png" alt="Template-driven forms model to view data flow" width="100%">
 </figure>
 
-From the model-to-view:
+The steps below outline the model to view data flow.
 
 1. The `favoriteColor` value is updated in the component.
 1. Change detection calls the `ngOnChanges` method on the `NgModel` directive instance, updates the `NgModel` instance model value, and queues an async task to set the value for the internal `FormControl` instance.
-1. On the next tick, the task to set the `FormControl` instance value is executed, when then emits the latest value through the `valueChanges` observable.
+1. On the next tick, the task to set the `FormControl` instance value is executed.
+1. The `FormControl` instance emits the latest value through the `valueChanges` observable.
+1. Any subscribers to the `valueChanges` observable receive the new value.
 1. The control value accessor updates the form input element in the view with the latest `favoriteColor` value.
 
 ## Form validation
 
-Validation is an integral part of managing any set of forms. Whether you’re checking for required fields or querying an external API for an existing username, Angular provides a set of built-in validators as well as the ability to create custom validators. With reactive forms, custom validators are functions that receive a control to validate. Because template-driven forms are tied to directives, custom validator directives wrap validation functions so that the template can use them.
+Validation is an integral part of managing any set of forms. Whether you’re checking for required fields or querying an external API for an existing username, Angular provides a set of built-in validators as well as the ability to create custom validators.
+
+* **Reactive forms** define custom validators as **functions** that receive a control to validate.
+* **Template-driven forms** are tied to template **directives**, and must provide custom validator directives that wrap validation functions.
 
 For more on form validation, see the [Form Validation](guide/form-validation) guide.
 
@@ -131,47 +158,59 @@ For more on form validation, see the [Form Validation](guide/form-validation) gu
 
 Testing also plays a large part in complex applications and an easier testing strategy is always welcomed. One difference in testing reactive forms and template-driven forms is their reliance on rendering the UI in order to perform assertions based on form control and form field changes. The following examples demonstrate the process of testing forms with reactive and template-driven forms.
 
-### Testing a reactive form
+### Testing reactive forms
 
-Reactive forms provide a relatively easy testing strategy to due to synchronous access to the form and data models, and being independent of the UI. In these set of tests, controls and data are queried and manipulated through the control without interacting with the change detection cycle. The following tests below use the favorite color components mentioned earlier to validate the view-to-model and model-to-view data flows for a reactive form.
+Reactive forms provide a relatively easy testing strategy because they provide synchronous access to the form and data models, and they can be tested without rendering the UI. In these set of tests, controls and data are queried and manipulated through the control without interacting with the change detection cycle.
 
-The following test validates the view-to-model data flow:
+The following tests use the favorite color components mentioned earlier to verify the view to model and model to view data flows for a reactive form.
 
-<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts" region="view-to-model" title="Favorite color test (view-to-model)">
+The following test verifies the view to model data flow:
+
+<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts" region="view-to-model" title="Favorite color test - view to model">
 </code-example>
 
+The steps performed in the view to model test.
+
 1. Query the view for the form input element, and create a custom input event for the test.
 1. Set the new value for the input is set to *Red*, and dispatch the input event on the form input element.
 1. Assert that the `favoriteColor` form control instance value matches in value from the input.
 
-The following test validates the model-to-view data flow:
+The following test verifies the model to view data flow:
 
-<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts" region="model-to-view" title="Favorite color test (model-to-view)">
+<code-example path="forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts" region="model-to-view" title="Favorite color test - model to view">
 </code-example>
 
+The steps performed in the model to view test.
+
 1. Use the `favoriteColor` form control instance to set the new value.
 1. Query the view for the form input element.
 1. Assert that the new value set on the control matches the value in the input.
 
-### Testing a template-driven form
+### Testing template-driven forms
 
-Writing tests with template-driven forms is more involved and requires more detailed knowledge of the change detection process and how directives run on each cycle to ensure elements are queried, tested, or changed at the correct time. The following tests below use the favorite color components mentioned earlier to validate the view-to-model and model-to-view data flows for a template-driven form.
+Writing tests with template-driven forms requires more detailed knowledge of the change detection process and how directives run on each cycle to ensure elements are queried, tested, or changed at the correct time.
 
-The following test validates the view-to-model data flow:
+The following tests use the favorite color components mentioned earlier to verify the view to model and model to view data flows for a template-driven form.
 
-<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts" region="view-to-model" title="Favorite color test (view-to-model)">
+The following test verifies the view to model data flow:
+
+<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts" region="view-to-model" title="Favorite color test - view to model">
 </code-example>
 
+The steps performed in the view to model test.
+
 1. Query the view for the form input element, and create a custom input event for the test.
 1. Set the new value for the input is set to *Red*, and dispatch the input event on the form input element.
 1. Run change detection through the test fixture.
 1. Assert that the component `favoriteColor` property value matches the value from the input.
 
-The following test validates the model-to-view data flow:
+The following test verifies the model to view data flow:
 
-<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts" region="model-to-view" title="Favorite color test (model-to-view)">
+<code-example path="forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts" region="model-to-view" title="Favorite color test - model to view">
 </code-example>
 
+The steps performed in the model to view test.
+
 1. Use the component instance to set the value of `favoriteColor` property.
 1. Run change detection through the test fixture.
 1. Use the `tick()` method to simulate passage of time within the `fakeAsync()` task.
@@ -182,22 +221,28 @@ The following test validates the model-to-view data flow:
 
 How changes are tracked plays a role in the efficiency of your application.
 
-- Reactive forms keep the data model pure by providing it as an immutable data structure. Each time a change is triggered on the data model, the form control instance returns a new data model rather than updating the data model directly. This gives you the ability track unique changes to the data model through the control's observable. This allows change detection to be more efficient because it only needs to update on unique changes. It also follows reactive patterns that integrate with observable operators to transform data.
-- Template-driven forms rely on mutability with two-way data binding to update the data model in the component as changes are made in the template. Because there are no unique changes to track on the data model when using two-way data binding, change detection becomes less efficient at determining when updates are required.
+- **Reactive forms** keep the data model pure by providing it as an immutable data structure. Each time a change is triggered on the data model, the form control instance returns a new data model rather than updating the data model directly. This gives you the ability track unique changes to the data model through the control's observable. This allows change detection to be more efficient because it only needs to update on unique changes. It also follows reactive patterns that integrate with observable operators to transform data.
+- **Template-driven** forms rely on mutability with two-way data binding to update the data model in the component as changes are made in the template. Because there are no unique changes to track on the data model when using two-way data binding, change detection is less efficient at determining when updates are required.
 
-The difference is demonstrated in the examples above using the **favorite color** input element. With reactive forms, the **form control instance** always returns a new value when the control's value is updated. With template-driven forms, the **favorite color property** is always modified to its new value.
+The difference is demonstrated in the examples above using the **favorite color** input element. 
+
+- With reactive forms, the **form control instance** always returns a new value when the control's value is updated.
+- With template-driven forms, the **favorite color property** is always modified to its new value.
 
 ## Scalability
 
-If forms are a central part of your application, scalability is very important. Being able to reuse form models across components is critical. Reactive forms make creating large scale forms easier by providing access to low-level APIs and synchronous access to the form model. Because template-driven forms focus on simple scenarios, they are not as reusable, abstract away the low-level APIs and access to the form model is provided asynchronously. This surfaces in testing also, where testing reactive forms requires less setup and no dependance on the change detection cycle when updating and validating the form and data models during testing.
+If forms are a central part of your application, scalability is very important. Being able to reuse form models across components is critical.
+
+- **Reactive forms** make creating large scale forms easier by providing access to low-level APIs and synchronous access to the form model.
+- **Template-driven** forms focus on simple scenarios, are not as reusable, abstract away the low-level APIs and access to the form model is  provided asynchronously. The abstraction with template-driven forms surfaces in testing also, where testing reactive forms requires less setup and no dependance on the change detection cycle when updating and validating the form and data models during testing.
 
 ## Final Thoughts
 
-Choosing a strategy begins with understanding the strengths and weaknesses of the options presented. Low-level API and form model access, predictability, mutability, straightforward validation and testing strategies, and scalability are all important consideration in choosing the infrastructure you use when building your forms in Angular. Template-driven forms come from a familiar place in AngularJS, but fall short given the criteria in the modern world of Angular apps. Reactive forms integrate with reactive patterns already present in other areas of the Angular architecture, and complement those requirements well.
+Choosing a strategy begins with understanding the strengths and weaknesses of the options presented. Low-level API and form model access, predictability, mutability, straightforward validation and testing strategies, and scalability are all important consideration in choosing the infrastructure you use when building your forms in Angular. Template-driven forms are similar to patterns in AngularJS, but they have limitations given the criteria of many modern, large-scale Angular apps. Reactive forms integrate with reactive patterns already present in other areas of the Angular architecture, and complement those requirements well. Those limitations are alleviated with reactive forms.
 
 ## Next Steps
 
-You can learn more with examples and best practices using reactive forms or template-driven forms. The following guides are the next steps in the learning process.
+The following guides are the next steps in the learning process.
 
 To learn more about reactive forms, see the following guides: