cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(compiler-cli): ngcc - remove unnecessary sourcePath parameters (#29643)

Browse Source 
The `Transformer` and `Renderer` classes do not
actually need a `sourcePath` value as by the time
they are doing their work we are only working directly
with full absolute paths.

PR Close #29643
This commit is contained in:
Pete Bacon Darwin
2019-04-28 20:47:56 +01:00
committed by Andrew Kushnir
parent 1195dabb84
commit 78b5bd5174
8 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler-cli/ngcc/src/rendering/esm5_renderer.ts
View File

@ -15,10 +15,8 @@ import {EntryPointBundle} from '../packages/entry_point_bundle';
import {Logger} from '../logging/logger';
export class Esm5Renderer extends EsmRenderer {
constructor(
logger: Logger, host: NgccReflectionHost, isCore: boolean, bundle: EntryPointBundle,
sourcePath: string) {
super(logger, host, isCore, bundle, sourcePath);
constructor(logger: Logger, host: NgccReflectionHost, isCore: boolean, bundle: EntryPointBundle) {
super(logger, host, isCore, bundle);
}
/**

6
packages/compiler-cli/ngcc/src/rendering/esm_renderer.ts
View File

@ -17,10 +17,8 @@ import {isDtsPath} from '../../../src/ngtsc/util/src/typescript';
import {Logger} from '../logging/logger';
export class EsmRenderer extends Renderer {
constructor(
logger: Logger, host: NgccReflectionHost, isCore: boolean, bundle: EntryPointBundle,
sourcePath: string) {
super(logger, host, isCore, bundle, sourcePath);
constructor(logger: Logger, host: NgccReflectionHost, isCore: boolean, bundle: EntryPointBundle) {
super(logger, host, isCore, bundle);
}
/**

2
packages/compiler-cli/ngcc/src/rendering/renderer.ts
View File

@ -82,7 +82,7 @@ export const RedundantDecoratorMap = Map;
export abstract class Renderer {
constructor(
protected logger: Logger, protected host: NgccReflectionHost, protected isCore: boolean,
protected bundle: EntryPointBundle, protected sourcePath: string) {}
protected bundle: EntryPointBundle) {}
renderProgram(
decorationAnalyses: DecorationAnalyses, switchMarkerAnalyses: SwitchMarkerAnalyses,