cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(compiler-cli): ngcc - remove unnecessary sourcePath parameters (#29643)

Browse Source 
The `Transformer` and `Renderer` classes do not
actually need a `sourcePath` value as by the time
they are doing their work we are only working directly
with full absolute paths.

PR Close #29643
This commit is contained in:
Pete Bacon Darwin
2019-04-28 20:47:56 +01:00
committed by Andrew Kushnir
parent 1195dabb84
commit 78b5bd5174
8 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/compiler-cli/ngcc/test/rendering/esm2015_renderer_spec.ts
View File

@ -19,7 +19,6 @@ import {MockLogger} from '../helpers/mock_logger';
function setup(file: {name: string, contents: string}) {
const logger = new MockLogger();
const dir = dirname(file.name);
const bundle = makeTestEntryPointBundle('es2015', 'esm2015', false, [file]) !;
const typeChecker = bundle.src.program.getTypeChecker();
const host = new Esm2015ReflectionHost(logger, false, typeChecker);
@ -30,7 +29,7 @@ function setup(file: {name: string, contents: string}) {
referencesRegistry, [AbsoluteFsPath.fromUnchecked('/')], false)
.analyzeProgram();
const switchMarkerAnalyses = new SwitchMarkerAnalyzer(host).analyzeProgram(bundle.src.program);
const renderer = new EsmRenderer(logger, host, false, bundle, dir);
const renderer = new EsmRenderer(logger, host, false, bundle);
return {
host,
program: bundle.src.program,

3
packages/compiler-cli/ngcc/test/rendering/esm5_renderer_spec.ts
View File

@ -19,7 +19,6 @@ import {MockLogger} from '../helpers/mock_logger';
function setup(file: {name: string, contents: string}) {
const logger = new MockLogger();
const dir = dirname(file.name);
const bundle = makeTestEntryPointBundle('module', 'esm5', false, [file]);
const typeChecker = bundle.src.program.getTypeChecker();
const host = new Esm5ReflectionHost(logger, false, typeChecker);
@ -30,7 +29,7 @@ function setup(file: {name: string, contents: string}) {
referencesRegistry, [AbsoluteFsPath.fromUnchecked('/')], false)
.analyzeProgram();
const switchMarkerAnalyses = new SwitchMarkerAnalyzer(host).analyzeProgram(bundle.src.program);
const renderer = new Esm5Renderer(logger, host, false, bundle, dir);
const renderer = new Esm5Renderer(logger, host, false, bundle);
return {
host,
program: bundle.src.program,

2
packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts
View File

@ -24,7 +24,7 @@ import {MockLogger} from '../helpers/mock_logger';
class TestRenderer extends Renderer {
constructor(
logger: Logger, host: Esm2015ReflectionHost, isCore: boolean, bundle: EntryPointBundle) {
super(logger, host, isCore, bundle, '/src');
super(logger, host, isCore, bundle);
}
addImports(
output: MagicString, imports: {specifier: string, qualifier: string}[], sf: ts.SourceFile) {