style: Remove use of String as type and use string instead. (#33763)

PR Close #33763
This commit is contained in:
Miško Hevery 2019-11-12 09:08:40 -08:00 committed by Kara Erickson
parent 15f8638b1c
commit 7a29b24720
2 changed files with 3 additions and 4 deletions

View File

@ -171,9 +171,8 @@ export function getPropValuesStartPosition(
} }
export function hasValueChanged( export function hasValueChanged(
a: NO_CHANGE | StylingMapArray | number | String | string | null | boolean | undefined | {}, a: NO_CHANGE | StylingMapArray | number | string | null | boolean | undefined | {},
b: NO_CHANGE | StylingMapArray | number | String | string | null | boolean | undefined | b: NO_CHANGE | StylingMapArray | number | string | null | boolean | undefined | {}): boolean {
{}): boolean {
if (b === NO_CHANGE) return false; if (b === NO_CHANGE) return false;
const compareValueA = Array.isArray(a) ? a[StylingMapArrayIndex.RawValuePosition] : a; const compareValueA = Array.isArray(a) ? a[StylingMapArrayIndex.RawValuePosition] : a;

View File

@ -299,7 +299,7 @@ function makeRequest(scope: SwTestHarness, url: string, clientId?: string): Prom
} }
function makeNoCorsRequest( function makeNoCorsRequest(
scope: SwTestHarness, url: string, clientId?: string): Promise<String|null> { scope: SwTestHarness, url: string, clientId?: string): Promise<string|null> {
const req = new MockRequest(url, {mode: 'no-cors'}); const req = new MockRequest(url, {mode: 'no-cors'});
const [resTextPromise, done] = makePendingRequest(scope, req, clientId); const [resTextPromise, done] = makePendingRequest(scope, req, clientId);
return done.then(() => resTextPromise); return done.then(() => resTextPromise);