cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(language-service): apply suggestion (#34177)

Browse Source 
PR Close #34177
This commit is contained in:
ivanwonder
2019-12-03 10:45:17 +08:00
committed by Andrew Kushnir
parent 148a060daa
commit 7a86a32040
4 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/language-service/src/typescript_symbols.ts
View File

@ -249,8 +249,8 @@ class TypeWrapper implements Symbol {
if (symbol) {
return symbol.name;
} else {
// the js primitive type(e.g. 'string') doesn't have Symbol.
// use the ts.TypeChecker to get the type name.
// A primitive type (e.g. 'string') doesn't have Symbol,
// so use the ts.TypeChecker to get the type name.
return this.context.checker.typeToString(this.tsType);
}
}
@ -314,7 +314,9 @@ class TypeWrapper implements Symbol {
}
}
class StringIndexTypeWrappr extends TypeWrapper {
// If stringIndexType a primitive type(e.g. 'string'), the Symbol is undefined;
// and in AstType.resolvePropertyRead method, the Symbol.type should get the right type.
class StringIndexTypeWrapper extends TypeWrapper {
public readonly type = new TypeWrapper(this.tsType, this.context);
}
@ -516,11 +518,7 @@ class SymbolTableWrapper implements SymbolTable {
// obj.stringIndex // equivalent to obj['stringIndex'];
//
// In this case, return the type indexed by an arbitrary string key.
// if stringIndexType is js primitive type(e.g. 'string'), the Symbol is undefined;
// and In AstType.resolvePropertyRead method, the Symbol.type should get the right type.
// so I add a new Symbol type, 'StringIndexTypeWrappr'
return new StringIndexTypeWrappr(this.stringIndexType, this.context);
return new StringIndexTypeWrapper(this.stringIndexType, this.context);
}
return undefined;