cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "fix(elements): fire custom element output events during component initialization (#36161)" (#37524)

Browse Source 
This reverts commit e9bff5fe9f. Failures
were detected in Google tests due to this commit

PR Close #37524
This commit is contained in:
atscott
2020-06-10 08:31:08 -07:00
committed by atscott
parent 401ef71ae5
commit 7b005bb9cf
4 changed files with 11 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/elements/test/component-factory-strategy_spec.ts
View File

@ -41,33 +41,6 @@ describe('ComponentFactoryNgElementStrategy', () => {
expect(strategyFactory.create(injector)).toBeTruthy();
});
describe('before connected', () => {
it('should allow subscribing to output events', () => {
const events: NgElementStrategyEvent[] = [];
strategy.events.subscribe(e => events.push(e));
// No events before connecting (since `componentRef` is not even on the strategy yet).
componentRef.instance.output1.next('output-1a');
componentRef.instance.output1.next('output-1b');
componentRef.instance.output2.next('output-2a');
expect(events).toEqual([]);
// No events upon connecting (since events are not cached/played back).
strategy.connect(document.createElement('div'));
expect(events).toEqual([]);
// Events emitted once connected.
componentRef.instance.output1.next('output-1c');
componentRef.instance.output1.next('output-1d');
componentRef.instance.output2.next('output-2b');
expect(events).toEqual([
{name: 'templateOutput1', value: 'output-1c'},
{name: 'templateOutput1', value: 'output-1d'},
{name: 'templateOutput2', value: 'output-2b'},
]);
});
});
describe('after connected', () => {
beforeEach(() => {
// Set up an initial value to make sure it is passed to the component