From 7b6ee5e0d95d8d09940e25604c585c04c538dd16 Mon Sep 17 00:00:00 2001
From: George Kalpakas <kalpakas.g@gmail.com>
Date: Thu, 18 Jul 2019 23:33:52 +0300
Subject: [PATCH] ci: move the `test_saucelabs_bazel` CircleCI job to
 `default_workflow` (#31636)

Previously, the `test_saucelabs_bazel` job was run as part of the
`saucelabs_test` workflow every hour (for every "publish branch";
currently 8.0.x, 8.1.x and master).

Since this job runs a subset of the tests in
`legacy-unit-tests-saucelabs` (see [BUILD.bazel][1]) and is just a
proof-of-concept for running tests on SauceLabs via bazel, there is
little point in running is on all branches. It is also wasteful to run
it every hour, even if there were no changes pushed into the branch
since the last run.

This commit makes the job part of `default_workflow`, but limits it to
only be run on master builds (not on other branches or PRs). Based on
its recent history, the job is relatively stable and (since it will only
be run on master builds) it is not expected to affect our dev workflow.

[1]: https://github.com/angular/angular/blob/ef44f51d5/BUILD.bazel#L66-L92

PR Close #31636
---
 .circleci/config.yml | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 6e58052172..32e4238321 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -695,6 +695,12 @@ workflows:
       - legacy-unit-tests-saucelabs:
           requires:
             - setup
+      - test_saucelabs_bazel:
+          requires:
+            - setup
+          filters:
+            branches:
+              only: master
       - test_aio:
           requires:
             - setup
@@ -757,22 +763,6 @@ workflows:
           requires:
             - setup
 
-  saucelabs_tests:
-    jobs:
-      - setup
-      - test_saucelabs_bazel:
-          requires:
-            - setup
-    triggers:
-      - schedule:
-          # Runs the Saucelabs legacy tests every hour. We still want to run Saucelabs
-          # frequently as the caretaker needs up-to-date results when merging PRs or creating
-          # a new release. Also we primarily moved the Saucelabs job into a cronjob that doesn't
-          # run for PRs, in order to ensure that PRs are not affected by Saucelabs flakiness or
-          # incidents. This is still guaranteed (even if we run the job every hour).
-          cron: "0 * * * *"
-          filters: *publish_branches_filter
-
   aio_monitoring:
     jobs:
       - setup