cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): remove cookie and comment testing utilities from DomAdapters (#32278)

Browse Source 
PR Close #32278
This commit is contained in:
Kara Erickson
2019-08-22 16:14:18 -07:00
committed by atscott
parent 4908a5cffc
commit 7bcd42e7be
10 changed files with 29 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/platform-browser/src/browser/browser_adapter.ts
View File

@ -300,7 +300,6 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
return this.isElementNode(el) && el.nodeName === 'TEMPLATE';
}
isTextNode(node: Node): boolean { return node.nodeType === Node.TEXT_NODE; }
isCommentNode(node: Node): boolean { return node.nodeType === Node.COMMENT_NODE; }
isElementNode(node: Node): boolean { return node.nodeType === Node.ELEMENT_NODE; }
hasShadowRoot(node: any): boolean {
return node.shadowRoot != null && node instanceof HTMLElement;
@ -371,12 +370,6 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
supportsCookies(): boolean { return true; }
getCookie(name: string): string|null { return parseCookieValue(document.cookie, name); }
setCookie(name: string, value: string) {
// document.cookie is magical, assigning into it assigns/overrides one cookie value, but does
// not clear other cookies.
document.cookie = encodeURIComponent(name) + '=' + encodeURIComponent(value);
}
}
let baseElement: HTMLElement|null = null;

3
packages/platform-browser/src/dom/dom_adapter.ts
View File

@ -128,7 +128,6 @@ export abstract class DomAdapter {
abstract elementMatches(n: any, selector: string): boolean;
abstract isTemplateElement(el: any): boolean;
abstract isTextNode(node: any): boolean;
abstract isCommentNode(node: any): boolean;
abstract isElementNode(node: any): boolean;
abstract hasShadowRoot(node: any): boolean;
abstract isShadowRoot(node: any): boolean;
@ -153,7 +152,7 @@ export abstract class DomAdapter {
abstract getTransitionEnd(): string;
abstract supportsAnimation(): boolean;
// Used by CookieXSRFStrategy
abstract supportsCookies(): boolean;
abstract getCookie(name: string): string|null;
abstract setCookie(name: string, value: string): any;
}