fix(errors): [2/2] Rename Exception to Error; remove from public API
BREAKING CHANGE: Exceptions are no longer part of the public API. We don't expect that anyone should be referring to the Exception types. ExceptionHandler.call(exception: any, stackTrace?: any, reason?: string): void; change to: ErrorHandler.handleError(error: any): void;
This commit is contained in:

committed by
Victor Berchet

parent
86ba072758
commit
7c07bfff97
@ -6,7 +6,6 @@
|
||||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
import {BaseException} from '@angular/core';
|
||||
|
||||
import {ListWrapper, Map, MapWrapper, StringMapWrapper, isListLikeIterable, iterateListLike} from '../src/facade/collection';
|
||||
import {isBlank} from '../src/facade/lang';
|
||||
@ -163,7 +162,7 @@ export class Headers {
|
||||
/**
|
||||
* This method is not implemented.
|
||||
*/
|
||||
entries() { throw new BaseException('"entries" method is not implemented on Headers class'); }
|
||||
entries() { throw new Error('"entries" method is not implemented on Headers class'); }
|
||||
}
|
||||
|
||||
// "HTTP character sets are identified by case-insensitive tokens"
|
||||
|
@ -9,7 +9,6 @@
|
||||
import {Injectable} from '@angular/core';
|
||||
import {Observable} from 'rxjs/Observable';
|
||||
|
||||
import {makeTypeError} from '../src/facade/exceptions';
|
||||
import {isPresent, isString} from '../src/facade/lang';
|
||||
|
||||
import {BaseRequestOptions, RequestOptions} from './base_request_options';
|
||||
@ -125,7 +124,7 @@ export class Http {
|
||||
} else if (url instanceof Request) {
|
||||
responseObservable = httpRequest(this._backend, url);
|
||||
} else {
|
||||
throw makeTypeError('First argument must be a url string or Request instance.');
|
||||
throw new Error('First argument must be a url string or Request instance.');
|
||||
}
|
||||
return responseObservable;
|
||||
}
|
||||
@ -229,11 +228,11 @@ export class Jsonp extends Http {
|
||||
}
|
||||
if (url instanceof Request) {
|
||||
if (url.method !== RequestMethod.Get) {
|
||||
makeTypeError('JSONP requests must use GET request method.');
|
||||
throw new Error('JSONP requests must use GET request method.');
|
||||
}
|
||||
responseObservable = httpRequest(this._backend, url);
|
||||
} else {
|
||||
throw makeTypeError('First argument must be a url string or Request instance.');
|
||||
throw new Error('First argument must be a url string or Request instance.');
|
||||
}
|
||||
return responseObservable;
|
||||
}
|
||||
|
@ -6,7 +6,6 @@
|
||||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
import {makeTypeError} from '../src/facade/exceptions';
|
||||
import {isString} from '../src/facade/lang';
|
||||
|
||||
import {RequestMethod} from './enums';
|
||||
@ -20,8 +19,7 @@ export function normalizeMethodName(method: string | RequestMethod): RequestMeth
|
||||
(g0: string, g1: string, g2: string) => g1.toUpperCase() + g2.toLowerCase());
|
||||
method = <number>(<{[key: string]: any}>RequestMethod)[method];
|
||||
if (typeof method !== 'number')
|
||||
throw makeTypeError(
|
||||
`Invalid request method. The method "${originalMethod}" is not supported.`);
|
||||
throw new Error(`Invalid request method. The method "${originalMethod}" is not supported.`);
|
||||
}
|
||||
return <RequestMethod>method;
|
||||
}
|
||||
|
@ -6,7 +6,6 @@
|
||||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
import {BaseException} from '@angular/core';
|
||||
import {Json, isString} from '../src/facade/lang';
|
||||
|
||||
import {ResponseOptions} from './base_response_options';
|
||||
|
@ -6,7 +6,7 @@
|
||||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
import {BaseException, Injectable} from '@angular/core';
|
||||
import {Injectable} from '@angular/core';
|
||||
import {ReplaySubject} from 'rxjs/ReplaySubject';
|
||||
import {Subject} from 'rxjs/Subject';
|
||||
import {take} from 'rxjs/operator/take';
|
||||
@ -68,7 +68,7 @@ export class MockConnection implements Connection {
|
||||
*/
|
||||
mockRespond(res: Response) {
|
||||
if (this.readyState === ReadyState.Done || this.readyState === ReadyState.Cancelled) {
|
||||
throw new BaseException('Connection has already been resolved');
|
||||
throw new Error('Connection has already been resolved');
|
||||
}
|
||||
this.readyState = ReadyState.Done;
|
||||
this.response.next(res);
|
||||
@ -214,7 +214,7 @@ export class MockBackend implements ConnectionBackend {
|
||||
verifyNoPendingRequests() {
|
||||
let pending = 0;
|
||||
this.pendingConnections.subscribe((c: MockConnection) => pending++);
|
||||
if (pending > 0) throw new BaseException(`${pending} pending connections to be resolved`);
|
||||
if (pending > 0) throw new Error(`${pending} pending connections to be resolved`);
|
||||
}
|
||||
|
||||
/**
|
||||
@ -233,7 +233,7 @@ export class MockBackend implements ConnectionBackend {
|
||||
*/
|
||||
createConnection(req: Request): MockConnection {
|
||||
if (!isPresent(req) || !(req instanceof Request)) {
|
||||
throw new BaseException(`createConnection requires an instance of Request, got ${req}`);
|
||||
throw new Error(`createConnection requires an instance of Request, got ${req}`);
|
||||
}
|
||||
let connection = new MockConnection(req);
|
||||
this.connections.next(connection);
|
||||
|
Reference in New Issue
Block a user