chore(typings): remove StringMap

This was a poorly typed attempt to mimic TypeScript's index signatures,
which we can use instead.
This eliminates a very strange type that we were exposing to users, but
not re-exporting through our public API.

Fixes #4483

modules/angular2/src/web_workers/shared/client_message_broker.ts

@@ -41,7 +41,7 @@ export class ClientMessageBroker {
     this._sink = messageBus.to(channel);
     var source = messageBus.from(channel);
     ObservableWrapper.subscribe(source,
-                                (message: StringMap<string, any>) => this._handleMessage(message));
+                                (message: {[key: string]: any}) => this._handleMessage(message));
   }
 
   private _generateMessageId(name: string): string {
@@ -99,7 +99,7 @@ export class ClientMessageBroker {
     return promise;
   }
 
-  private _handleMessage(message: StringMap<string, any>): void {
+  private _handleMessage(message: {[key: string]: any}): void {
     var data = new MessageData(message);
     // TODO(jteplitz602): replace these strings with messaging constants #3685
     if (StringWrapper.equals(data.type, "result") || StringWrapper.equals(data.type, "error")) {
@@ -121,7 +121,7 @@ class MessageData {
   value: any;
   id: string;
 
-  constructor(data: StringMap<string, any>) {
+  constructor(data: {[key: string]: any}) {
     this.type = StringMapWrapper.get(data, "type");
     this.id = this._getValueIfPresent(data, "id");
     this.value = this._getValueIfPresent(data, "value");
@@ -130,7 +130,7 @@ class MessageData {
   /**
    * Returns the value from the StringMap if present. Otherwise returns null
    */
-  _getValueIfPresent(data: StringMap<string, any>, key: string) {
+  _getValueIfPresent(data: {[key: string]: any}, key: string) {
     if (StringMapWrapper.contains(data, key)) {
       return StringMapWrapper.get(data, key);
     } else {

modules/angular2/src/web_workers/shared/post_message_bus.ts

@@ -5,7 +5,7 @@ import {
 } from "angular2/src/web_workers/shared/message_bus";
 import {BaseException, WrappedException} from 'angular2/src/core/facade/exceptions';
 import {EventEmitter} from 'angular2/src/core/facade/async';
-import {StringMap, StringMapWrapper} from 'angular2/src/core/facade/collection';
+import {StringMapWrapper} from 'angular2/src/core/facade/collection';
 import {Injectable} from "angular2/src/core/di";
 import {NgZone} from 'angular2/src/core/zone/ng_zone';
 
@@ -34,7 +34,7 @@ export class PostMessageBus implements MessageBus {
 
 export class PostMessageBusSink implements MessageBusSink {
   private _zone: NgZone;
-  private _channels: StringMap<string, _Channel> = StringMapWrapper.create();
+  private _channels: {[key: string]: _Channel} = StringMapWrapper.create();
   private _messageBuffer: Array<Object> = [];
 
   constructor(private _postMessageTarget: PostMessageTarget) {}
@@ -83,7 +83,7 @@ export class PostMessageBusSink implements MessageBusSink {
 
 export class PostMessageBusSource implements MessageBusSource {
   private _zone: NgZone;
-  private _channels: StringMap<string, _Channel> = StringMapWrapper.create();
+  private _channels: {[key: string]: _Channel} = StringMapWrapper.create();
 
   constructor(eventTarget?: EventTarget) {
     if (eventTarget) {

modules/angular2/src/web_workers/shared/render_view_with_fragments_store.ts

@@ -112,7 +112,7 @@ export class RenderViewWithFragmentsStore {
     }
   }
 
-  serializeViewWithFragments(view: RenderViewWithFragments): StringMap<string, any> {
+  serializeViewWithFragments(view: RenderViewWithFragments): {[key: string]: any} {
     if (view == null) {
       return null;
     }
@@ -130,7 +130,7 @@ export class RenderViewWithFragmentsStore {
     }
   }
 
-  deserializeViewWithFragments(obj: StringMap<string, any>): RenderViewWithFragments {
+  deserializeViewWithFragments(obj: {[key: string]: any}): RenderViewWithFragments {
     if (obj == null) {
       return null;
     }

modules/angular2/src/web_workers/shared/serializer.ts

@@ -7,13 +7,7 @@ import {
 } from "angular2/src/core/facade/lang";
 import {BaseException, WrappedException} from 'angular2/src/core/facade/exceptions';
 
-import {
-  ListWrapper,
-  Map,
-  StringMap,
-  StringMapWrapper,
-  MapWrapper
-} from "angular2/src/core/facade/collection";
+import {ListWrapper, Map, StringMapWrapper, MapWrapper} from "angular2/src/core/facade/collection";
 import {
   RenderProtoViewRef,
   RenderViewRef,
@@ -144,7 +138,7 @@ export class Serializer {
    * If the values need to be deserialized pass in their type
    * and they will be deserialized before being placed in the map
    */
-  objectToMap(obj: StringMap<string, any>, type?: Type, data?: any): Map<string, any> {
+  objectToMap(obj: {[key: string]: any}, type?: Type, data?: any): Map<string, any> {
     if (isPresent(type)) {
       var map = new Map<string, any>();
       StringMapWrapper.forEach(obj,
@@ -157,14 +151,14 @@ export class Serializer {
 
   allocateRenderViews(fragmentCount: number) { this._renderViewStore.allocate(fragmentCount); }
 
-  private _serializeWorkerElementRef(elementRef: RenderElementRef): StringMap<string, any> {
+  private _serializeWorkerElementRef(elementRef: RenderElementRef): {[key: string]: any} {
     return {
       'renderView': this.serialize(elementRef.renderView, RenderViewRef),
       'boundElementIndex': elementRef.boundElementIndex
     };
   }
 
-  private _deserializeWorkerElementRef(map: StringMap<string, any>): RenderElementRef {
+  private _deserializeWorkerElementRef(map: {[key: string]: any}): RenderElementRef {
     return new WebWorkerElementRef(this.deserialize(map['renderView'], RenderViewRef),
                                    map['boundElementIndex']);
   }
@@ -174,7 +168,7 @@ function serializeTemplateCmd(cmd: RenderTemplateCmd): Object {
   return cmd.visit(RENDER_TEMPLATE_CMD_SERIALIZER, null);
 }
 
-function deserializeTemplateCmd(data: StringMap<string, any>): RenderTemplateCmd {
+function deserializeTemplateCmd(data: {[key: string]: any}): RenderTemplateCmd {
   return RENDER_TEMPLATE_CMD_DESERIALIZERS[data['deserializerIndex']](data);
 }
 
@@ -232,18 +226,18 @@ class RenderTemplateCmdSerializer implements RenderCommandVisitor {
 var RENDER_TEMPLATE_CMD_SERIALIZER = new RenderTemplateCmdSerializer();
 
 var RENDER_TEMPLATE_CMD_DESERIALIZERS = [
-  (data: StringMap<string, any>) =>
+  (data: {[key: string]: any}) =>
       new WebWorkerTextCmd(data['isBound'], data['ngContentIndex'], data['value']),
-  (data: StringMap<string, any>) => new WebWorkerNgContentCmd(data['ngContentIndex']),
-  (data: StringMap<string, any>) =>
+  (data: {[key: string]: any}) => new WebWorkerNgContentCmd(data['ngContentIndex']),
+  (data: {[key: string]: any}) =>
       new WebWorkerBeginElementCmd(data['isBound'], data['ngContentIndex'], data['name'],
                                    data['attrNameAndValues'], data['eventTargetAndNames']),
-  (data: StringMap<string, any>) => new WebWorkerEndElementCmd(),
-  (data: StringMap<string, any>) => new WebWorkerBeginComponentCmd(
+  (data: {[key: string]: any}) => new WebWorkerEndElementCmd(),
+  (data: {[key: string]: any}) => new WebWorkerBeginComponentCmd(
       data['isBound'], data['ngContentIndex'], data['name'], data['attrNameAndValues'],
       data['eventTargetAndNames'], data['nativeShadow'], data['templateId']),
-  (data: StringMap<string, any>) => new WebWorkerEndComponentCmd(),
-  (data: StringMap<string, any>) => new WebWorkerEmbeddedTemplateCmd(
+  (data: {[key: string]: any}) => new WebWorkerEndComponentCmd(),
+  (data: {[key: string]: any}) => new WebWorkerEmbeddedTemplateCmd(
       data['isBound'], data['ngContentIndex'], data['name'], data['attrNameAndValues'],
       data['eventTargetAndNames'], data['isMerged'],
       (<any[]>data['children']).map(childData => deserializeTemplateCmd(childData))),

modules/angular2/src/web_workers/shared/service_message_broker.ts

@@ -61,7 +61,7 @@ export class ServiceMessageBroker {
     });
   }
 
-  private _handleMessage(map: StringMap<string, any>): void {
+  private _handleMessage(map: {[key: string]: any}): void {
     var message = new ReceivedMessage(map);
     if (this._methods.has(message.method)) {
       this._methods.get(message.method)(message);
@@ -83,7 +83,7 @@ export class ReceivedMessage {
   id: string;
   type: string;
 
-  constructor(data: StringMap<string, any>) {
+  constructor(data: {[key: string]: any}) {
     this.method = data['method'];
     this.args = data['args'];
     this.id = data['id'];

modules/angular2/src/web_workers/ui/event_serializer.ts

@@ -1,4 +1,4 @@
-import {StringMap, Set} from 'angular2/src/core/facade/collection';
+import {Set} from 'angular2/src/core/facade/collection';
 import {isPresent} from 'angular2/src/core/facade/lang';
 
 const MOUSE_EVENT_PROPERTIES = [
@@ -37,28 +37,28 @@ const EVENT_PROPERTIES = ['type', 'bubbles', 'cancelable'];
 const NODES_WITH_VALUE =
     new Set(["input", "select", "option", "button", "li", "meter", "progress", "param"]);
 
-export function serializeGenericEvent(e: Event): StringMap<string, any> {
+export function serializeGenericEvent(e: Event): {[key: string]: any} {
   return serializeEvent(e, EVENT_PROPERTIES);
 }
 
 // TODO(jteplitz602): Allow users to specify the properties they need rather than always
 // adding value and files #3374
-export function serializeEventWithTarget(e: Event): StringMap<string, any> {
+export function serializeEventWithTarget(e: Event): {[key: string]: any} {
   var serializedEvent = serializeEvent(e, EVENT_PROPERTIES);
   return addTarget(e, serializedEvent);
 }
 
-export function serializeMouseEvent(e: MouseEvent): StringMap<string, any> {
+export function serializeMouseEvent(e: MouseEvent): {[key: string]: any} {
   return serializeEvent(e, MOUSE_EVENT_PROPERTIES);
 }
 
-export function serializeKeyboardEvent(e: KeyboardEvent): StringMap<string, any> {
+export function serializeKeyboardEvent(e: KeyboardEvent): {[key: string]: any} {
   var serializedEvent = serializeEvent(e, KEYBOARD_EVENT_PROPERTIES);
   return addTarget(e, serializedEvent);
 }
 
 // TODO(jteplitz602): #3374. See above.
-function addTarget(e: Event, serializedEvent: StringMap<string, any>): StringMap<string, any> {
+function addTarget(e: Event, serializedEvent: {[key: string]: any}): {[key: string]: any} {
   if (NODES_WITH_VALUE.has((<HTMLElement>e.target).tagName.toLowerCase())) {
     var target = <HTMLInputElement>e.target;
     serializedEvent['target'] = {'value': target.value};
@@ -69,7 +69,7 @@ function addTarget(e: Event, serializedEvent: StringMap<string, any>): StringMap
   return serializedEvent;
 }
 
-function serializeEvent(e: any, properties: string[]): StringMap<string, any> {
+function serializeEvent(e: any, properties: string[]): {[key: string]: any} {
   var serialized = {};
   for (var i = 0; i < properties.length; i++) {
     var prop = properties[i];

modules/angular2/src/web_workers/worker/application_common.ts

@@ -84,7 +84,7 @@ class PrintLogger {
   logGroupEnd() {}
 }
 
-function webWorkerBindings(appComponentType, bus: MessageBus, initData: StringMap<string, any>):
+function webWorkerBindings(appComponentType, bus: MessageBus, initData: {[key: string]: any}):
     Array<Type | Binding | any[]> {
   return [
     compilerBindings(),
@@ -118,7 +118,7 @@ export function bootstrapWebWorkerCommon(appComponentType: Type, bus: MessageBus
 
     var subscription: any;
     var emitter = bus.from(SETUP_CHANNEL);
-    subscription = ObservableWrapper.subscribe(emitter, (message: StringMap<string, any>) => {
+    subscription = ObservableWrapper.subscribe(emitter, (message: {[key: string]: any}) => {
       var bindings =
           [applicationCommonBindings(), webWorkerBindings(appComponentType, bus, message)];
       if (isPresent(appBindings)) {

modules/angular2/src/web_workers/worker/event_deserializer.ts

@@ -1,8 +1,6 @@
-import {StringMap} from "angular2/src/core/facade/collection";
-
 // no deserialization is necessary in TS.
 // This is only here to match dart interface
-export function deserializeGenericEvent(serializedEvent: StringMap<string, any>):
-    StringMap<string, any> {
+export function deserializeGenericEvent(serializedEvent: {[key: string]: any}):
+    {[key: string]: any} {
   return serializedEvent;
 }

modules/angular2/src/web_workers/worker/event_dispatcher.ts

@@ -38,7 +38,7 @@ class RenderEventData {
   eventName: string;
   locals: Map<string, any>;
 
-  constructor(message: StringMap<string, any>, serializer: Serializer) {
+  constructor(message: {[key: string]: any}, serializer: Serializer) {
     this.viewRef = serializer.deserialize(message['viewRef'], RenderViewRef);
     this.elementIndex = message['elementIndex'];
     this.eventName = message['eventName'];