From 7d2a746090b720aea01d6b437d578ed84efb897e Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Thu, 1 Nov 2018 21:23:06 -0700 Subject: [PATCH] build: remove ivy JIT mode (#26863) PR Close #26863 --- .circleci/config.yml | 17 -------------- package.json | 4 +--- packages/bazel/test/ng_package/BUILD.bazel | 1 - packages/common/http/test/BUILD.bazel | 2 -- packages/common/test/BUILD.bazel | 2 -- .../bazel/injectable_def/app/BUILD.bazel | 1 - .../bazel/injectable_def/app/test/BUILD.bazel | 2 -- .../ivy_build/app/test/BUILD.bazel | 1 - .../bazel/ng_module/BUILD.bazel | 2 -- packages/compiler-cli/test/BUILD.bazel | 3 --- .../compiler-cli/test/diagnostics/BUILD.bazel | 2 -- .../test/transformers/BUILD.bazel | 1 - packages/compiler/test/BUILD.bazel | 2 -- packages/core/test/BUILD.bazel | 2 -- .../test/bundling/animation_world/BUILD.bazel | 4 ---- .../test/bundling/hello_world/BUILD.bazel | 6 ----- .../test/bundling/hello_world_r2/BUILD.bazel | 2 -- .../core/test/bundling/injection/BUILD.bazel | 5 ----- packages/core/test/bundling/todo/BUILD.bazel | 8 ------- .../core/test/bundling/todo_r2/BUILD.bazel | 8 ------- packages/core/test/render3/BUILD.bazel | 2 -- packages/elements/test/BUILD.bazel | 1 - packages/forms/test/BUILD.bazel | 2 -- packages/language-service/test/BUILD.bazel | 1 - .../platform-browser-dynamic/test/BUILD.bazel | 1 - .../animations/test/BUILD.bazel | 2 -- packages/platform-browser/test/BUILD.bazel | 2 -- packages/platform-server/test/BUILD.bazel | 1 - packages/platform-webworker/test/BUILD.bazel | 1 - packages/private/testing/BUILD.bazel | 2 +- .../testing/src/bazel_define_compile_value.ts | 12 ++++++++++ packages/private/testing/src/fixme.ts | 22 +++++++++++++++++++ packages/router/test/BUILD.bazel | 2 -- .../test/aot_ngsummary_test/BUILD.bazel | 2 -- packages/router/upgrade/test/BUILD.bazel | 1 - packages/upgrade/test/BUILD.bazel | 1 - 36 files changed, 36 insertions(+), 94 deletions(-) create mode 100644 packages/private/testing/src/bazel_define_compile_value.ts create mode 100644 packages/private/testing/src/fixme.ts diff --git a/.circleci/config.yml b/.circleci/config.yml index b008e505d7..d6dda6674c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -116,21 +116,6 @@ jobs: - "~/bazel_repository_cache" # Temporary job to test what will happen when we flip the Ivy flag to true - test_ivy_jit: - <<: *job_defaults - resource_class: xlarge - steps: - - checkout: - <<: *post_checkout - - restore_cache: - key: *cache_key - - *define_env_vars - - *setup_circleci_bazel_config - - *yarn_install - - *setup_bazel_remote_execution - - - run: yarn test-ivy-jit //... - test_ivy_aot: <<: *job_defaults resource_class: xlarge @@ -416,7 +401,6 @@ workflows: jobs: - lint - test - - test_ivy_jit - test_ivy_aot - build-packages-dist - test_aio @@ -454,7 +438,6 @@ workflows: requires: # Only publish if tests and integration tests pass - test - - test_ivy_jit - test_ivy_aot - integration_test # Only publish if `aio`/`docs` tests using the locally built Angular packages pass diff --git a/package.json b/package.json index bd5ea108e9..b08d1f1ca6 100644 --- a/package.json +++ b/package.json @@ -26,8 +26,6 @@ "update-webdriver": "webdriver-manager update --gecko false $CHROMEDRIVER_VERSION_ARG", "check-env": "gulp check-env", "commitmsg": "node ./scripts/git/commit-msg.js", - "test-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=-no-ivy-jit,-fixme-ivy-jit --test_tag_filters=-no-ivy-jit,-fixme-ivy-jit", - "test-fixme-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=-no-ivy-jit --test_tag_filters=-no-ivy-jit", "test-ivy-aot": "bazel test --define=compile=aot --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot", "test-fixme-ivy-aot": "bazel test --define=compile=aot --build_tag_filters=-no-ivy-aot --test_tag_filters=-no-ivy-aot", "bazel": "bazel" @@ -144,4 +142,4 @@ "vrsource-tslint-rules": "5.1.1", "webpack": "1.12.9" } -} +} \ No newline at end of file diff --git a/packages/bazel/test/ng_package/BUILD.bazel b/packages/bazel/test/ng_package/BUILD.bazel index be2f8b8656..6389c87dbe 100644 --- a/packages/bazel/test/ng_package/BUILD.bazel +++ b/packages/bazel/test/ng_package/BUILD.bazel @@ -26,7 +26,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], ) diff --git a/packages/common/http/test/BUILD.bazel b/packages/common/http/test/BUILD.bazel index db127690d0..22f7ae65b3 100644 --- a/packages/common/http/test/BUILD.bazel +++ b/packages/common/http/test/BUILD.bazel @@ -21,7 +21,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -33,7 +32,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/common/test/BUILD.bazel b/packages/common/test/BUILD.bazel index d64d804481..d550182039 100644 --- a/packages/common/test/BUILD.bazel +++ b/packages/common/test/BUILD.bazel @@ -23,7 +23,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -35,7 +34,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel index 08fe044030..3c54703cb4 100644 --- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel @@ -13,7 +13,6 @@ ng_module( module_name = "app_built", tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ "//packages/compiler-cli/integrationtest/bazel/injectable_def/lib2", diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel index 454e967581..e99b4d640e 100644 --- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel @@ -12,7 +12,6 @@ ts_library( ), tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ "//packages/compiler-cli/integrationtest/bazel/injectable_def/app", @@ -27,7 +26,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel index ab15e3bb4a..bf0dc25290 100644 --- a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel @@ -21,7 +21,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel index 97c8574c0e..7edc573095 100644 --- a/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel @@ -12,7 +12,6 @@ ng_module( node_modules = "@ngdeps//typescript:typescript__typings", tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ "//packages/core", @@ -36,6 +35,5 @@ jasmine_node_test( data = [":flat_module_index"], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], ) diff --git a/packages/compiler-cli/test/BUILD.bazel b/packages/compiler-cli/test/BUILD.bazel index 1cda15367d..86228d25ea 100644 --- a/packages/compiler-cli/test/BUILD.bazel +++ b/packages/compiler-cli/test/BUILD.bazel @@ -44,7 +44,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":extract_i18n_lib", @@ -82,7 +81,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":ngc_lib", @@ -117,7 +115,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":ngtools_api_lib", diff --git a/packages/compiler-cli/test/diagnostics/BUILD.bazel b/packages/compiler-cli/test/diagnostics/BUILD.bazel index ef2b77e662..e86f7244d4 100644 --- a/packages/compiler-cli/test/diagnostics/BUILD.bazel +++ b/packages/compiler-cli/test/diagnostics/BUILD.bazel @@ -39,7 +39,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":check_types_lib", @@ -73,7 +72,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":expression_diagnostics_lib", diff --git a/packages/compiler-cli/test/transformers/BUILD.bazel b/packages/compiler-cli/test/transformers/BUILD.bazel index 2cdcc52f97..6b1ef1a999 100644 --- a/packages/compiler-cli/test/transformers/BUILD.bazel +++ b/packages/compiler-cli/test/transformers/BUILD.bazel @@ -27,7 +27,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/compiler/test/BUILD.bazel b/packages/compiler/test/BUILD.bazel index 9e3e412cad..0a1179f0e6 100644 --- a/packages/compiler/test/BUILD.bazel +++ b/packages/compiler/test/BUILD.bazel @@ -76,7 +76,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -92,7 +91,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel index 226cd94993..fff694ef4c 100644 --- a/packages/core/test/BUILD.bazel +++ b/packages/core/test/BUILD.bazel @@ -53,7 +53,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -71,7 +70,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/core/test/bundling/animation_world/BUILD.bazel b/packages/core/test/bundling/animation_world/BUILD.bazel index f483015cb0..8cb51841a1 100644 --- a/packages/core/test/bundling/animation_world/BUILD.bazel +++ b/packages/core/test/bundling/animation_world/BUILD.bazel @@ -9,7 +9,6 @@ ng_module( srcs = ["index.ts"], tags = [ "ivy-only", - "no-ivy-jit", ], type_check = False, # see #26462 deps = [ @@ -30,7 +29,6 @@ ng_rollup_bundle( entry_point = "packages/core/test/bundling/animation_world/index.js", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":animation_world", @@ -45,7 +43,6 @@ js_expected_symbol_test( tags = [ "ivy-aot", "ivy-only", - "no-ivy-jit", ], ) @@ -60,6 +57,5 @@ http_server( ], tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/bundling/hello_world/BUILD.bazel b/packages/core/test/bundling/hello_world/BUILD.bazel index 52f9b24e75..5e8056af83 100644 --- a/packages/core/test/bundling/hello_world/BUILD.bazel +++ b/packages/core/test/bundling/hello_world/BUILD.bazel @@ -9,7 +9,6 @@ ng_module( srcs = ["index.ts"], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages/core", @@ -27,7 +26,6 @@ ng_rollup_bundle( entry_point = "packages/core/test/bundling/hello_world/index.js", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":hello_world", @@ -41,7 +39,6 @@ ts_library( srcs = glob(["*_spec.ts"]), tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages:types", @@ -61,7 +58,6 @@ jasmine_node_test( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":test_lib"], ) @@ -73,7 +69,6 @@ js_expected_symbol_test( tags = [ "ivy-aot", "ivy-only", - "no-ivy-jit", ], ) @@ -86,6 +81,5 @@ http_server( ], tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/bundling/hello_world_r2/BUILD.bazel b/packages/core/test/bundling/hello_world_r2/BUILD.bazel index 72a5c2a69b..54bb5125b8 100644 --- a/packages/core/test/bundling/hello_world_r2/BUILD.bazel +++ b/packages/core/test/bundling/hello_world_r2/BUILD.bazel @@ -70,7 +70,6 @@ js_expected_symbol_test( golden = ":bundle.golden_symbols.json", tags = [ "ivy-only", - "no-ivy-jit", ], ) @@ -83,6 +82,5 @@ http_server( ], tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/bundling/injection/BUILD.bazel b/packages/core/test/bundling/injection/BUILD.bazel index 005ed32931..5147014a94 100644 --- a/packages/core/test/bundling/injection/BUILD.bazel +++ b/packages/core/test/bundling/injection/BUILD.bazel @@ -11,7 +11,6 @@ ts_library( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages/core", @@ -29,7 +28,6 @@ ng_rollup_bundle( entry_point = "packages/core/test/bundling/injection/index.js", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":injection", @@ -43,7 +41,6 @@ ts_library( srcs = glob(["*_spec.ts"]), tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":injection", @@ -58,7 +55,6 @@ jasmine_node_test( name = "test", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":test_lib"], ) @@ -69,6 +65,5 @@ js_expected_symbol_test( golden = ":bundle.golden_symbols.json", tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/bundling/todo/BUILD.bazel b/packages/core/test/bundling/todo/BUILD.bazel index 4a998a1590..3db6e3211c 100644 --- a/packages/core/test/bundling/todo/BUILD.bazel +++ b/packages/core/test/bundling/todo/BUILD.bazel @@ -10,7 +10,6 @@ ng_module( srcs = ["index.ts"], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages/common", @@ -30,7 +29,6 @@ ng_rollup_bundle( entry_point = "packages/core/test/bundling/todo/index.js", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":todo", @@ -46,7 +44,6 @@ ts_library( srcs = glob(["*_spec.ts"]), tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages:types", @@ -67,7 +64,6 @@ jasmine_node_test( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":test_lib"], ) @@ -79,7 +75,6 @@ js_expected_symbol_test( tags = [ "ivy-aot", "ivy-only", - "no-ivy-jit", ], ) @@ -94,7 +89,6 @@ genrule( cmd = "cp $< $@", tags = [ "ivy-only", - "no-ivy-jit", ], ) @@ -110,7 +104,6 @@ ts_devserver( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":todo"], ) @@ -126,6 +119,5 @@ http_server( ], tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/bundling/todo_r2/BUILD.bazel b/packages/core/test/bundling/todo_r2/BUILD.bazel index c54d6affb5..356d21fb1c 100644 --- a/packages/core/test/bundling/todo_r2/BUILD.bazel +++ b/packages/core/test/bundling/todo_r2/BUILD.bazel @@ -10,7 +10,6 @@ ng_module( srcs = ["index.ts"], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages/common", @@ -32,7 +31,6 @@ ng_rollup_bundle( entry_point = "packages/core/test/bundling/todo_r2/index.js", tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ ":todo", @@ -50,7 +48,6 @@ ts_library( srcs = glob(["*_spec.ts"]), tags = [ "ivy-only", - "no-ivy-jit", ], deps = [ "//packages:types", @@ -73,7 +70,6 @@ jasmine_node_test( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":test_lib"], ) @@ -85,7 +81,6 @@ js_expected_symbol_test( tags = [ "ivy-aot", "ivy-only", - "no-ivy-jit", ], ) @@ -100,7 +95,6 @@ genrule( cmd = "cp $< $@", tags = [ "ivy-only", - "no-ivy-jit", ], ) @@ -116,7 +110,6 @@ ts_devserver( ], tags = [ "ivy-only", - "no-ivy-jit", ], deps = [":todo"], ) @@ -132,6 +125,5 @@ http_server( ], tags = [ "ivy-only", - "no-ivy-jit", ], ) diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel index faa0e0698e..768c141f1e 100644 --- a/packages/core/test/render3/BUILD.bazel +++ b/packages/core/test/render3/BUILD.bazel @@ -61,7 +61,6 @@ jasmine_node_test( "angular/packages/core/test/render3/load_domino", ], tags = [ - "fixme-ivy-jit", ], deps = [ ":render3_node_lib", @@ -72,7 +71,6 @@ jasmine_node_test( ts_web_test_suite( name = "render3_web", tags = [ - "fixme-ivy-jit", ], deps = [ ":render3_lib", diff --git a/packages/elements/test/BUILD.bazel b/packages/elements/test/BUILD.bazel index 9729eb719d..eca837a09e 100644 --- a/packages/elements/test/BUILD.bazel +++ b/packages/elements/test/BUILD.bazel @@ -37,7 +37,6 @@ ts_web_test_suite( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], # do not sort deps = [ diff --git a/packages/forms/test/BUILD.bazel b/packages/forms/test/BUILD.bazel index 5641e76aab..5f8e90e682 100644 --- a/packages/forms/test/BUILD.bazel +++ b/packages/forms/test/BUILD.bazel @@ -20,7 +20,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -32,7 +31,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/language-service/test/BUILD.bazel b/packages/language-service/test/BUILD.bazel index 5ecc4ab650..7fbf945576 100644 --- a/packages/language-service/test/BUILD.bazel +++ b/packages/language-service/test/BUILD.bazel @@ -24,7 +24,6 @@ jasmine_node_test( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/platform-browser-dynamic/test/BUILD.bazel b/packages/platform-browser-dynamic/test/BUILD.bazel index c6a1492d8e..98833263ad 100644 --- a/packages/platform-browser-dynamic/test/BUILD.bazel +++ b/packages/platform-browser-dynamic/test/BUILD.bazel @@ -33,7 +33,6 @@ ts_web_test_suite( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/platform-browser/animations/test/BUILD.bazel b/packages/platform-browser/animations/test/BUILD.bazel index f941963b31..bfdf080eb2 100644 --- a/packages/platform-browser/animations/test/BUILD.bazel +++ b/packages/platform-browser/animations/test/BUILD.bazel @@ -26,7 +26,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -38,7 +37,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/platform-browser/test/BUILD.bazel b/packages/platform-browser/test/BUILD.bazel index 157d922010..dab9cc3e74 100644 --- a/packages/platform-browser/test/BUILD.bazel +++ b/packages/platform-browser/test/BUILD.bazel @@ -31,7 +31,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -46,7 +45,6 @@ ts_web_test_suite( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/platform-server/test/BUILD.bazel b/packages/platform-server/test/BUILD.bazel index 17aeeca2ef..b5ef13e2f9 100644 --- a/packages/platform-server/test/BUILD.bazel +++ b/packages/platform-server/test/BUILD.bazel @@ -27,7 +27,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/platform-webworker/test/BUILD.bazel b/packages/platform-webworker/test/BUILD.bazel index a0b79e6edd..826bf30e21 100644 --- a/packages/platform-webworker/test/BUILD.bazel +++ b/packages/platform-webworker/test/BUILD.bazel @@ -31,7 +31,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/private/testing/BUILD.bazel b/packages/private/testing/BUILD.bazel index 5485807146..6b1d9e601a 100644 --- a/packages/private/testing/BUILD.bazel +++ b/packages/private/testing/BUILD.bazel @@ -18,7 +18,7 @@ ng_module( ## Controls if Ivy is enabled. (Temporary target until we permanently switch over to Ivy) ## -## This file generates `src/bazel_define_compile_value.ts` file which reexports +## This file generates `src/bazel_define_compile_value.ts` file which reexports ## `--define=compile` value as `bazelDefineCompileValue` symbols so that runtime can detect ## which mode it is running in. ## diff --git a/packages/private/testing/src/bazel_define_compile_value.ts b/packages/private/testing/src/bazel_define_compile_value.ts new file mode 100644 index 0000000000..714f4a437f --- /dev/null +++ b/packages/private/testing/src/bazel_define_compile_value.ts @@ -0,0 +1,12 @@ +/** + * @license + * Copyright Google Inc. All Rights Reserved. + * + * Use of this source code is governed by an MIT-style license that can be + * found in the LICENSE file at https://angular.io/license + */ + +/** + * This variable shows the `blaze --define=compile=` value to make it available to runtime. + */ +export const bazelDefineCompileValue = 'legacy'; diff --git a/packages/private/testing/src/fixme.ts b/packages/private/testing/src/fixme.ts new file mode 100644 index 0000000000..222c648877 --- /dev/null +++ b/packages/private/testing/src/fixme.ts @@ -0,0 +1,22 @@ +/** + * @license + * Copyright Google Inc. All Rights Reserved. + * + * Use of this source code is governed by an MIT-style license that can be + * found in the LICENSE file at https://angular.io/license + */ + +import {bazelDefineCompileValue} from './bazel_define_compile_value'; + +/** + * A global method which is used to conditionally block the execution of tests. + * + * ``` + * fixmeIvy('some reason') && describe(...); + * ``` + * + * The above will prevent the execution of the test(s) in Ivy mode, until they can be fixed. + */ +export function fixmeIvy(reason: string): boolean { + return 'aot' !== (bazelDefineCompileValue as string); +} \ No newline at end of file diff --git a/packages/router/test/BUILD.bazel b/packages/router/test/BUILD.bazel index 76097926d2..6c9925f584 100644 --- a/packages/router/test/BUILD.bazel +++ b/packages/router/test/BUILD.bazel @@ -25,7 +25,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", @@ -37,7 +36,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/router/test/aot_ngsummary_test/BUILD.bazel b/packages/router/test/aot_ngsummary_test/BUILD.bazel index fdb8c36bff..b643f1941d 100644 --- a/packages/router/test/aot_ngsummary_test/BUILD.bazel +++ b/packages/router/test/aot_ngsummary_test/BUILD.bazel @@ -18,7 +18,6 @@ ts_library( srcs = ["aot_router_bootstrap.spec.ts"], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":aot_routing_module", @@ -34,7 +33,6 @@ jasmine_node_test( bootstrap = ["angular/tools/testing/init_node_spec.js"], tags = [ "fixme-ivy-aot", - "no-ivy-jit", ], deps = [ ":aot_test_lib", diff --git a/packages/router/upgrade/test/BUILD.bazel b/packages/router/upgrade/test/BUILD.bazel index 4aa704b21e..03af99a524 100644 --- a/packages/router/upgrade/test/BUILD.bazel +++ b/packages/router/upgrade/test/BUILD.bazel @@ -17,7 +17,6 @@ ts_web_test_suite( name = "test_web", tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib", diff --git a/packages/upgrade/test/BUILD.bazel b/packages/upgrade/test/BUILD.bazel index 4dfa7186d0..5d57f63e55 100644 --- a/packages/upgrade/test/BUILD.bazel +++ b/packages/upgrade/test/BUILD.bazel @@ -24,7 +24,6 @@ ts_web_test_suite( ], tags = [ "fixme-ivy-aot", - "fixme-ivy-jit", ], deps = [ ":test_lib",