cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "feat(ivy): add namespace instructions for SVG and others (#23899)"

Browse Source 
This reverts commit 81e4b2a4bf.
This commit is contained in:
Victor Berchet
2018-06-06 13:38:21 -07:00
parent 07b4c8be42
commit 7de2ba0e22
6 changed files with 22 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
packages/core/src/render3/instructions.ts
View File

@ -8,27 +8,24 @@
import './ng_dev_mode';
import {Sanitizer} from '../sanitization/security';
import {assertEqual, assertLessThan, assertNotEqual, assertNotNull, assertNull, assertSame} from './assert';
import {throwCyclicDependencyError, throwErrorIfNoChangesMode, throwMultipleComponentError} from './errors';
import {executeHooks, executeInitHooks, queueInitHooks, queueLifecycleHooks} from './hooks';
import {LContainer} from './interfaces/container';
import {ComponentDef, ComponentTemplate, DirectiveDef, DirectiveDefList, DirectiveDefListOrFactory, PipeDefList, PipeDefListOrFactory, RenderFlags} from './interfaces/definition';
import {LInjector} from './interfaces/injector';
import {CssSelectorList, LProjection, NG_PROJECT_AS_ATTR_NAME} from './interfaces/projection';
import {LQueries} from './interfaces/query';
import {ObjectOrientedRenderer3, ProceduralRenderer3, RElement, RText, Renderer3, RendererFactory3, RendererStyleFlags3, isProceduralRenderer} from './interfaces/renderer';
import {CurrentMatchesList, LView, LViewFlags, RootContext, TData, TView} from './interfaces/view';
import {AttributeMarker, TAttributes, LContainerNode, LElementNode, LNode, TNodeType, TNodeFlags, LProjectionNode, LTextNode, LViewNode, TNode, TContainerNode, InitialInputData, InitialInputs, PropertyAliases, PropertyAliasValue, TElementNode,} from './interfaces/node';
import {assertNodeType} from './node_assert';
import {appendChild, insertView, appendProjectedNode, removeView, canInsertNativeNode, createTextNode, getNextLNode, getChildLNode, getParentLNode, getLViewChild} from './node_manipulation';
import {isNodeMatchingSelectorList, matchingSelectorIndex} from './node_selector_matcher';
import {ComponentDef, ComponentTemplate, DirectiveDef, DirectiveDefList, DirectiveDefListOrFactory, PipeDefList, PipeDefListOrFactory, RenderFlags} from './interfaces/definition';
import {RElement, RText, Renderer3, RendererFactory3, ProceduralRenderer3, RendererStyleFlags3, isProceduralRenderer} from './interfaces/renderer';
import {isDifferent, stringify} from './util';
import {executeHooks, queueLifecycleHooks, queueInitHooks, executeInitHooks} from './hooks';
import {ViewRef} from './view_ref';
import {throwCyclicDependencyError, throwErrorIfNoChangesMode, throwMultipleComponentError} from './errors';
import {Sanitizer} from '../sanitization/security';
/**
* Directive (D) sets a property on all component instances using this constant as a key and the
@ -553,28 +550,6 @@ function getRenderFlags(view: LView): RenderFlags {
RenderFlags.Update;
}
//////////////////////////
//// Namespace
//////////////////////////
let _currentNS: string|null = null;
export function setNS(namespace: string) {
_currentNS = namespace;
}
export function setHtmlNS() {
_currentNS = null;
}
export function setSvgNS() {
_currentNS = 'http://www.w3.org/2000/svg';
}
export function setMathML() {
_currentNS = 'http://www.w3.org/1998/Math/MathML';
}
//////////////////////////
//// Element
//////////////////////////
@ -598,11 +573,7 @@ export function elementStart(
assertEqual(currentView.bindingIndex, -1, 'elements should be created before any bindings');
ngDevMode && ngDevMode.rendererCreateElement++;
const native: RElement = _currentNS === null || isProceduralRenderer(renderer) ?
renderer.createElement(name) :
(renderer as ObjectOrientedRenderer3).createElementNS(_currentNS, name);
const native: RElement = renderer.createElement(name);
ngDevMode && assertDataInRange(index - 1);
const node: LElementNode =

1
packages/core/src/render3/interfaces/renderer.ts
View File

@ -36,7 +36,6 @@ export type Renderer3 = ObjectOrientedRenderer3 | ProceduralRenderer3;
* */
export interface ObjectOrientedRenderer3 {
createElement(tagName: string): RElement;
createElementNS(namespace: string, name: string): RElement;
createTextNode(data: string): RText;
querySelector(selectors: string): RElement|null;