cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(language-service): remove ng-for-cases.ts (#36470)

Browse Source 
This commit removes ng-for-cases.ts and moves all test cases to
inline expressions in TEST_TEMPLATE.

PR Close #36470
This commit is contained in:
Keen Yee Liau
2020-04-06 20:04:56 -07:00
committed by Kara Erickson
parent 1dd0b6cc18
commit 7f28845f58
3 changed files with 15 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/language-service/test/diagnostics_spec.ts
View File

@ -274,22 +274,22 @@ describe('diagnostics', () => {
expect(diags).toContain('Expected a number type');
});
describe('in ng-for-cases.ts', () => {
it('should report an unknown field', () => {
const diags = ngLS.getSemanticDiagnostics(NG_FOR_CASES).map(d => d.messageText);
expect(diags).toContain(
`Identifier 'people_1' is not defined. ` +
`The component declaration, template variable declarations, ` +
`and element references do not contain such a member`);
});
it('should report an unknown field', () => {
mockHost.override(TEST_TEMPLATE, `<div *ngFor="let person of people"></div>`);
const diags = ngLS.getSemanticDiagnostics(TEST_TEMPLATE).map(d => d.messageText);
expect(diags).toContain(
`Identifier 'people' is not defined. ` +
`The component declaration, template variable declarations, ` +
`and element references do not contain such a member`);
});
it('should report an unknown value in a key expression', () => {
const diags = ngLS.getSemanticDiagnostics(NG_FOR_CASES).map(d => d.messageText);
expect(diags).toContain(
`Identifier 'trackBy_1' is not defined. ` +
`The component declaration, template variable declarations, ` +
`and element references do not contain such a member`);
});
it('should report an unknown value in a key expression', () => {
mockHost.override(TEST_TEMPLATE, `<div *ngFor="let hero of heroes; trackBy: trackByFn"></div>`);
const diags = ngLS.getSemanticDiagnostics(TEST_TEMPLATE).map(d => d.messageText);
expect(diags).toContain(
`Identifier 'trackByFn' is not defined. ` +
`The component declaration, template variable declarations, ` +
`and element references do not contain such a member`);
});
describe('embedded templates', () => {