From 7f93f7ef478e42f22df5824ef134c3a6f3cf882b Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Wed, 17 Jun 2020 05:34:41 -0700 Subject: [PATCH] build: move shims_for_IE to third_party directory (#37624) The shims_for_IE.js file contains vendor code that predates the third_party directory. This file is currently used for internal karma testing setup. This change corrects this by moving the shims_for_IE file to //third_part/ PR Close #37624 --- .ng-dev/config.ts | 2 -- BUILD.bazel | 2 +- karma-js.conf.js | 2 +- packages/router/karma.conf.js | 2 +- shims_for_IE.js => third_party/shims_for_IE.js | 0 5 files changed, 3 insertions(+), 5 deletions(-) rename shims_for_IE.js => third_party/shims_for_IE.js (100%) diff --git a/.ng-dev/config.ts b/.ng-dev/config.ts index fdb64d63ae..b7983d6fb2 100644 --- a/.ng-dev/config.ts +++ b/.ng-dev/config.ts @@ -56,8 +56,6 @@ const format = { // TODO: burn down format failures and remove aio and integration exceptions. '!aio/**', '!integration/**', - // TODO: remove this exclusion as part of IE deprecation. - '!shims_for_IE.js', // Both third_party and .yarn are directories containing copied code which should // not be modified. '!third_party/**', diff --git a/BUILD.bazel b/BUILD.bazel index 7a97832224..7b87905246 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -24,7 +24,7 @@ filegroup( "//packages/zone.js/dist:zone-testing.js", "//packages/zone.js/dist:task-tracking.js", "//:test-events.js", - "//:shims_for_IE.js", + "//:third_party/shims_for_IE.js", # Including systemjs because it defines `__eval`, which produces correct stack traces. "@npm//:node_modules/systemjs/dist/system.src.js", "@npm//:node_modules/reflect-metadata/Reflect.js", diff --git a/karma-js.conf.js b/karma-js.conf.js index 290f1f4205..f5972dfe25 100644 --- a/karma-js.conf.js +++ b/karma-js.conf.js @@ -42,7 +42,7 @@ module.exports = function(config) { // Including systemjs because it defines `__eval`, which produces correct stack traces. 'test-events.js', - 'shims_for_IE.js', + 'third_party/shims_for_IE.js', 'node_modules/systemjs/dist/system.src.js', // Serve polyfills necessary for testing the `elements` package. diff --git a/packages/router/karma.conf.js b/packages/router/karma.conf.js index 103d78e967..455bdeda64 100644 --- a/packages/router/karma.conf.js +++ b/packages/router/karma.conf.js @@ -28,7 +28,7 @@ module.exports = function(config) { // Polyfills. 'node_modules/core-js/client/core.js', 'node_modules/reflect-metadata/Reflect.js', - 'shims_for_IE.js', + 'third_party/shims_for_IE.js', // System.js for module loading 'node_modules/systemjs/dist/system-polyfills.js', diff --git a/shims_for_IE.js b/third_party/shims_for_IE.js similarity index 100% rename from shims_for_IE.js rename to third_party/shims_for_IE.js