cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(language-service): completions support for tuple array (#33928)

Browse Source 
PR Close #33928
This commit is contained in:
ivanwonder
2019-11-20 07:23:45 +00:00
committed by Miško Hevery
parent 7402430d06
commit 7faa9bbc09
6 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/language-service/test/completions_spec.ts
View File

@ -125,6 +125,13 @@ describe('completions', () => {
expectContain(completions, CompletionKind.PROPERTY, ['id', 'name']);
});
it('should work with numeric index signatures (tuple arrays)', () => {
mockHost.override(TEST_TEMPLATE, `{{ tupleArray[1].~{tuple-array-number-index}}}`);
const marker = mockHost.getLocationMarkerFor(TEST_TEMPLATE, 'tuple-array-number-index');
const completions = ngLS.getCompletionsAt(TEST_TEMPLATE, marker.start);
expectContain(completions, CompletionKind.PROPERTY, ['id', 'name']);
});
describe('with string index signatures', () => {
it('should work with index notation', () => {
mockHost.override(TEST_TEMPLATE, `{{ heroesByName['Jacky'].~{heroes-string-index}}}`);