cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): fix retrieving the binding name when an expression changes (#21814)

Browse Source 
fixes #21735
fixes #21788

PR Close #21814
This commit is contained in:
Victor Berchet
2018-01-26 14:36:11 -08:00
committed by Jason Aden
parent 7410941a7c
commit 81d64d6bec
3 changed files with 45 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/core/test/linker/change_detection_integration_spec.ts
View File

@ -1156,11 +1156,19 @@ const TEST_COMPILER_PROVIDERS: Provider[] = [
describe('enforce no new changes', () => {
it('should throw when a record gets changed after it has been checked', fakeAsync(() => {
const ctx = createCompFixture('<div [someProp]="a"></div>', TestData);
ctx.componentInstance.a = 1;
@Directive({selector: '[changed]'})
class ChangingDirective {
@Input() changed: any;
}
TestBed.configureTestingModule({declarations: [ChangingDirective]});
const ctx = createCompFixture('<div [someProp]="a" [changed]="b"></div>', TestData);
ctx.componentInstance.b = 1;
expect(() => ctx.checkNoChanges())
.toThrowError(/Expression has changed after it was checked./g);
.toThrowError(/Previous value: 'changed: undefined'\. Current value: 'changed: 1'/g);
}));
it('should warn when the view has been created in a cd hook', fakeAsync(() => {
@ -1968,7 +1976,8 @@ class Uninitialized {
@Component({selector: 'root', template: 'empty'})
class TestData {
public a: any;
a: any;
b: any;
}
@Component({selector: 'root', template: 'empty'})