cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(change detect): Remove unnecessary param from tests

Browse Source
This commit is contained in:
Tim Blasi 2015-06-05 14:19:49 -07:00
parent 29c72abcc4
commit 81fc657356
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/angular2/test/change_detection/change_detector_spec.ts
View File

@ -74,7 +74,7 @@ export function main() {
function _bindSimpleValue(expression: string, context = null) { function _bindSimpleValue(expression: string, context = null) {
var dispatcher = new TestDispatcher(); var dispatcher = new TestDispatcher();
var protoCd = _getProtoChangeDetector(getDefinition(expression, 'propName')); var protoCd = _getProtoChangeDetector(getDefinition(expression));
var cd = protoCd.instantiate(dispatcher); var cd = protoCd.instantiate(dispatcher);
var locals = null; var locals = null;

2
modules/angular2/test/change_detection/generator/gen_change_detectors.dart
View File

@ -10,7 +10,7 @@ import '../simple_watch_config.dart';
void main(List<String> args) { void main(List<String> args) {
var buf = new StringBuffer('var $_MAP_NAME = {'); var buf = new StringBuffer('var $_MAP_NAME = {');
var codegen = new Codegen(); var codegen = new Codegen();
var allDefs = getAllDefinitions('propName'); var allDefs = getAllDefinitions();
for (var i = 0; i < allDefs.length; ++i) { for (var i = 0; i < allDefs.length; ++i) {
var className = 'ChangeDetector${i}'; var className = 'ChangeDetector${i}';
codegen.generate('dynamic', className, allDefs[i]); codegen.generate('dynamic', className, allDefs[i]);

16
modules/angular2/test/change_detection/simple_watch_config.ts
View File

@ -5,11 +5,10 @@ import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabil
var _parser = new Parser(new Lexer()); var _parser = new Parser(new Lexer());
function _createChangeDetectorDefinition(id: string, propName: string, function _createChangeDetectorDefinition(id: string, expression: string): ChangeDetectorDefinition {
expression: string): ChangeDetectorDefinition {
reflector.reflectionCapabilities = new ReflectionCapabilities(); reflector.reflectionCapabilities = new ReflectionCapabilities();
var ast = _parser.parseBinding(expression, 'location'); var ast = _parser.parseBinding(expression, 'location');
var bindingRecords = [BindingRecord.createForElement(ast, 0, propName)]; var bindingRecords = [BindingRecord.createForElement(ast, 0, PROP_NAME)];
var strategy = null; var strategy = null;
var variableBindings = []; var variableBindings = [];
@ -18,23 +17,24 @@ function _createChangeDetectorDefinition(id: string, propName: string,
directiveRecords); directiveRecords);
} }
export var PROP_NAME = 'propName';
/** /**
* In this case, we expect `id` and `expression` to be the same string. * In this case, we expect `id` and `expression` to be the same string.
*/ */
export function getDefinition(id: string, propName: string): ChangeDetectorDefinition { export function getDefinition(id: string): ChangeDetectorDefinition {
// TODO(kegluneq): Remove `propName`?
if (ListWrapper.indexOf(_availableDefinitions, id) < 0) { if (ListWrapper.indexOf(_availableDefinitions, id) < 0) {
throw `No ChangeDetectorDefinition for ${id} available. Please modify this file if necessary.`; throw `No ChangeDetectorDefinition for ${id} available. Please modify this file if necessary.`;
} }
return _createChangeDetectorDefinition(id, propName, id); return _createChangeDetectorDefinition(id, id);
} }
/** /**
* Get all available ChangeDetectorDefinition objects. Used to pre-generate Dart * Get all available ChangeDetectorDefinition objects. Used to pre-generate Dart
* `ChangeDetector` classes. * `ChangeDetector` classes.
*/ */
export function getAllDefinitions(propName: string): List<ChangeDetectorDefinition> { export function getAllDefinitions(): List<ChangeDetectorDefinition> {
return ListWrapper.map(_availableDefinitions, (id) => getDefinition(id, propName)); return ListWrapper.map(_availableDefinitions, (id) => getDefinition(id));
} }
var _availableDefinitions = [ var _availableDefinitions = [