cargdev/angular
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(router): should throw when lazy loaded module doesn't define any routes (#15001)

Browse Source 
Closes #14596

PR Close #15001
This commit is contained in:
Dzmitry Shylovich
2017-03-08 11:36:09 +03:00
committed by Miško Hevery
parent 5152abb037
commit 82923a381d
2 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/router/src/router_config_loader.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Compiler, InjectionToken, Injector, NgModuleFactory, NgModuleFactoryLoader, NgModuleRef} from '@angular/core';
import {Compiler, InjectionToken, Injector, NgModuleFactory, NgModuleFactoryLoader, NgModuleRef, ɵstringify as stringify} from '@angular/core';
import {Observable} from 'rxjs/Observable';
import {fromPromise} from 'rxjs/observable/fromPromise';
import {of } from 'rxjs/observable/of';
@ -41,7 +41,16 @@ export class RouterConfigLoader {
const module = factory.create(parentInjector);
return new LoadedRouterConfig(flatten(module.injector.get(ROUTES)), module);
const parentRoutes = new Set(flatten(parentInjector.get(ROUTES)));
const moduleRoutes =
flatten(module.injector.get(ROUTES)).filter(route => !parentRoutes.has(route));
if (moduleRoutes.length === 0) {
throw new Error(
`A lazy loaded module must define at least 1 route, but it seems like the '${stringify(factory.moduleType)}' module hasn't defined any. Have you imported RouterModule.forChild(ROUTES) in this module?`);
}
return new LoadedRouterConfig(moduleRoutes, module);
});
}