From 848e53efd0eca1cd5a409dea6c65297769162e5e Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Thu, 16 May 2019 18:33:18 +0300 Subject: [PATCH] test(platform-browser-dynamic): avoid swallowing error in `CachedResourceLoader` test (#30515) Previously, in order to assert that the promise was not resolved, an error was thrown when the promise was resolved successfully. At the same, `.catch()` was used to silence the (expected) promise rejection. However, the chained `.catch()` handler would also catch (and swallow) the error thrown on resolving the promise, making the test pass, even if the promise was not rejected. This commit fixes it by ensuring that the error thrown on resolving the promise is not caught by the rejection handler. PR Close #30515 --- .../test/resource_loader/resource_loader_cache_spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/platform-browser-dynamic/test/resource_loader/resource_loader_cache_spec.ts b/packages/platform-browser-dynamic/test/resource_loader/resource_loader_cache_spec.ts index f5b42e1b6e..316152f7b9 100644 --- a/packages/platform-browser-dynamic/test/resource_loader/resource_loader_cache_spec.ts +++ b/packages/platform-browser-dynamic/test/resource_loader/resource_loader_cache_spec.ts @@ -36,9 +36,9 @@ if (isBrowser) { it('should reject the Promise on failure', async(() => { resourceLoader = createCachedResourceLoader(); - resourceLoader.get('unknown.html') - .then((text) => { throw new Error('Not expected to succeed.'); }) - .catch((error) => {/** success */}); + resourceLoader.get('unknown.html').then(() => { + throw new Error('Not expected to succeed.'); + }, () => {/* success */}); })); it('should allow fakeAsync Tests to load components with templateUrl synchronously',