cargdev/angular
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(forms): get rid of duplicate functions (#38371)

Browse Source 
This commit performs minor refactoring in Forms package to get rid of duplicate functions.
It looks like the functions were duplicated due to a slightly different type signatures, but
their logic is completely identical. The logic in retained functions remains the same and now
these function also accept a generic type to achieve the same level of type safety.

PR Close #38371
This commit is contained in:
Andrew Kushnir
2020-08-05 19:14:08 -07:00
parent 354e66efad
commit 856db56cca
6 changed files with 58 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
goldens/circular-deps/packages.json
View File

@ -1855,11 +1855,6 @@
"packages/forms/src/directives/ng_model.ts",
"packages/forms/src/directives/ng_model_group.ts"
],
[
"packages/forms/src/directives/normalize_validator.ts",
"packages/forms/src/model.ts",
"packages/forms/src/directives/shared.ts"
],
[
"packages/forms/src/directives/reactive_directives/form_control_directive.ts",
"packages/forms/src/directives/shared.ts",