From 856ee734640ac1031603b66d61cc20d1d2373fe3 Mon Sep 17 00:00:00 2001 From: Ben Lesh Date: Wed, 30 May 2018 16:08:28 -0700 Subject: [PATCH] refactor(ivy): clean up (#23899) - remove unnecessary debugger statement - rename `isSelfClosingElement` to `isEmptyElement` - remove unnecessary template anchor in test PR Close #23899 --- packages/compiler/src/render3/view/template.ts | 6 +++--- .../compiler/test/render3/r3_view_compiler_template_spec.ts | 3 --- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/compiler/src/render3/view/template.ts b/packages/compiler/src/render3/view/template.ts index 607703732d..49e593ba90 100644 --- a/packages/compiler/src/render3/view/template.ts +++ b/packages/compiler/src/render3/view/template.ts @@ -315,12 +315,12 @@ export class TemplateDefinitionBuilder implements t.Visitor, LocalResolver this._creationCode.push(...i18nMessages); } - let isSelfClosingElement = element.outputs.length === 0 && element.children.length === 0; + const isEmptyElement = element.outputs.length === 0 && element.children.length === 0; const implicit = o.variable(CONTEXT_NAME); - if (isSelfClosingElement) { + if (isEmptyElement) { this.instruction( this._creationCode, element.sourceSpan, R3.element, ...trimTrailingNulls(parameters)); } else { @@ -377,7 +377,7 @@ export class TemplateDefinitionBuilder implements t.Visitor, LocalResolver t.visitAll(this, element.children); } - if (!isSelfClosingElement) { + if (!isEmptyElement) { // Finish element construction mode. this.instruction( this._creationCode, element.endSourceSpan || element.sourceSpan, R3.elementEnd); diff --git a/packages/compiler/test/render3/r3_view_compiler_template_spec.ts b/packages/compiler/test/render3/r3_view_compiler_template_spec.ts index 86d96f9850..d4593cb197 100644 --- a/packages/compiler/test/render3/r3_view_compiler_template_spec.ts +++ b/packages/compiler/test/render3/r3_view_compiler_template_spec.ts @@ -133,15 +133,12 @@ describe('compiler compliance: template', () => { }; const template = ` - // ... template:function MyComponent_Template(rf: IDENT, $ctx$: IDENT){ if (rf & 1) { $i0$.ɵEe(0,'div'); } }`; - debugger; - const result = compile(files, angularFiles); expectEmit(result.source, template, 'Incorrect template');