From 88c7dfefe6baec7cc9bf33c5e5defb603d7583a5 Mon Sep 17 00:00:00 2001 From: atscott Date: Fri, 10 Jan 2020 13:39:35 -0800 Subject: [PATCH] Revert "build: add better comments to defaults.bzl jasmine_node_test macro (#34589)" (#34730) This reverts commit 753b5bc3055590b89d66f6dff1f89ab1221dc773. PR Close #34730 --- tools/defaults.bzl | 30 +++--------------------------- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/tools/defaults.bzl b/tools/defaults.bzl index 0f74e4292d..f320891c0e 100644 --- a/tools/defaults.bzl +++ b/tools/defaults.bzl @@ -257,30 +257,7 @@ def nodejs_binary(data = [], **kwargs): ) def jasmine_node_test(bootstrap = [], **kwargs): - """Default values for jasmine_node_test - - Args: - bootstrap: A list of labels of scripts to run before the entry_point. - - The labels can either be individual files or a filegroup that contain a single - file. - - The label is automatically added to the deps of jasmine_node_test. - If the label ends in `_es5` which by convention selects the es5 outputs - of a ts_library rule, then corresponding ts_library target sans `_es5` - is also added to the deps of jasmine_node_test. - - For example with, - - jasmine_node_test( - name = "test", - bootstrap = ["//tools/testing:node_es5"], - deps = [":test_lib"], - ) - - the `//tools/testing:node` target will automatically get added to deps - by this macro. This removes the need for duplicate deps on the - target and makes the usage of this rule less verbose.""" + """Default values for jasmine_node_test""" # Very common dependencies for tests deps = kwargs.pop("deps", []) + [ @@ -305,10 +282,9 @@ def jasmine_node_test(bootstrap = [], **kwargs): deps += [label] templated_args += ["--node_options=--require=$(rlocation $(location %s))" % label] if label.endswith("_es5"): - # If this label is a filegroup derived from a ts_library then automatically + # If this label is a filegroup derived from a ts_library then automtically # add the ts_library target (which is the label sans `_es5`) to deps so we pull - # in all of its transitive deps. This removes the need for duplicate deps on the - # target and makes the usage of this rule less verbose. + # in all of its transitive deps deps += [label[:-4]] _jasmine_node_test(