cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(common): don't convert null to a string when flushing a mock request (#21417)

Browse Source 
A bug in TestRequest caused null response bodies to be stringified. This
change causes null to be treated faithfully.

Fixes #20744

PR Close #21417
This commit is contained in:
Alex Rickabaugh
2018-01-09 08:25:01 -08:00
parent f9fa157a09
commit 8b14488827
3 changed files with 36 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/common/http/testing/src/request.ts
View File

@ -184,26 +184,17 @@ function _maybeConvertBody(
responseType: string, body: ArrayBuffer | Blob | string | number | Object |
(string | number | Object | null)[] | null): ArrayBuffer|Blob|string|number|Object|
(string | number | Object | null)[]|null {
if (body === null) {
return null;
}
switch (responseType) {
case 'arraybuffer':
if (body === null) {
return null;
}
return _toArrayBufferBody(body);
case 'blob':
if (body === null) {
return null;
}
return _toBlob(body);
case 'json':
if (body === null) {
return 'null';
}
return _toJsonBody(body);
case 'text':
if (body === null) {
return null;
}
return _toTextBody(body);
default:
throw new Error(`Unsupported responseType: ${responseType}`);