From 8bf6ef6544d96d7d447c50a5b17484cb94b1c509 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Wed, 27 Apr 2016 18:21:04 -0700 Subject: [PATCH] fix(metadata): expose Providers in metadata These worked in Dart because they were effectively exported even without the export keyword. Without exporting these symbols, they are not produced in .metadata.json files, which leaves dangling references from the Decorators that use them. --- .../common/forms/directives/checkbox_value_accessor.ts | 2 +- .../src/common/forms/directives/default_value_accessor.ts | 2 +- .../src/common/forms/directives/ng_control_group.ts | 2 +- .../src/common/forms/directives/ng_control_name.ts | 2 +- modules/angular2/src/common/forms/directives/ng_form.ts | 2 +- .../src/common/forms/directives/ng_form_control.ts | 2 +- .../angular2/src/common/forms/directives/ng_form_model.ts | 2 +- modules/angular2/src/common/forms/directives/ng_model.ts | 2 +- .../src/common/forms/directives/number_value_accessor.ts | 2 +- .../forms/directives/radio_control_value_accessor.ts | 2 +- .../forms/directives/select_control_value_accessor.ts | 2 +- .../angular2/src/common/forms/directives/validators.ts | 8 ++++---- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/modules/angular2/src/common/forms/directives/checkbox_value_accessor.ts b/modules/angular2/src/common/forms/directives/checkbox_value_accessor.ts index fa1802b493..7979ce8fe0 100644 --- a/modules/angular2/src/common/forms/directives/checkbox_value_accessor.ts +++ b/modules/angular2/src/common/forms/directives/checkbox_value_accessor.ts @@ -3,7 +3,7 @@ import {Directive, Renderer, ElementRef, Self, forwardRef, Provider} from 'angul import {NG_VALUE_ACCESSOR, ControlValueAccessor} from './control_value_accessor'; import {CONST_EXPR} from 'angular2/src/facade/lang'; -const CHECKBOX_VALUE_ACCESSOR = CONST_EXPR(new Provider( +export const CHECKBOX_VALUE_ACCESSOR = CONST_EXPR(new Provider( NG_VALUE_ACCESSOR, {useExisting: forwardRef(() => CheckboxControlValueAccessor), multi: true})); /** diff --git a/modules/angular2/src/common/forms/directives/default_value_accessor.ts b/modules/angular2/src/common/forms/directives/default_value_accessor.ts index 5aa92195a9..1d5c704b75 100644 --- a/modules/angular2/src/common/forms/directives/default_value_accessor.ts +++ b/modules/angular2/src/common/forms/directives/default_value_accessor.ts @@ -2,7 +2,7 @@ import {Directive, ElementRef, Renderer, Self, forwardRef, Provider} from 'angul import {NG_VALUE_ACCESSOR, ControlValueAccessor} from './control_value_accessor'; import {isBlank, CONST_EXPR} from 'angular2/src/facade/lang'; -const DEFAULT_VALUE_ACCESSOR = CONST_EXPR(new Provider( +export const DEFAULT_VALUE_ACCESSOR = CONST_EXPR(new Provider( NG_VALUE_ACCESSOR, {useExisting: forwardRef(() => DefaultValueAccessor), multi: true})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_control_group.ts b/modules/angular2/src/common/forms/directives/ng_control_group.ts index f66b6eceb2..037de2764d 100644 --- a/modules/angular2/src/common/forms/directives/ng_control_group.ts +++ b/modules/angular2/src/common/forms/directives/ng_control_group.ts @@ -19,7 +19,7 @@ import {Form} from './form_interface'; import {NG_VALIDATORS, NG_ASYNC_VALIDATORS} from '../validators'; import {AsyncValidatorFn, ValidatorFn} from './validators'; -const controlGroupProvider = +export const controlGroupProvider = CONST_EXPR(new Provider(ControlContainer, {useExisting: forwardRef(() => NgControlGroup)})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_control_name.ts b/modules/angular2/src/common/forms/directives/ng_control_name.ts index 57493193fb..3a5dd04a76 100644 --- a/modules/angular2/src/common/forms/directives/ng_control_name.ts +++ b/modules/angular2/src/common/forms/directives/ng_control_name.ts @@ -31,7 +31,7 @@ import {NG_VALIDATORS, NG_ASYNC_VALIDATORS} from '../validators'; import {ValidatorFn, AsyncValidatorFn} from './validators'; -const controlNameBinding = +export const controlNameBinding = CONST_EXPR(new Provider(NgControl, {useExisting: forwardRef(() => NgControlName)})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_form.ts b/modules/angular2/src/common/forms/directives/ng_form.ts index 639bbf4a58..e8a8efd753 100644 --- a/modules/angular2/src/common/forms/directives/ng_form.ts +++ b/modules/angular2/src/common/forms/directives/ng_form.ts @@ -15,7 +15,7 @@ import {AbstractControl, ControlGroup, Control} from '../model'; import {setUpControl, setUpControlGroup, composeValidators, composeAsyncValidators} from './shared'; import {Validators, NG_VALIDATORS, NG_ASYNC_VALIDATORS} from '../validators'; -const formDirectiveProvider = +export const formDirectiveProvider = CONST_EXPR(new Provider(ControlContainer, {useExisting: forwardRef(() => NgForm)})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_form_control.ts b/modules/angular2/src/common/forms/directives/ng_form_control.ts index 79cfabc8b9..26facfb753 100644 --- a/modules/angular2/src/common/forms/directives/ng_form_control.ts +++ b/modules/angular2/src/common/forms/directives/ng_form_control.ts @@ -25,7 +25,7 @@ import { } from './shared'; import {ValidatorFn, AsyncValidatorFn} from './validators'; -const formControlBinding = +export const formControlBinding = CONST_EXPR(new Provider(NgControl, {useExisting: forwardRef(() => NgFormControl)})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_form_model.ts b/modules/angular2/src/common/forms/directives/ng_form_model.ts index e07c497295..1a06182cdb 100644 --- a/modules/angular2/src/common/forms/directives/ng_form_model.ts +++ b/modules/angular2/src/common/forms/directives/ng_form_model.ts @@ -20,7 +20,7 @@ import {Control, ControlGroup} from '../model'; import {setUpControl, setUpControlGroup, composeValidators, composeAsyncValidators} from './shared'; import {Validators, NG_VALIDATORS, NG_ASYNC_VALIDATORS} from '../validators'; -const formDirectiveProvider = +export const formDirectiveProvider = CONST_EXPR(new Provider(ControlContainer, {useExisting: forwardRef(() => NgFormModel)})); /** diff --git a/modules/angular2/src/common/forms/directives/ng_model.ts b/modules/angular2/src/common/forms/directives/ng_model.ts index 4bcbb960df..b2ed55b2de 100644 --- a/modules/angular2/src/common/forms/directives/ng_model.ts +++ b/modules/angular2/src/common/forms/directives/ng_model.ts @@ -23,7 +23,7 @@ import { } from './shared'; import {ValidatorFn, AsyncValidatorFn} from './validators'; -const formControlBinding = +export const formControlBinding = CONST_EXPR(new Provider(NgControl, {useExisting: forwardRef(() => NgModel)})); /** diff --git a/modules/angular2/src/common/forms/directives/number_value_accessor.ts b/modules/angular2/src/common/forms/directives/number_value_accessor.ts index ae40d1752d..27a1a7a555 100644 --- a/modules/angular2/src/common/forms/directives/number_value_accessor.ts +++ b/modules/angular2/src/common/forms/directives/number_value_accessor.ts @@ -2,7 +2,7 @@ import {Directive, ElementRef, Renderer, Self, forwardRef, Provider} from 'angul import {NG_VALUE_ACCESSOR, ControlValueAccessor} from './control_value_accessor'; import {isBlank, CONST_EXPR, NumberWrapper} from 'angular2/src/facade/lang'; -const NUMBER_VALUE_ACCESSOR = CONST_EXPR(new Provider( +export const NUMBER_VALUE_ACCESSOR = CONST_EXPR(new Provider( NG_VALUE_ACCESSOR, {useExisting: forwardRef(() => NumberValueAccessor), multi: true})); /** diff --git a/modules/angular2/src/common/forms/directives/radio_control_value_accessor.ts b/modules/angular2/src/common/forms/directives/radio_control_value_accessor.ts index ee9475643e..51eaf74367 100644 --- a/modules/angular2/src/common/forms/directives/radio_control_value_accessor.ts +++ b/modules/angular2/src/common/forms/directives/radio_control_value_accessor.ts @@ -20,7 +20,7 @@ import {NgControl} from 'angular2/src/common/forms/directives/ng_control'; import {CONST_EXPR, looseIdentical, isPresent} from 'angular2/src/facade/lang'; import {ListWrapper} from 'angular2/src/facade/collection'; -const RADIO_VALUE_ACCESSOR = CONST_EXPR(new Provider( +export const RADIO_VALUE_ACCESSOR = CONST_EXPR(new Provider( NG_VALUE_ACCESSOR, {useExisting: forwardRef(() => RadioControlValueAccessor), multi: true})); diff --git a/modules/angular2/src/common/forms/directives/select_control_value_accessor.ts b/modules/angular2/src/common/forms/directives/select_control_value_accessor.ts index 408b336454..e70e1a94bf 100644 --- a/modules/angular2/src/common/forms/directives/select_control_value_accessor.ts +++ b/modules/angular2/src/common/forms/directives/select_control_value_accessor.ts @@ -21,7 +21,7 @@ import { import {MapWrapper} from 'angular2/src/facade/collection'; -const SELECT_VALUE_ACCESSOR = CONST_EXPR(new Provider( +export const SELECT_VALUE_ACCESSOR = CONST_EXPR(new Provider( NG_VALUE_ACCESSOR, {useExisting: forwardRef(() => SelectControlValueAccessor), multi: true})); function _buildValueString(id: string, value: any): string { diff --git a/modules/angular2/src/common/forms/directives/validators.ts b/modules/angular2/src/common/forms/directives/validators.ts index fca03aa50a..25e35023df 100644 --- a/modules/angular2/src/common/forms/directives/validators.ts +++ b/modules/angular2/src/common/forms/directives/validators.ts @@ -27,7 +27,7 @@ export interface Validator { validate(c: modelModule.AbstractControl): {[key: st const REQUIRED = Validators.required; -const REQUIRED_VALIDATOR = +export const REQUIRED_VALIDATOR = CONST_EXPR(new Provider(NG_VALIDATORS, {useValue: REQUIRED, multi: true})); /** @@ -59,7 +59,7 @@ export interface AsyncValidatorFn { * * {@example common/forms/ts/validators/validators.ts region='min'} */ -const MIN_LENGTH_VALIDATOR = CONST_EXPR( +export const MIN_LENGTH_VALIDATOR = CONST_EXPR( new Provider(NG_VALIDATORS, {useExisting: forwardRef(() => MinLengthValidator), multi: true})); /** @@ -87,7 +87,7 @@ export class MinLengthValidator implements Validator { * * {@example common/forms/ts/validators/validators.ts region='max'} */ -const MAX_LENGTH_VALIDATOR = CONST_EXPR( +export const MAX_LENGTH_VALIDATOR = CONST_EXPR( new Provider(NG_VALIDATORS, {useExisting: forwardRef(() => MaxLengthValidator), multi: true})); /** @@ -121,7 +121,7 @@ export class MaxLengthValidator implements Validator { * * ``` */ -const PATTERN_VALIDATOR = CONST_EXPR( +export const PATTERN_VALIDATOR = CONST_EXPR( new Provider(NG_VALIDATORS, {useExisting: forwardRef(() => PatternValidator), multi: true})); @Directive({ selector: '[pattern][ngControl],[pattern][ngFormControl],[pattern][ngModel]',