From 8c00fced1c8ba26b31dd7bcf06bb3a33806b5ed4 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Sat, 18 May 2019 00:20:46 +0300 Subject: [PATCH] docs: add info about who adds/removes labels in `TRIAGE_AND_LABELS.md` (#30171) PR Close #30171 --- docs/TRIAGE_AND_LABELS.md | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/docs/TRIAGE_AND_LABELS.md b/docs/TRIAGE_AND_LABELS.md index b5a307110a..86f626c661 100644 --- a/docs/TRIAGE_AND_LABELS.md +++ b/docs/TRIAGE_AND_LABELS.md @@ -120,17 +120,27 @@ Triaging PRs is the same as triaging issues, except that the labels `frequency: PRs also have additional label categories that should be used to signal their state. -Every triaged PR must have a `pr_action` label assigned to it: +Every triaged PR must have a `PR action` label assigned to it: -* `PR action: cleanup` - more work is needed from the author. -* `PR action: discuss` - discussion is needed, to be led by the author. -* `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready". +* `PR action: discuss`: Discussion is needed, to be led by the author. + * _**Who adds it:** Typically the PR author._ + * _**Who removes it:** Whoever added it._ +* `PR action: cleanup`: More work is needed from the author. + * _**Who adds it:** The reviewer requesting changes to the PR._ + * _**Who removes it:** Either the author (after implementing the requested changes) or the reviewer (after confirming the requested changes have been implemented)._ +* `PR action: merge`: The PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready". + * _**Who adds it:** Typically the PR author._ + * _**Who removes it:** Whoever added it._ In addition, PRs can have the following states: -* `PR state: WIP` - PR is experimental or rapidly changing. Not ready for review or triage. -* `PR state: blocked` - PR is blocked on an issue or other PR. Not ready for review or triage or merge. +* `PR state: WIP`: PR is experimental or rapidly changing. Not ready for review or triage. + * _**Who adds it:** The PR author._ + * _**Who removes it:** Whoever added it._ +* `PR state: blocked`: PR is blocked on an issue or other PR. Not ready for merge. + * _**Who adds it:** Any team member._ + * _**Who removes it:** Any team member._ When a PR is ready for review, a review should be requested using the Reviewers interface in Github. @@ -167,14 +177,23 @@ Only the `PR action: merge` label means that the PR is ready for merging. ## Special Labels ### `cla: yes`, `cla: no` +* _**Who adds it:** @googlebot, or a Googler manually overriding the status in case the bot got it wrong._ +* _**Who removes it:** @googlebot._ + Managed by googlebot. Indicates whether a PR has a CLA on file for its author(s). Only issues with `cla:yes` should be merged into master. ### `aio: preview` +* _**Who adds it:** Any team member. (Typically the author or a reviewer.)_ +* _**Who removes it:** Any team member. (Typically, whoever added it.)_ + Applying this label to a PR makes the angular.io preview available regardless of the author. [More info](../aio/aio-builds-setup/docs/overview--security-model.md) ### `PR action: merge-assistance` +* _**Who adds it:** Any team member._ +* _**Who removes it:** Any team member._ + This label can be added to let the caretaker know that the PR needs special attention. There should always be a comment added to the PR to explain why the caretaker's assistance is needed. The comment should be formatted like this: `merge-assistance: `