From 8e12707f883226d478ea3f64066122184440a2b9 Mon Sep 17 00:00:00 2001
From: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date: Wed, 12 Feb 2020 11:52:15 +0100
Subject: [PATCH] build: remove dependency on `@types/chokidar` (#35371)

We recently updated chokidar to `3.0.0`. The latest version of
chokidar provides TypeScript types on its own and makes the extra
dependency on the `@types` unnecessary.

This seems to have caused the `build-packages-dist` script to fail with
an error like:

```
[strictDeps] transitive dependency on external/npm/node_modules/chokidar/types/index.d.ts
   not allowed. Please add the BUILD target to your rule's deps.
```

It's unclear why that happens, but a reasonable theory would be that
the TS compilation accidentally picked up the types from `chokidar`
instead of `@types/chokidar`, and the strict deps `@bazel/typescript`
check reported this as issue because it's not an explicit target dependency.

PR Close #35371
---
 package.json                      | 1 -
 packages/compiler-cli/BUILD.bazel | 2 +-
 yarn.lock                         | 8 --------
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/package.json b/package.json
index c305d4cc43..af3af0f465 100644
--- a/package.json
+++ b/package.json
@@ -55,7 +55,6 @@
     "@types/base64-js": "1.2.5",
     "@types/bluebird": "^3.5.27",
     "@types/chai": "^4.1.2",
-    "@types/chokidar": "^1.7.5",
     "@types/convert-source-map": "^1.5.1",
     "@types/diff": "^3.5.1",
     "@types/fs-extra": "4.0.2",
diff --git a/packages/compiler-cli/BUILD.bazel b/packages/compiler-cli/BUILD.bazel
index 3ad34b06c0..250657d0f5 100644
--- a/packages/compiler-cli/BUILD.bazel
+++ b/packages/compiler-cli/BUILD.bazel
@@ -30,8 +30,8 @@ ts_library(
         "//packages/compiler-cli/src/ngtsc/indexer",
         "//packages/compiler-cli/src/ngtsc/perf",
         "@npm//@bazel/typescript",
-        "@npm//@types/chokidar",
         "@npm//@types/node",
+        "@npm//chokidar",
         "@npm//fs-extra",
         "@npm//minimist",
         "@npm//reflect-metadata",
diff --git a/yarn.lock b/yarn.lock
index b66edb76e2..0460d58d1b 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1401,14 +1401,6 @@
   resolved "https://registry.yarnpkg.com/@types/chai/-/chai-4.1.7.tgz#1b8e33b61a8c09cbe1f85133071baa0dbf9fa71a"
   integrity sha512-2Y8uPt0/jwjhQ6EiluT0XCri1Dbplr0ZxfFXUz+ye13gaqE8u5gL5ppao1JrUYr9cIip5S6MvQzBS7Kke7U9VA==
 
-"@types/chokidar@^1.7.5":
-  version "1.7.5"
-  resolved "https://registry.yarnpkg.com/@types/chokidar/-/chokidar-1.7.5.tgz#1fa78c8803e035bed6d98e6949e514b133b0c9b6"
-  integrity sha512-PDkSRY7KltW3M60hSBlerxI8SFPXsO3AL/aRVsO4Kh9IHRW74Ih75gUuTd/aE4LSSFqypb10UIX3QzOJwBQMGQ==
-  dependencies:
-    "@types/events" "*"
-    "@types/node" "*"
-
 "@types/color-name@^1.1.1":
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/@types/color-name/-/color-name-1.1.1.tgz#1c1261bbeaa10a8055bbc5d8ab84b7b2afc846a0"