From 8e201f713a9e8c70db3731af285997443e1c5a96 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Sun, 28 Apr 2019 20:48:33 +0100 Subject: [PATCH] test(ivy): ngcc - check the actual file that is passed to `renderImports` (#25445) Previously we were just checking that the object was "any" object but now we check that it is the file object that we expected. PR Close #25445 --- .../ngcc/test/rendering/renderer_spec.ts | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts b/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts index 9a28d8b01a..3a9d757074 100644 --- a/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts +++ b/packages/compiler-cli/ngcc/test/rendering/renderer_spec.ts @@ -80,8 +80,12 @@ function createTestRenderer( spyOn(renderer, 'addDefinitions').and.callThrough(); spyOn(renderer, 'removeDecorators').and.callThrough(); - return {renderer, decorationAnalyses, switchMarkerAnalyses, moduleWithProvidersAnalyses, - privateDeclarationsAnalyses}; + return {renderer, + decorationAnalyses, + switchMarkerAnalyses, + moduleWithProvidersAnalyses, + privateDeclarationsAnalyses, + bundle}; } @@ -488,8 +492,12 @@ describe('Renderer', () => { contents: 'export declare class LibraryModule {}' }, ]; - const {renderer, decorationAnalyses, switchMarkerAnalyses, privateDeclarationsAnalyses, - moduleWithProvidersAnalyses} = + const {renderer, + decorationAnalyses, + switchMarkerAnalyses, + privateDeclarationsAnalyses, + moduleWithProvidersAnalyses, + bundle} = createTestRenderer( 'test-package', MODULE_WITH_PROVIDERS_PROGRAM, MODULE_WITH_PROVIDERS_DTS_PROGRAM); @@ -526,7 +534,7 @@ describe('Renderer', () => { {specifier: '@angular/core', qualifier: 'ɵngcc1'}, {specifier: 'some-library', qualifier: 'ɵngcc2'}, ], - jasmine.anything()); + bundle.dts !.file); // The following expectation checks that we do not mistake `ModuleWithProviders` types