From 9021d3f5e1d23a98b821ac4f2e4f94b1a3c42ef6 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Tue, 14 Jul 2020 12:17:56 +0300 Subject: [PATCH] docs: fix live examples in testing guides (#38038) In #37957, parts of the testing guide were broken out into separate guides. As part of that work, the `` tags were also copied to the new guides. These `` tags did not specify the targeted example project via the `name` attribute, thus they were implicitly targeting the example with the same name as the guide they were in. See the [Docs style guide][1] for more info. However, there is only one example project (`testing/`) and all `` tags were supposed to target that. This worked fine on the `testing.md` guide, but it broke on other guides (which tried to target non-existing example projects based on their names). This commit fixes it by explicitly specifying which example is targeted by the `` tags. It also removes the `embedded-style` attribute that has no effect. [1]: https://angular.io/guide/docs-style-guide#live-examples Fixes #38036 PR Close #38038 --- aio/content/guide/test-debugging.md | 4 ++-- aio/content/guide/testing-attribute-directives.md | 4 ++-- aio/content/guide/testing-code-coverage.md | 4 ++-- aio/content/guide/testing-components-basics.md | 4 ++-- aio/content/guide/testing-components-scenarios.md | 4 ++-- aio/content/guide/testing-pipes.md | 4 ++-- aio/content/guide/testing-services.md | 4 ++-- aio/content/guide/testing.md | 2 +- 8 files changed, 15 insertions(+), 15 deletions(-) diff --git a/aio/content/guide/test-debugging.md b/aio/content/guide/test-debugging.md index 331ed45943..43c6e98fbb 100644 --- a/aio/content/guide/test-debugging.md +++ b/aio/content/guide/test-debugging.md @@ -4,9 +4,9 @@ If your tests aren't working as you expect them to, you can inspect and debug th
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-attribute-directives.md b/aio/content/guide/testing-attribute-directives.md index 3c704da745..3dcdd6a76f 100644 --- a/aio/content/guide/testing-attribute-directives.md +++ b/aio/content/guide/testing-attribute-directives.md @@ -8,9 +8,9 @@ Its name reflects the way the directive is applied: as an attribute on a host el
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-code-coverage.md b/aio/content/guide/testing-code-coverage.md index d115544d46..0b0b856d77 100644 --- a/aio/content/guide/testing-code-coverage.md +++ b/aio/content/guide/testing-code-coverage.md @@ -7,9 +7,9 @@ Code coverage reports show you any parts of your code base that may not be prope
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-components-basics.md b/aio/content/guide/testing-components-basics.md index 03fcb3c53b..01e0bec05a 100644 --- a/aio/content/guide/testing-components-basics.md +++ b/aio/content/guide/testing-components-basics.md @@ -15,9 +15,9 @@ can validate much of the component's behavior in an easier, more obvious way.
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-components-scenarios.md b/aio/content/guide/testing-components-scenarios.md index f7f1f43ba7..cdd66ad27e 100644 --- a/aio/content/guide/testing-components-scenarios.md +++ b/aio/content/guide/testing-components-scenarios.md @@ -4,9 +4,9 @@ This guide explores common component testing use cases.
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-pipes.md b/aio/content/guide/testing-pipes.md index 90ca07988a..fef0776486 100644 --- a/aio/content/guide/testing-pipes.md +++ b/aio/content/guide/testing-pipes.md @@ -4,9 +4,9 @@ You can test [pipes](guide/pipes) without the Angular testing utilities.
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing-services.md b/aio/content/guide/testing-services.md index 797cd8e7e3..265570d55a 100644 --- a/aio/content/guide/testing-services.md +++ b/aio/content/guide/testing-services.md @@ -5,9 +5,9 @@ To check that your services are working as you intend, you can write tests speci
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. - For the tests features in the testing guides, see tests. + For the tests features in the testing guides, see tests.
diff --git a/aio/content/guide/testing.md b/aio/content/guide/testing.md index 557571acba..a0ded80616 100644 --- a/aio/content/guide/testing.md +++ b/aio/content/guide/testing.md @@ -21,7 +21,7 @@ This sample application is much like the one in the [_Tour of Heroes_ tutorial](
- For the sample app that the testing guides describe, see the sample app. + For the sample app that the testing guides describe, see the sample app. For the tests features in the testing guides, see tests.