cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(router): throw when component in route config is not defined

Browse Source 
Close #3265

Closes #3569
This commit is contained in:
Brian Ford
2015-08-10 13:05:08 -07:00
parent f83289b1a0
commit 903a0f0513
3 changed files with 41 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
modules/angular2/src/router/route_registry.ts
View File

@ -19,9 +19,17 @@ import {
isFunction,
StringWrapper,
BaseException,
Type,
getTypeNameForDebugging
} from 'angular2/src/facade/lang';
import {RouteConfig, AsyncRoute, Route, Redirect, RouteDefinition} from './route_config_impl';
import {
RouteConfig,
AsyncRoute,
Route,
AuxRoute,
Redirect,
RouteDefinition
} from './route_config_impl';
import {reflector} from 'angular2/src/reflection/reflection';
import {Injectable} from 'angular2/di';
import {normalizeRouteConfig} from './route_config_nomalizer';
@ -44,6 +52,13 @@ export class RouteRegistry {
config(parentComponent: any, config: RouteDefinition): void {
config = normalizeRouteConfig(config);
// this is here because Dart type guard reasons
if (config instanceof Route) {
assertComponentExists(config.component, config.path);
} else if (config instanceof AuxRoute) {
assertComponentExists(config.component, config.path);
}
var recognizer: RouteRecognizer = this._rules.get(parentComponent);
if (isBlank(recognizer)) {
@ -269,3 +284,9 @@ function assertTerminalComponent(component, path) {
}
}
}
function assertComponentExists(component: Type, path: string): void {
if (!isType(component)) {
throw new BaseException(`Component for route "${path}" is not defined, or is not a class.`);
}
}