cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): better failure message for explicit-query timing tslint rule (#29258)

Browse Source 
Improves the failure message for the `explicit-query` timing TSLint rule
that is used within Google. Currently it's not very clear what action
developers need to take in order to resolve the lint failure manually.

PR Close #29258
This commit is contained in:
Paul Gschwendtner
2019-03-13 16:46:06 +01:00
committed by Matias Niemelä
parent 8ef46f38f4
commit 90df7de54d
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/schematics/test/google3/explicit_query_timing_rule_spec.ts
View File

@ -109,7 +109,7 @@ describe('Google3 explicitQueryTiming TSLint rule', () => {
const failures = linter.getResult().failures;
expect(failures.length).toBe(1);
expect(failures[0].getFailure()).toContain('Query is not explicitly marked as "static"');
expect(failures[0].getFailure()).toMatch(/analysis of the query.*"static"/);
});
it('should report non-explicit dynamic query definitions', () => {
@ -126,6 +126,6 @@ describe('Google3 explicitQueryTiming TSLint rule', () => {
const failures = linter.getResult().failures;
expect(failures.length).toBe(1);
expect(failures[0].getFailure()).toContain('Query is not explicitly marked as "dynamic"');
expect(failures[0].getFailure()).toMatch(/analysis of the query.*"dynamic"/);
});
});