refactor(Parser): cleanup

modules/change_detection/src/parser/ast.js

@@ -326,6 +326,9 @@ export class FunctionCall extends AST {
 
   eval(context) {
     var obj = this.target.eval(context);
+    if (! (obj instanceof Function)) {
+      throw new BaseException(`${obj} is not a function`);
+    }
     return FunctionWrapper.apply(obj, evalList(context, this.args));
   }
 

modules/change_detection/src/parser/closure_map.es6

@@ -10,6 +10,9 @@ export class ClosureMap {
   }
 
   fn(name:string) {
-    return new Function('o', 'args', 'return o.' + name + '.apply(o, args);');
+    var method = `o.${name}`;
+    return new Function('o', 'args',
+      `if (!${method}) throw new Error('"${name}" is undefined');` +
+      `return ${method}.apply(o, args);`);
   }
 }

modules/change_detection/src/parser/parser.js

@@ -115,7 +115,7 @@ class _ParseAST {
   expectIdentifierOrKeywordOrString():string {
     var n = this.next;
     if (!n.isIdentifier() && !n.isKeyword() && !n.isString()) {
-      this.error(`Unexpected token ${n}, expected identifier, or keyword, or string`)
+      this.error(`Unexpected token ${n}, expected identifier, keyword, or string`)
     }
     this.advance();
     return n.toString();
@@ -127,10 +127,13 @@ class _ParseAST {
       var expr = this.parseFormatter();
       ListWrapper.push(exprs, expr);
 
-      while (this.optionalCharacter($SEMICOLON)) {
+      if (this.optionalCharacter($SEMICOLON)) {
         if (! this.parseAction) {
           this.error("Binding expression cannot contain chained expression");
         }
+        while (this.optionalCharacter($SEMICOLON)){} //read all semicolons
+      } else if (this.index < this.tokens.length) {
+        this.error(`Unexpected token '${this.next}'`);
       }
     }
     return exprs.length == 1 ? exprs[0] : new Chain(exprs);
@@ -163,6 +166,10 @@ class _ParseAST {
         this.error(`Expression ${expression} is not assignable`);
       }
 
+      if (!this.parseAction) {
+        this.error("Binding expression cannot contain assignments");
+      }
+
       this.expectOperator('=');
       result = new Assignment(result, this.parseConditional());
     }
@@ -303,7 +310,12 @@ class _ParseAST {
   }
 
   parsePrimary() {
-    if (this.next.isKeywordNull() || this.next.isKeywordUndefined()) {
+    if (this.optionalCharacter($LPAREN)) {
+      var result = this.parseFormatter();
+      this.expectCharacter($RPAREN);
+      return result;
+
+    } else if (this.next.isKeywordNull() || this.next.isKeywordUndefined()) {
       this.advance();
       return new LiteralPrimitive(null);