cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): finish root cause analysis for @angular/core TestBed failing tests (#27510)

Browse Source 
PR Close #27510
This commit is contained in:
Pawel Kozlowski 2018-12-06 15:20:11 +01:00 committed by Igor Minar
parent 8fa7e93c30
commit 913563a41d
9 changed files with 130 additions and 123 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
packages/core/test/application_ref_integration_spec.ts
View File

@ -9,7 +9,7 @@
import {ApplicationRef, Component, DoCheck, NgModule, OnInit, TestabilityRegistry, ɵivyEnabled as ivyEnabled} from '@angular/core'; import {ApplicationRef, Component, DoCheck, NgModule, OnInit, TestabilityRegistry, ɵivyEnabled as ivyEnabled} from '@angular/core';
import {getTestBed} from '@angular/core/testing'; import {getTestBed} from '@angular/core/testing';
import {BrowserModule} from '@angular/platform-browser'; import {BrowserModule} from '@angular/platform-browser';
import {fixmeIvy, withBody} from '@angular/private/testing'; import {withBody} from '@angular/private/testing';
import {NgModuleFactory} from '../src/render3/ng_module_ref'; import {NgModuleFactory} from '../src/render3/ng_module_ref';
@ -35,26 +35,27 @@ ivyEnabled && describe('ApplicationRef bootstrap', () => {
class MyAppModule { class MyAppModule {
} }
fixmeIvy('unknown').it( it('should bootstrap hello world', withBody('<hello-world></hello-world>', async() => {
'should bootstrap hello world', withBody('<hello-world></hello-world>', async() => { const MyAppModuleFactory = new NgModuleFactory(MyAppModule);
const MyAppModuleFactory = new NgModuleFactory(MyAppModule); const moduleRef =
const moduleRef = await getTestBed().platform.bootstrapModuleFactory( await getTestBed().platform.bootstrapModuleFactory(MyAppModuleFactory, {ngZone: 'noop'});
MyAppModuleFactory, {ngZone: 'noop'}); const appRef = moduleRef.injector.get(ApplicationRef);
const appRef = moduleRef.injector.get(ApplicationRef); const helloWorldComponent = appRef.components[0].instance as HelloWorldComponent;
const helloWorldComponent = appRef.components[0].instance as HelloWorldComponent; expect(document.body.innerHTML)
expect(document.body.innerHTML) .toEqual(
.toEqual('<hello-world><div>Hello World</div></hello-world>'); '<hello-world ng-version="0.0.0-PLACEHOLDER"><div>Hello World</div></hello-world>');
expect(helloWorldComponent.log).toEqual(['OnInit', 'DoCheck']); expect(helloWorldComponent.log).toEqual(['OnInit', 'DoCheck']);
helloWorldComponent.name = 'Mundo'; helloWorldComponent.name = 'Mundo';
appRef.tick(); appRef.tick();
expect(document.body.innerHTML) expect(document.body.innerHTML)
.toEqual('<hello-world><div>Hello Mundo</div></hello-world>'); .toEqual(
expect(helloWorldComponent.log).toEqual(['OnInit', 'DoCheck', 'DoCheck']); '<hello-world ng-version="0.0.0-PLACEHOLDER"><div>Hello Mundo</div></hello-world>');
expect(helloWorldComponent.log).toEqual(['OnInit', 'DoCheck', 'DoCheck']);
// Cleanup TestabilityRegistry // Cleanup TestabilityRegistry
const registry: TestabilityRegistry = getTestBed().get(TestabilityRegistry); const registry: TestabilityRegistry = getTestBed().get(TestabilityRegistry);
registry.unregisterAllApplications(); registry.unregisterAllApplications();
})); }));
}); });

9
packages/core/test/fake_async_spec.ts
View File

@ -33,10 +33,11 @@ const ProxyZoneSpec: {assertPresent: () => void} = (Zone as any)['ProxyZoneSpec'
})('foo', 'bar'); })('foo', 'bar');
}); });
fixmeIvy('unknown').it( fixmeIvy('FW-806: Ivy\'s TestBed implementation doesn\'t inject compiler-related tokens')
'should work with inject()', fakeAsync(inject([Parser], (parser: any /** TODO #9100 */) => { .it('should work with inject()',
expect(parser).toBeAnInstanceOf(Parser); fakeAsync(inject([Parser], (parser: any /** TODO #9100 */) => {
}))); expect(parser).toBeAnInstanceOf(Parser);
})));
it('should throw on nested calls', () => { it('should throw on nested calls', () => {
expect(() => { expect(() => {

28
packages/core/test/linker/entry_components_integration_spec.ts
View File

@ -69,20 +69,22 @@ function declareTests(config?: {useJit: boolean}) {
expect(childComp.cfr.resolveComponentFactory(ChildComp) !.componentType).toBe(ChildComp); expect(childComp.cfr.resolveComponentFactory(ChildComp) !.componentType).toBe(ChildComp);
}); });
fixmeIvy('unknown').it( fixmeIvy(
'should not be able to get components from a parent component (content hierarchy)', () => { 'FW-805: Ivy\'s implementation of ComponentFactoryResolver doesn\'t have checks present in the view engine')
TestBed.overrideComponent( .it('should not be able to get components from a parent component (content hierarchy)',
MainComp, {set: {template: '<child><nested></nested></child>'}}); () => {
TestBed.overrideComponent(ChildComp, {set: {template: '<ng-content></ng-content>'}}); TestBed.overrideComponent(
MainComp, {set: {template: '<child><nested></nested></child>'}});
TestBed.overrideComponent(ChildComp, {set: {template: '<ng-content></ng-content>'}});
const compFixture = TestBed.createComponent(MainComp); const compFixture = TestBed.createComponent(MainComp);
const nestedChildCompEl = compFixture.debugElement.children[0].children[0]; const nestedChildCompEl = compFixture.debugElement.children[0].children[0];
const nestedChildComp: NestedChildComp = nestedChildCompEl.componentInstance; const nestedChildComp: NestedChildComp = nestedChildCompEl.componentInstance;
expect(nestedChildComp.cfr.resolveComponentFactory(ChildComp) !.componentType) expect(nestedChildComp.cfr.resolveComponentFactory(ChildComp) !.componentType)
.toBe(ChildComp); .toBe(ChildComp);
expect(() => nestedChildComp.cfr.resolveComponentFactory(NestedChildComp)) expect(() => nestedChildComp.cfr.resolveComponentFactory(NestedChildComp))
.toThrow(noComponentFactoryError(NestedChildComp)); .toThrow(noComponentFactoryError(NestedChildComp));
}); });
}); });
} }

25
packages/core/test/linker/integration_spec.ts
View File

@ -1331,21 +1331,24 @@ function declareTests(config?: {useJit: boolean}) {
expect(comp.injectable).toBeAnInstanceOf(InjectableService); expect(comp.injectable).toBeAnInstanceOf(InjectableService);
}); });
fixmeIvy('unknown').it('should support viewProviders', () => { fixmeIvy(
TestBed.configureTestingModule({ 'FW-804: Injection of view providers with the @Host annotation works differently in ivy')
declarations: [MyComp, DirectiveProvidingInjectableInView, DirectiveConsumingInjectable], .it('should support viewProviders', () => {
schemas: [NO_ERRORS_SCHEMA], TestBed.configureTestingModule({
}); declarations:
const template = ` [MyComp, DirectiveProvidingInjectableInView, DirectiveConsumingInjectable],
schemas: [NO_ERRORS_SCHEMA],
});
const template = `
<directive-consuming-injectable #consuming> <directive-consuming-injectable #consuming>
</directive-consuming-injectable> </directive-consuming-injectable>
`; `;
TestBed.overrideComponent(DirectiveProvidingInjectableInView, {set: {template}}); TestBed.overrideComponent(DirectiveProvidingInjectableInView, {set: {template}});
const fixture = TestBed.createComponent(DirectiveProvidingInjectableInView); const fixture = TestBed.createComponent(DirectiveProvidingInjectableInView);
const comp = fixture.debugElement.children[0].references !['consuming']; const comp = fixture.debugElement.children[0].references !['consuming'];
expect(comp.injectable).toBeAnInstanceOf(InjectableService); expect(comp.injectable).toBeAnInstanceOf(InjectableService);
}); });
it('should support unbounded lookup', () => { it('should support unbounded lookup', () => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({

11
packages/core/test/linker/ng_module_integration_spec.ts
View File

@ -745,12 +745,11 @@ function declareTests(config?: {useJit: boolean}) {
expect(cars[0]).toBe(injector.get(SportsCar)); expect(cars[0]).toBe(injector.get(SportsCar));
}); });
fixmeIvy('FW-682: Compiler error handling') it('should throw when the aliased provider does not exist', () => {
.it('should throw when the aliased provider does not exist', () => { const injector = createInjector([{provide: 'car', useExisting: SportsCar}]);
const injector = createInjector([{provide: 'car', useExisting: SportsCar}]); const e = `NullInjectorError: No provider for ${stringify(SportsCar)}!`;
const e = `NullInjectorError: No provider for ${stringify(SportsCar)}!`; expect(() => injector.get('car')).toThrowError(e);
expect(() => injector.get('car')).toThrowError(e); });
});
it('should handle forwardRef in useExisting', () => { it('should handle forwardRef in useExisting', () => {
const injector = createInjector([ const injector = createInjector([

61
packages/core/test/linker/regression_integration_spec.ts
View File

@ -75,46 +75,43 @@ function declareTests(config?: {useJit: boolean}) {
expect(CountingPipe.calls).toBe(1); expect(CountingPipe.calls).toBe(1);
}); });
fixmeIvy('FW-756: Pipes and directives from imported modules are not taken into account') it('should only update the bound property when using asyncPipe - #15205', fakeAsync(() => {
.it('should only update the bound property when using asyncPipe - #15205', @Component({template: '<div myDir [a]="p | async" [b]="2"></div>'})
fakeAsync(() => { class MyComp {
@Component({template: '<div myDir [a]="p | async" [b]="2"></div>'}) p = Promise.resolve(1);
class MyComp { }
p = Promise.resolve(1);
}
@Directive({selector: '[myDir]'}) @Directive({selector: '[myDir]'})
class MyDir { class MyDir {
setterCalls: {[key: string]: any} = {}; setterCalls: {[key: string]: any} = {};
// TODO(issue/24571): remove '!'. // TODO(issue/24571): remove '!'.
changes !: SimpleChanges; changes !: SimpleChanges;
@Input() @Input()
set a(v: number) { this.setterCalls['a'] = v; } set a(v: number) { this.setterCalls['a'] = v; }
@Input() @Input()
set b(v: number) { this.setterCalls['b'] = v; } set b(v: number) { this.setterCalls['b'] = v; }
ngOnChanges(changes: SimpleChanges) { this.changes = changes; } ngOnChanges(changes: SimpleChanges) { this.changes = changes; }
} }
TestBed.configureTestingModule({declarations: [MyDir, MyComp]}); TestBed.configureTestingModule({declarations: [MyDir, MyComp]});
const fixture = TestBed.createComponent(MyComp); const fixture = TestBed.createComponent(MyComp);
const dir = const dir = fixture.debugElement.query(By.directive(MyDir)).injector.get(MyDir) as MyDir;
fixture.debugElement.query(By.directive(MyDir)).injector.get(MyDir) as MyDir;
fixture.detectChanges(); fixture.detectChanges();
expect(dir.setterCalls).toEqual({'a': null, 'b': 2}); expect(dir.setterCalls).toEqual({'a': null, 'b': 2});
expect(Object.keys(dir.changes)).toEqual(['a', 'b']); expect(Object.keys(dir.changes)).toEqual(['a', 'b']);
dir.setterCalls = {}; dir.setterCalls = {};
dir.changes = {}; dir.changes = {};
tick(); tick();
fixture.detectChanges(); fixture.detectChanges();
expect(dir.setterCalls).toEqual({'a': 1}); expect(dir.setterCalls).toEqual({'a': 1});
expect(Object.keys(dir.changes)).toEqual(['a']); expect(Object.keys(dir.changes)).toEqual(['a']);
})); }));
it('should only evaluate methods once - #10639', () => { it('should only evaluate methods once - #10639', () => {
TestBed.configureTestingModule({declarations: [MyCountingComp]}); TestBed.configureTestingModule({declarations: [MyCountingComp]});

73
packages/core/test/view/provider_spec.ts
View File

@ -138,34 +138,36 @@ import {fixmeIvy} from '@angular/private/testing';
expect(instance.dep instanceof Dep).toBeTruthy(); expect(instance.dep instanceof Dep).toBeTruthy();
}); });
fixmeIvy('unknown').it('should not inject deps from sibling root elements', () => { fixmeIvy(
const rootElNodes = [ 'FW-807: NgModule injector doesn\'t report full search path if a token is not found')
elementDef(0, NodeFlags.None, null, null, 1, 'span'), .it('should not inject deps from sibling root elements', () => {
directiveDef(1, NodeFlags.None, null, 0, Dep, []), const rootElNodes = [
elementDef(2, NodeFlags.None, null, null, 1, 'span'), elementDef(0, NodeFlags.None, null, null, 1, 'span'),
directiveDef(3, NodeFlags.None, null, 0, SomeService, [Dep]), directiveDef(1, NodeFlags.None, null, 0, Dep, []),
]; elementDef(2, NodeFlags.None, null, null, 1, 'span'),
directiveDef(3, NodeFlags.None, null, 0, SomeService, [Dep]),
];
expect(() => createAndGetRootNodes(compViewDef(rootElNodes))) expect(() => createAndGetRootNodes(compViewDef(rootElNodes)))
.toThrowError( .toThrowError(
'StaticInjectorError(DynamicTestModule)[SomeService -> Dep]: \n' + 'StaticInjectorError(DynamicTestModule)[SomeService -> Dep]: \n' +
' StaticInjectorError(Platform: core)[SomeService -> Dep]: \n' + ' StaticInjectorError(Platform: core)[SomeService -> Dep]: \n' +
' NullInjectorError: No provider for Dep!'); ' NullInjectorError: No provider for Dep!');
const nonRootElNodes = [ const nonRootElNodes = [
elementDef(0, NodeFlags.None, null, null, 4, 'span'), elementDef(0, NodeFlags.None, null, null, 4, 'span'),
elementDef(1, NodeFlags.None, null, null, 1, 'span'), elementDef(1, NodeFlags.None, null, null, 1, 'span'),
directiveDef(2, NodeFlags.None, null, 0, Dep, []), directiveDef(2, NodeFlags.None, null, 0, Dep, []),
elementDef(3, NodeFlags.None, null, null, 1, 'span'), elementDef(3, NodeFlags.None, null, null, 1, 'span'),
directiveDef(4, NodeFlags.None, null, 0, SomeService, [Dep]), directiveDef(4, NodeFlags.None, null, 0, SomeService, [Dep]),
]; ];
expect(() => createAndGetRootNodes(compViewDef(nonRootElNodes))) expect(() => createAndGetRootNodes(compViewDef(nonRootElNodes)))
.toThrowError( .toThrowError(
'StaticInjectorError(DynamicTestModule)[SomeService -> Dep]: \n' + 'StaticInjectorError(DynamicTestModule)[SomeService -> Dep]: \n' +
' StaticInjectorError(Platform: core)[SomeService -> Dep]: \n' + ' StaticInjectorError(Platform: core)[SomeService -> Dep]: \n' +
' NullInjectorError: No provider for Dep!'); ' NullInjectorError: No provider for Dep!');
}); });
it('should inject from a parent element in a parent view', () => { it('should inject from a parent element in a parent view', () => {
createAndGetRootNodes(compViewDef([ createAndGetRootNodes(compViewDef([
@ -181,16 +183,17 @@ import {fixmeIvy} from '@angular/private/testing';
expect(instance.dep instanceof Dep).toBeTruthy(); expect(instance.dep instanceof Dep).toBeTruthy();
}); });
fixmeIvy('unknown').it('should throw for missing dependencies', () => { fixmeIvy('FW-807: NgModule injector don\'t report full search path if a token is not found')
expect(() => createAndGetRootNodes(compViewDef([ .it('should throw for missing dependencies', () => {
elementDef(0, NodeFlags.None, null, null, 1, 'span'), expect(() => createAndGetRootNodes(compViewDef([
directiveDef(1, NodeFlags.None, null, 0, SomeService, ['nonExistingDep']) elementDef(0, NodeFlags.None, null, null, 1, 'span'),
]))) directiveDef(1, NodeFlags.None, null, 0, SomeService, ['nonExistingDep'])
.toThrowError( ])))
'StaticInjectorError(DynamicTestModule)[nonExistingDep]: \n' + .toThrowError(
' StaticInjectorError(Platform: core)[nonExistingDep]: \n' + 'StaticInjectorError(DynamicTestModule)[nonExistingDep]: \n' +
' NullInjectorError: No provider for nonExistingDep!'); ' StaticInjectorError(Platform: core)[nonExistingDep]: \n' +
}); ' NullInjectorError: No provider for nonExistingDep!');
});
it('should use null for optional missing dependencies', () => { it('should use null for optional missing dependencies', () => {
createAndGetRootNodes(compViewDef([ createAndGetRootNodes(compViewDef([

2
packages/core/testing/src/r3_test_bed.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {ApplicationInitStatus, Component, Directive, Injector, NgModule, NgZone, Pipe, PlatformRef, Provider, RendererFactory2, SchemaMetadata, Type, ɵInjectableDef as InjectableDef, ɵNgModuleDef as NgModuleDef, ɵNgModuleTransitiveScopes as NgModuleTransitiveScopes, ɵRender3ComponentFactory as ComponentFactory, ɵRender3NgModuleRef as NgModuleRef, ɵcompileComponent as compileComponent, ɵcompileDirective as compileDirective, ɵcompileNgModuleDefs as compileNgModuleDefs, ɵcompilePipe as compilePipe, ɵgetInjectableDef as getInjectableDef, ɵpatchComponentDefWithScope as patchComponentDefWithScope, ɵstringify as stringify} from '@angular/core'; import {ApplicationInitStatus, Component, Directive, Injector, NgModule, NgZone, Pipe, PlatformRef, Provider, SchemaMetadata, Type, ɵInjectableDef as InjectableDef, ɵNgModuleDef as NgModuleDef, ɵNgModuleTransitiveScopes as NgModuleTransitiveScopes, ɵRender3ComponentFactory as ComponentFactory, ɵRender3NgModuleRef as NgModuleRef, ɵcompileComponent as compileComponent, ɵcompileDirective as compileDirective, ɵcompileNgModuleDefs as compileNgModuleDefs, ɵcompilePipe as compilePipe, ɵgetInjectableDef as getInjectableDef, ɵpatchComponentDefWithScope as patchComponentDefWithScope, ɵstringify as stringify} from '@angular/core';
import {ComponentFixture} from './component_fixture'; import {ComponentFixture} from './component_fixture';
import {MetadataOverride} from './metadata_override'; import {MetadataOverride} from './metadata_override';

3
packages/core/testing/src/test_bed.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {ApplicationInitStatus, CompilerOptions, Component, Directive, Injector, NgModule, NgModuleFactory, NgModuleRef, NgZone, Optional, Pipe, PlatformRef, Provider, SchemaMetadata, SkipSelf, StaticProvider, Type, ɵAPP_ROOT as APP_ROOT, ɵDepFlags as DepFlags, ɵInjectableDef as InjectableDef, ɵNodeFlags as NodeFlags, ɵclearOverrides as clearOverrides, ɵgetComponentViewDefinitionFactory as getComponentViewDefinitionFactory, ɵgetInjectableDef as getInjectableDef, ɵivyEnabled as ivyEnabled, ɵoverrideComponentView as overrideComponentView, ɵoverrideProvider as overrideProvider, ɵstringify as stringify} from '@angular/core'; import {ApplicationInitStatus, CompilerOptions, Component, Directive, Injector, NgModule, NgModuleFactory, NgModuleRef, NgZone, Optional, Pipe, PlatformRef, Provider, SchemaMetadata, SkipSelf, StaticProvider, Type, ɵAPP_ROOT as APP_ROOT, ɵDepFlags as DepFlags, ɵInjectableDef as InjectableDef, ɵNodeFlags as NodeFlags, ɵclearOverrides as clearOverrides, ɵgetInjectableDef as getInjectableDef, ɵivyEnabled as ivyEnabled, ɵoverrideComponentView as overrideComponentView, ɵoverrideProvider as overrideProvider, ɵstringify as stringify} from '@angular/core';
import {AsyncTestCompleter} from './async_test_completer'; import {AsyncTestCompleter} from './async_test_completer';
import {ComponentFixture} from './component_fixture'; import {ComponentFixture} from './component_fixture';
@ -15,6 +15,7 @@ import {TestBedRender3, _getTestBedRender3} from './r3_test_bed';
import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common'; import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common';
import {TestingCompiler, TestingCompilerFactory} from './test_compiler'; import {TestingCompiler, TestingCompilerFactory} from './test_compiler';
const UNDEFINED = new Object(); const UNDEFINED = new Object();