cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): trigger directive inputs with i18n translations (#30402)

Browse Source 
Changed runtime i18n to define attributes with bindings, or matching directive inputs/outputs as element properties as we are supposed to do in Angular.
This PR fixes the issue where directive inputs wouldn't be trigged.

FW-1315 #resolve
PR Close #30402
This commit is contained in:
Olivier Combe
2019-05-15 14:27:07 +02:00
committed by Matias Niemelä
parent 41f372fe79
commit 91699259b2
5 changed files with 105 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.ts
View File

@ -197,7 +197,7 @@ describe('i18n support in the view compiler', () => {
else {
$I18N_0$ = $r3$.ɵɵi18nLocalize("Content A");
}
const $_c2$ = ["title", "Title B"];
const $_c2$ = [${AttributeMarker.Bindings}, "title"];
var $I18N_3$;
if (ngI18nClosureMode) {
/**
@ -211,7 +211,6 @@ describe('i18n support in the view compiler', () => {
$I18N_3$ = $r3$.ɵɵi18nLocalize("Title B");
}
const $_c5$ = ["title", $I18N_3$];
const $_c6$ = ["title", "Title C"];
var $I18N_7$;
if (ngI18nClosureMode) {
/**
@ -224,7 +223,6 @@ describe('i18n support in the view compiler', () => {
$I18N_7$ = $r3$.ɵɵi18nLocalize("Title C");
}
const $_c9$ = ["title", $I18N_7$];
const $_c10$ = ["title", "Title D"];
var $I18N_11$;
if (ngI18nClosureMode) {
/**
@ -238,7 +236,6 @@ describe('i18n support in the view compiler', () => {
$I18N_11$ = $r3$.ɵɵi18nLocalize("Title D");
}
const $_c13$ = ["title", $I18N_11$];
const $_c14$ = ["title", "Title E"];
var $I18N_15$;
if (ngI18nClosureMode) {
/**
@ -251,7 +248,6 @@ describe('i18n support in the view compiler', () => {
$I18N_15$ = $r3$.ɵɵi18nLocalize("Title E");
}
const $_c17$ = ["title", $I18N_15$];
const $_c18$ = ["title", "Title F"];
var $I18N_19$;
if (ngI18nClosureMode) {
const $MSG_EXTERNAL_idF$$APP_SPEC_TS_20$ = goog.getMsg("Title F");
@ -261,7 +257,6 @@ describe('i18n support in the view compiler', () => {
$I18N_19$ = $r3$.ɵɵi18nLocalize("Title F");
}
const $_c21$ = ["title", $I18N_19$];
const $_c22$ = ["title", "Title G"];
var $I18N_23$;
if (ngI18nClosureMode) {
/**
@ -335,7 +330,7 @@ describe('i18n support in the view compiler', () => {
`;
const output = `
const $_c0$ = ["id", "static", "title", "introduction"];
const $_c0$ = ["id", "static", ${AttributeMarker.Bindings}, "title"];
var $I18N_1$;
if (ngI18nClosureMode) {
/**
@ -376,7 +371,7 @@ describe('i18n support in the view compiler', () => {
`;
const output = String.raw `
const $_c0$ = ["id", "dynamic-1", "aria-roledescription", "static text", ${AttributeMarker.Bindings}, "title", "aria-label"];
const $_c0$ = ["id", "dynamic-1", ${AttributeMarker.Bindings}, "aria-roledescription", "title", "aria-label"];
var $I18N_1$;
if (ngI18nClosureMode) {
const $MSG_EXTERNAL_5526535577705876535$$APP_SPEC_TS_1$ = goog.getMsg("static text");
@ -603,8 +598,8 @@ describe('i18n support in the view compiler', () => {
const output = String.raw `
const $_c0$ = [
"id", "dynamic-1", "aria-roledescription", "static text",
${AttributeMarker.Bindings}, "title", "aria-label"
"id", "dynamic-1",
${AttributeMarker.Bindings}, "aria-roledescription", "title", "aria-label"
];
var $I18N_1$;
if (ngI18nClosureMode) {
@ -781,7 +776,7 @@ describe('i18n support in the view compiler', () => {
`;
const output = String.raw `
const $_c0$ = ["title", "Element title"];
const $_c0$ = [${AttributeMarker.Bindings}, "title"];
var $I18N_0$;
if (ngI18nClosureMode) {
/**