cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: use isObservable provided by rxjs 6.1+ (#27668)

Browse Source 
Refactor common, core, forms, router to use the isObservable method from rxjs 6.1+. Remove the isObservable method from core.

PR Close #27668
This commit is contained in:
Christopher Dahm
2018-12-14 12:19:26 -05:00
committed by Miško Hevery
parent c291c8e2cb
commit 92c547830a
13 changed files with 22 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/core/test/util/lang_spec.ts
View File

@ -5,8 +5,7 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {isObservable, isPromise} from '@angular/core/src/util/lang';
import {of } from 'rxjs';
import {isPromise} from '@angular/core/src/util/lang';
{
describe('isPromise', () => {
@ -26,22 +25,4 @@ import {of } from 'rxjs';
expect(isPromise(null)).toEqual(false);
});
});
describe('isObservable', () => {
it('should be true for an Observable', () => expect(isObservable(of (true))).toEqual(true));
it('should be true if the argument is the object with subscribe function',
() => expect(isObservable({subscribe: () => {}})).toEqual(true));
it('should be false if the argument is undefined',
() => expect(isObservable(undefined)).toEqual(false));
it('should be false if the argument is null', () => expect(isObservable(null)).toEqual(false));
it('should be false if the argument is an object',
() => expect(isObservable({})).toEqual(false));
it('should be false if the argument is a function',
() => expect(isObservable(() => {})).toEqual(false));
});
}