cargdev/angular
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): remove unneeded detach property (#28595)

Browse Source 
PR Close #28595
This commit is contained in:
Olivier Combe
2019-02-07 17:03:29 +01:00
committed by Miško Hevery
parent 9d109929be
commit 94f042beba
5 changed files with 12 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/core/src/render3/node_manipulation.ts
View File

@ -340,19 +340,16 @@ export function insertView(
*
* @param lContainer The container from which to detach a view
* @param removeIndex The index of the view to detach
* @param detached Whether or not this view is already detached.
* @returns Detached LView instance.
*/
export function detachView(lContainer: LContainer, removeIndex: number, detached: boolean): LView {
export function detachView(lContainer: LContainer, removeIndex: number): LView {
const views = lContainer[VIEWS];
const viewToDetach = views[removeIndex];
if (removeIndex > 0) {
views[removeIndex - 1][NEXT] = viewToDetach[NEXT] as LView;
}
views.splice(removeIndex, 1);
if (!detached) {
addRemoveViewFromContainer(viewToDetach, false);
}
addRemoveViewFromContainer(viewToDetach, false);
if (viewToDetach[QUERIES]) {
viewToDetach[QUERIES] !.removeView();
@ -368,14 +365,11 @@ export function detachView(lContainer: LContainer, removeIndex: number, detached
* Removes a view from a container, i.e. detaches it and then destroys the underlying LView.
*
* @param lContainer The container from which to remove a view
* @param tContainer The TContainer node associated with the LContainer
* @param removeIndex The index of the view to remove
*/
export function removeView(
lContainer: LContainer, containerHost: TElementNode | TContainerNode | TElementContainerNode,
removeIndex: number) {
export function removeView(lContainer: LContainer, removeIndex: number) {
const view = lContainer[VIEWS][removeIndex];
detachView(lContainer, removeIndex, !!containerHost.detached);
detachView(lContainer, removeIndex);
destroyLView(view);
}