From 951bd33b0905e0f1417d9f1f03f7b4704562d450 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Thu, 26 Oct 2017 11:00:13 -0700 Subject: [PATCH] build: add `release` as a valid commit message subject (#19955) PR Close #19955 --- tools/validate-commit-message/commit-message.json | 1 + .../validate-commit-message/validate-commit-message.spec.js | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/validate-commit-message/commit-message.json b/tools/validate-commit-message/commit-message.json index 1d5c98053f..13e87f65e8 100644 --- a/tools/validate-commit-message/commit-message.json +++ b/tools/validate-commit-message/commit-message.json @@ -8,6 +8,7 @@ "fix", "perf", "refactor", + "release", "style", "test" ], diff --git a/tools/validate-commit-message/validate-commit-message.spec.js b/tools/validate-commit-message/validate-commit-message.spec.js index 468865efb5..4b13d96071 100644 --- a/tools/validate-commit-message/validate-commit-message.spec.js +++ b/tools/validate-commit-message/validate-commit-message.spec.js @@ -37,6 +37,8 @@ describe('validate-commit-message.js', function() { expect(validateMessage('refactor(platform-webworker): something')).toBe(VALID); expect(validateMessage('test(language-service): something')).toBe(VALID); expect(validateMessage('test(packaging): something')).toBe(VALID); + expect(validateMessage('release: something')).toBe(VALID); + expect(validateMessage('release(packaging): something')).toBe(VALID); expect(errors).toEqual([]); }); @@ -65,6 +67,7 @@ describe('validate-commit-message.js', function() { .forEach((expectedErrorMessage, index) => { expect(expectedErrorMessage).toEqual(errors[index]); }); + expect(validateMessage('release(angular): something')).toBe(INVALID); }); @@ -106,7 +109,7 @@ describe('validate-commit-message.js', function() { expect(errors).toEqual( ['INVALID COMMIT MSG: "weird($filter): something"\n' + ' => ERROR: weird is not an allowed type.\n' + - ' => TYPES: build, ci, docs, feat, fix, perf, refactor, style, test']); + ' => TYPES: build, ci, docs, feat, fix, perf, refactor, release, style, test']); });