From 95383ee6a92e9da717f0f55ff133fbfc8a5e120c Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Mon, 27 Jan 2020 12:59:51 -0800 Subject: [PATCH] ci: don't run benchmark_tests on remote executors (#34996) Since benchmarks are meant to test in a consistent environment, we cannot execute the benchmark on RBE executors as executors do not run in calibrated environments. PR Close #34996 --- modules/benchmarks/benchmark_test.bzl | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/benchmarks/benchmark_test.bzl b/modules/benchmarks/benchmark_test.bzl index ca0fcb0ca4..a6d6442004 100644 --- a/modules/benchmarks/benchmark_test.bzl +++ b/modules/benchmarks/benchmark_test.bzl @@ -17,7 +17,13 @@ def benchmark_test(name, server, tags = [], **kwargs): on_prepare = "//modules/benchmarks:start-server.js", server = server, # Benchmark targets should not run on CI by default. - tags = tags + ["manual"], - test_suite_tags = ["manual"], + tags = tags + [ + "manual", + "no-remote-exec", + ], + test_suite_tags = [ + "manual", + "no-remote-exec", + ], **kwargs )