From 957384ceebba3a8a175472bdc6e86be1461ead84 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Wed, 15 Apr 2015 18:17:22 -0700 Subject: [PATCH] fix: Fix issues found by Dart analyzer --- modules/angular2/globals.dart | 1 + modules/angular2/src/core/compiler/base_query_list.dart | 2 +- modules/angular2/src/facade/browser.dart | 1 + modules/angular2/src/services/xhr_impl.dart | 2 ++ .../angular2/src/transform/directive_processor/rewriter.dart | 2 +- .../angular2/src/transform/directive_processor/visitors.dart | 2 +- modules/angular2/test/core/compiler/view_factory_spec.js | 1 - modules/angular2/test/di/binding_dart_spec.dart | 1 + 8 files changed, 8 insertions(+), 4 deletions(-) diff --git a/modules/angular2/globals.dart b/modules/angular2/globals.dart index 6f7bcd7000..225a45bff6 100644 --- a/modules/angular2/globals.dart +++ b/modules/angular2/globals.dart @@ -1,2 +1,3 @@ // Globals are provided by lang.dart in Dart. // This file exists to prevent global.ts from being transpiled. +library angular2.globals; diff --git a/modules/angular2/src/core/compiler/base_query_list.dart b/modules/angular2/src/core/compiler/base_query_list.dart index 0c6a7cf7ef..062cf44cd3 100644 --- a/modules/angular2/src/core/compiler/base_query_list.dart +++ b/modules/angular2/src/core/compiler/base_query_list.dart @@ -1,4 +1,4 @@ -library angular2.src.core.compiler.query_list; +library angular2.src.core.compiler.base_query_list; import 'package:angular2/src/core/annotations/annotations.dart'; import 'dart:collection'; diff --git a/modules/angular2/src/facade/browser.dart b/modules/angular2/src/facade/browser.dart index 3c84a5a289..db3ff02cd4 100644 --- a/modules/angular2/src/facade/browser.dart +++ b/modules/angular2/src/facade/browser.dart @@ -2,6 +2,7 @@ * Dart version of browser APIs. This library depends on 'dart:html' and * therefore can only run in the browser. */ +library angular2.src.facade.browser; import 'dart:js' show context; diff --git a/modules/angular2/src/services/xhr_impl.dart b/modules/angular2/src/services/xhr_impl.dart index 1025023b7c..2997d71cc9 100644 --- a/modules/angular2/src/services/xhr_impl.dart +++ b/modules/angular2/src/services/xhr_impl.dart @@ -1,3 +1,5 @@ +library angular2.src.services.xhr_impl; + import 'dart:async'; import 'dart:html'; import 'package:angular2/di.dart'; diff --git a/modules/angular2/src/transform/directive_processor/rewriter.dart b/modules/angular2/src/transform/directive_processor/rewriter.dart index 50eae3c9bd..42fb181c3b 100644 --- a/modules/angular2/src/transform/directive_processor/rewriter.dart +++ b/modules/angular2/src/transform/directive_processor/rewriter.dart @@ -1,4 +1,4 @@ -library angular2.transform.directive_processor; +library angular2.transform.directive_processor.rewriter; import 'package:analyzer/analyzer.dart'; import 'package:analyzer/src/generated/java_core.dart'; diff --git a/modules/angular2/src/transform/directive_processor/visitors.dart b/modules/angular2/src/transform/directive_processor/visitors.dart index 808fdbe5b0..c0ccaab13a 100644 --- a/modules/angular2/src/transform/directive_processor/visitors.dart +++ b/modules/angular2/src/transform/directive_processor/visitors.dart @@ -1,4 +1,4 @@ -library angular2.transform.directive_processor; +library angular2.transform.directive_processor.visitors; import 'package:analyzer/analyzer.dart'; import 'package:analyzer/src/generated/java_core.dart'; diff --git a/modules/angular2/test/core/compiler/view_factory_spec.js b/modules/angular2/test/core/compiler/view_factory_spec.js index eef71f16c9..94b9c50cfd 100644 --- a/modules/angular2/test/core/compiler/view_factory_spec.js +++ b/modules/angular2/test/core/compiler/view_factory_spec.js @@ -17,7 +17,6 @@ import { import {IMPLEMENTS, isBlank} from 'angular2/src/facade/lang'; import {ViewFactory} from 'angular2/src/core/compiler/view_factory'; import {AppProtoView, AppView} from 'angular2/src/core/compiler/view'; -import {dynamicChangeDetection} from 'angular2/change_detection'; import {DirectiveBinding, ElementInjector} from 'angular2/src/core/compiler/element_injector'; import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader'; import {Component} from 'angular2/src/core/annotations/annotations'; diff --git a/modules/angular2/test/di/binding_dart_spec.dart b/modules/angular2/test/di/binding_dart_spec.dart index d958703b59..0a8624d3f2 100644 --- a/modules/angular2/test/di/binding_dart_spec.dart +++ b/modules/angular2/test/di/binding_dart_spec.dart @@ -1,5 +1,6 @@ /// This file contains tests that make sense only in Dart world, such as /// verifying that things are valid constants. +library angular2.test.di.binding_dart_spec; import 'dart:mirrors'; import 'package:angular2/test_lib.dart';