From 9690e36f78543d73fb700ba43ce2d53f95e8509a Mon Sep 17 00:00:00 2001
From: Paul Gschwendtner <paulgschwendtner@gmail.com>
Date: Tue, 12 Feb 2019 19:23:53 +0100
Subject: [PATCH] build: update instructions to run benchmark tests (#28697)

* Updates the instructions on how to run the benchmark tests.
* Removes the unused `favicon.ico` file and the corresponding Bazel filegroup

PR Close #28697
---
 modules/benchmarks/BUILD.bazel |   7 ------
 modules/benchmarks/README.md   |  40 ++++++++++-----------------------
 modules/benchmarks/favicon.ico | Bin 5430 -> 0 bytes
 3 files changed, 12 insertions(+), 35 deletions(-)
 delete mode 100644 modules/benchmarks/favicon.ico

diff --git a/modules/benchmarks/BUILD.bazel b/modules/benchmarks/BUILD.bazel
index 4067818ff2..7159d1f14b 100644
--- a/modules/benchmarks/BUILD.bazel
+++ b/modules/benchmarks/BUILD.bazel
@@ -5,10 +5,3 @@ exports_files([
     "tsconfig-e2e.json",
     "start-server.js",
 ])
-
-filegroup(
-    name = "favicon",
-    srcs = [
-        "favicon.ico",
-    ],
-)
diff --git a/modules/benchmarks/README.md b/modules/benchmarks/README.md
index bc8a8ccf98..2acb18b650 100644
--- a/modules/benchmarks/README.md
+++ b/modules/benchmarks/README.md
@@ -3,39 +3,23 @@
 ## Run in the browser
 
 ```bash
-# Build the Angular packages.
-yarn tsc -p packages/
+yarn bazel run modules/benchmarks/src/tree/{name}:devserver
 
-# Build the e2e tests which are part of the "modules/"
-./modules/build.sh
-
-# Start server that serves all benchmark e2e apps.
-yarn gulp serve
-```
-
-Now you can open benchmark e2e apps using their appropriate URLs. For example:
-
-```
-http://localhost:8000/all/benchmarks/src/tree/ng2/index.html
+# e.g. "ng2" tree benchmark:
+yarn bazel run modules/benchmarks/src/tree/ng2:devserver
 ```
 
 ## Run e2e tests
-$ export NODE_PATH=$(pwd)/dist/all:$(pwd)/dist/tools
-$ ./node_modules/.bin/protractor protractor-e2e.conf.js --specs=dist/all/benchmarks/e2e_test/tree_spec.js
 
-Options for protractor with `protractor-e2e.conf.js`:
-- `--bundles=true`: use prebuilt bundles
-- `--ng-help`: show all available options
+```
+# Run e2e tests of individual applications:
+yarn bazel test modules/benchmarks/src/tree/ng2/...
 
-## Run benchmarks tests
-$ export NODE_PATH=$(pwd)/dist/all:$(pwd)/dist/tools
-$ ./node_modules/.bin/protractor protractor-perf.conf.js --specs=dist/all/benchmarks/e2e_test/tree_perf.js
+# Run all e2e tests:
+yarn bazel test modules/benchmarks/...
+```
 
-Options for protractor with `protractor-perf.conf.js`:
-- `--bundles=true`: use prebuilt bundles
-- `--ng-help`: show all available options
+## Use of *_aot.ts files
 
-## Compile *_aot.ts files
-
-These files are compiled as part of the compiler_cli integration tests.
-See `@angular/compile_cli/integrationtest/tsconfig.json`
+The `*_aot.ts` files are used as entry-points within Google to run the benchmark
+tests. These are still built as part of the corresponding `ng_module` rule.
diff --git a/modules/benchmarks/favicon.ico b/modules/benchmarks/favicon.ico
deleted file mode 100644
index 8081c7ceaf2be08bf59010158c586170d9d2d517..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 5430
zcmc(je{54#6vvCoAI3i*G5%$U7!sA3wtMZ$fH6V9C`=eXGJb@R1%(I_{vnZtpD{6n
z5Pl{DmxzBDbrB>}`90e12m8T*36WoeDLA&SD_hw{H^wM!cl_RWcVA!I+x87ee975;
z@4kD^=bYPn&pmG@(+JZ`rqQEKxW<}RzhW}I!|ulN=fmjVi@x{p$cC`)5$a!)X&U<D
zFCrQtlPskre}dB7oMCp>+blKNvN5tg=uLvuLnuqRM;Yc*swiexsoh#XPNu{9F#c`G
zQLe{yWA(Y6(;>y|-e<R78l|^`vH6ft-mErSG~Y`TZF2qm1=W=MNd^2V3)n2xIl=~X
zcQ9VjzHW38ty|rZz+bkcR(-c)`wbqC#l0CF>fAy11k<09(@Oo1B2@0`PtZSkqK&${
zgEY}`W@t{%?9u5rF?}Y7OL{338l<M%K~-+w4iJ-2C_>*JY#P!%MVQY@oqnItpZ}?s
z!r?*kwuR{A@jg2Chlf0^{q*>8n5Ir~YWf*wmsh7B5&EpHfd5@xVaj&gqsdui^spyL
zB|kUoblGoO7G(MuKTfa9?pGH0@QP^b#!lM1yHWLh*2iq#`C1TdrnO-d#?Oh@XV2HK
zKA{`eo{--^K&MW66Lgsktfvn#cCAc*(}qsfhrvOjMGLE?`dHVipu1J3Kgr%g?cNa8
z)pkmC8DGH~fG+dlrp(5^-QBeEvkOvv#q7MBVLtm2oD^$lJZx--_=K&Ttd=-krx(Bb
zcEoKJda@S!%%@`P-##$>*u%T*mh+QjV@)Qa=Mk1?#zLk+M4tIt%}wagT{5<jKE$zW
zf^v7jW~uUE-%mB7^CHH8TL1|_urI~hKTTLO4e;Zw7r~I(052QT!nq=k3BK4rWn{P1
zm1bHmzb3QsEPddOfehts!4+*he<-J0Tp_H*ozKD(I$*vEIRc5vL3kd@p{$kjMIKQs
z<pI0(Vu7$}v<2fENHCVA=ZgE(eBp=9a;_O`BkfrU-cm?UdhYP}+z)k)*4wQOW0K7S
zxLV9h7PeF2dOvMg->J%!tXAE;r{@=bb%nNVxvI+C+$t?!VJ@0d@HIyMJTI{vEw0Ul
ze(ha!e&qANbTL1ZneNl45t=#Ot??C0MHjjgY8%*mGisN|S6%g3;Hlx#fMNcL<87MW
zZ>6moo1YD?P!fJ#Jb(4)_cc50X5n0KoDYfdPoL^iV`k&o{LPyaoqMqk92wVM#_O0l
z09$(A-D+gVIlq4TA&{1T@BsUH`Bm=r#l$Z51J<A&BjWib@$s|gZJQqmbJQD%pmuqr
zlRi3r%o8I$s7b`Nd|6!*{)IIXevOQu?P#Tr`(a_yaC`Z3mz2%s0J*VP!oMryv%aGJ
zJ%+hr;JUR9N%=NQUAcsxH1Ev(z=Jw5x*3ZP^w64B9T1;d$FN#v|K3{yO?U3}p#~CX
zQeul5J0S-k&QP-WS^uxU^lJ9qPEkik*MChluj|;LEt~#I8atbRn<NLMVzYM(P(Mc^
z+=Vcf!|a)D*bAJ$B)>-U&F32+hfUP-iLo=jg7Xmy+WLq6_tWv&`wDlz#`&)Jp~iQf
zZP)tu>}pIIJKuw+$&t}GQuqMd%Z>0?t%&BM&W<om&b&wS^Ui5`y0`bK`dz>o^4P^Y
z)c6h^f2R>X8*}q|bblAF?@;%?2>$y+cMQbN{X$)^R>v<j%HOoXFL3nF-$ASizAu7L
zA~a)K^qdiKCTsOM0PF^%{K=Uu<ZEZkC-ypeB>tNq_5AB|0N5U*d^T?X9{xQnJYeU{
zoZL#obI;~Pp95f1`%X3D$Mh*4^?O?IT~7HqlWguezmg?Ybq|7>qQ(@pPHbE9V?f|(
z+0xo!#m@Np9PljsyxBY-UA*{U*la#8Wz2sO|48_-5t8%_!n?S$zlGe+NA%?vmxjS-
zHE5O3ZarU=X}$7>;Okp(UWXJxI%G_J-@IH;%5#Rt$(WUX?6*Ux!IRd$dLP6+SmPn=
z8zjm4jGjN772R{FGkXwcNv8GBcZI#@Y2m{RNF_w8(Z%^A*!bS*!}s6sh*NnURytky
humW;*g7R+&|Ledvc-<M)bUEqtWbbwV3iw}c{{uEu@7@3a