cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(router): add the ANALYZE_FOR_PRECOMPILE provider to make dev ergonomics better

Browse Source
This commit is contained in:
vsavkin
2016-07-07 17:53:26 -07:00
parent 46e105f3ab
commit 96a9e66616
5 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/@angular/router/src/common_router_providers.ts
View File

@ -7,7 +7,7 @@
*/
import {Location, LocationStrategy, PathLocationStrategy} from '@angular/common';
import {APP_INITIALIZER, AppModuleFactoryLoader, ApplicationRef, ComponentResolver, Injector, OpaqueToken, SystemJsAppModuleLoader} from '@angular/core';
import {ANALYZE_FOR_PRECOMPILE, APP_INITIALIZER, AppModuleFactoryLoader, ApplicationRef, ComponentResolver, Injector, OpaqueToken, SystemJsAppModuleLoader} from '@angular/core';
import {Routes} from './config';
import {Router} from './router';
@ -84,6 +84,7 @@ export function setupRouterInitializer(injector: Injector) {
*/
export function provideRouter(routes: Routes, config: ExtraOptions): any[] {
return [
{provide: ANALYZE_FOR_PRECOMPILE, multi: true, useValue: routes},
{provide: ROUTES, useExisting: ROUTER_CONFIG}, {provide: ROUTER_CONFIG, useValue: routes},
{provide: ROUTER_CONFIGURATION, useValue: config}, Location,
@ -125,7 +126,10 @@ export function provideRouter(routes: Routes, config: ExtraOptions): any[] {
* @experimental
*/
export function provideRoutes(routes: Routes): any {
return {provide: ROUTES, useValue: routes};
return [
{provide: ANALYZE_FOR_PRECOMPILE, multi: true, useValue: routes},
{provide: ROUTES, useValue: routes}
];
}
/**

15
modules/@angular/router/src/directives/router_outlet.ts
View File

@ -74,15 +74,12 @@ export class RouterOutlet {
}
} catch (e) {
if (!(e instanceof NoComponentFactoryError)) throw e;
// TODO: vsavkin uncomment this once ComponentResolver is deprecated
// const componentName = component ? component.name : null;
// console.warn(
// `'${componentName}' not found in precompile array. To ensure all components referred
// to by the Routes are compiled, you must add '${componentName}' to the
// 'precompile' array of your application component. This will be required in a future
// release of the router.`);
const componentName = component ? component.name : null;
console.warn(
`'${componentName}' not found in precompile array. To ensure all components referred
to by the Routes are compiled, you must add '${componentName}' to the
'precompile' array of your application component. This will be required in a future
release of the router.`);
factory = snapshot._resolvedComponentFactory;
}