cargdev/angular
1
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(upgrade): fix examples for strictPropertyInitialization and remove internal comments (#18487)

Browse Source 
PR Close #18487
This commit is contained in:
George Kalpakas
2018-06-25 21:38:21 +03:00
committed by Jason Aden
parent 9378f44d6d
commit 97897ab738
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/examples/upgrade/static/ts/full/module.ts
View File

@ -39,7 +39,7 @@ class TextFormatter {
<button (click)="addHero.emit()">Add Hero</button>`, <button (click)="addHero.emit()">Add Hero</button>`,
}) })
class Ng2HeroesComponent { class Ng2HeroesComponent {
@Input() heroes: Hero[]; @Input() heroes !: Hero[];
@Output() addHero = new EventEmitter(); @Output() addHero = new EventEmitter();
@Output() removeHero = new EventEmitter(); @Output() removeHero = new EventEmitter();
} }
@ -77,9 +77,7 @@ class HeroesService {
class Ng1HeroComponentWrapper extends UpgradeComponent { class Ng1HeroComponentWrapper extends UpgradeComponent {
// The names of the input and output properties here must match the names of the // The names of the input and output properties here must match the names of the
// `<` and `&` bindings in the AngularJS component that is being wrapped // `<` and `&` bindings in the AngularJS component that is being wrapped
// TODO(issue/24571): remove '!'.
@Input() hero !: Hero; @Input() hero !: Hero;
// TODO(issue/24571): remove '!'.
@Output() onRemove !: EventEmitter<void>; @Output() onRemove !: EventEmitter<void>;
constructor(@Inject(ElementRef) elementRef: ElementRef, @Inject(Injector) injector: Injector) { constructor(@Inject(ElementRef) elementRef: ElementRef, @Inject(Injector) injector: Injector) {
// We must pass the name of the directive as used by AngularJS to the super // We must pass the name of the directive as used by AngularJS to the super

4
packages/examples/upgrade/static/ts/lite/module.ts
View File

@ -104,8 +104,8 @@ class Ng2HeroesComponent {
class Ng1HeroComponentWrapper extends UpgradeComponent { class Ng1HeroComponentWrapper extends UpgradeComponent {
// The names of the input and output properties here must match the names of the // The names of the input and output properties here must match the names of the
// `<` and `&` bindings in the AngularJS component that is being wrapped. // `<` and `&` bindings in the AngularJS component that is being wrapped.
@Input() hero: Hero; @Input() hero !: Hero;
@Output() onRemove: EventEmitter<void>; @Output() onRemove !: EventEmitter<void>;
constructor(elementRef: ElementRef, injector: Injector) { constructor(elementRef: ElementRef, injector: Injector) {
// We must pass the name of the directive as used by AngularJS to the super. // We must pass the name of the directive as used by AngularJS to the super.