cargdev/angular
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

build: enforce proper compile mode for size-tracking test (#32613)

Browse Source 
Ensures that the "core_all:size_test" target runs with "--define=compile=aot".
This is necessary because we don't run this test on CI currently, but if we run
it manually, we need to ensure that it runs with Ivy for proper size comparisons.

PR Close #32613
This commit is contained in:
Paul Gschwendtner
2019-09-11 19:46:40 +02:00
committed by Matias Niemelä
parent f0a969579d
commit 97dae900fb
3 changed files with 39 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/test/bundling/core_all/BUILD.bazel
View File

@ -32,10 +32,14 @@ js_size_tracking_test(
":bundle",
":bundle.golden_size_map.json",
],
goldenFile = "angular/packages/core/test/bundling/core_all/bundle.golden_size_map.json",
maxByteDiff = 250,
maxPercentageDiff = 15,
sourceMap = "angular/packages/core/test/bundling/core_all/bundle.min.js.map",
golden_file = "angular/packages/core/test/bundling/core_all/bundle.golden_size_map.json",
max_byte_diff = 250,
max_percentage_diff = 15,
# Ensures that this target runs with "--define=compile=aot" (aka Ivy). This is necessary
# because we don't run this test on CI currently, but if we run it manually, we need to
# ensure that it runs with Ivy for proper size comparisons.
required_compile_mode = "aot",
source_map = "angular/packages/core/test/bundling/core_all/bundle.min.js.map",
tags = [
"ivy-only",
"manual",